Click here to Skip to main content
Rate this: bad
good
Please Sign up or sign in to vote.
Hi everyone, I got tasked in my company to improve the way design reviews and code reviews are done here. Currently code reviews are not really useful, they tend to be just stamping reviews, and design reviews although mandatory are non-existent.
 
I'm looking for opinions, tips, anything that might shed some light into how to make reviews effective, lean and interesting for the parties involved.
 
Thanks!
Posted 26-Jul-12 6:49am
janocho465
Comments
wizardzz at 26-Jul-12 14:17pm
   
Great question. Since it isn't necessarily a programming question, you could probably ask this in the Lounge and good a plethora of good and sarcastic responses.
Tim Corey at 26-Jul-12 14:36pm
   
No one in the lounge is ever sarcastic.
OriginalGriff at 26-Jul-12 14:52pm
   
I said we need a Sarcicon!
janocho at 26-Jul-12 15:40pm
   
thanks, I'll do that!
aspnet_regiis at 28-Jul-12 16:46pm
   
This is not something research and experiment task.. It needs a expert.. Why did the company give you the task if you don't know how to do it? I hope your employer does not come across this page...
janocho at 30-Jul-12 13:39pm
   
I do know how code reviews and design reviews are supposed to be done, I have quite a few years of experience in this, I'm a Personal Software Process certified developer, etc etc. This research is to find real-life experiences and tips cause as any developer knows the actual practice and implementation of reviews often is not effective and eventually dies within companies. Please stop responding to questions unless you have constructive info or help.

1 solution

Rate this: bad
good
Please Sign up or sign in to vote.

Solution 1

Good code reviews come from good culture and good hires. People generally need examples to follow to know how to do it well. Write down an explanation of what is expected of a code review, then present it. The person who sets the policy should have the respect of the team. Consider using a mandatory code review process organized by a code review tool.
 
Design reviews are a different matter. The first challenge is helping assure simple design documents are written when they need to be (and not written when they are not needed). After that, you can start by setting the tone that design reviews are to help the designer, not hamstring him. get teams to send design docs to team members for review, and create an escalation process for emailing to a group of senior engineers when folks need more help.
 
Good luck.
  Permalink  

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)



Advertise | Privacy | Mobile
Web01 | 2.8.141022.2 | Last Updated 29 Jul 2012
Copyright © CodeProject, 1999-2014
All Rights Reserved. Terms of Service
Layout: fixed | fluid

CodeProject, 503-250 Ferrand Drive Toronto Ontario, M3C 3G8 Canada +1 416-849-8900 x 100