error of connection open

Question

0.00/5 (No votes)

See more:

here i am getting this error

System.invalidOperationException: There is already an open Reader that must be closed first

The code is:

VB

Dim temp As Integer = 0
str = "select CaseId  from New_Case_Id_Master where CaseId >" & temp & ""
cmd = New SqlCommand(str, cn.getConnection())
dr = cmd.ExecuteReader()
If dr.Read = False Then
    Dim s_temp As String
    s_temp = temp_no + "000001"
    s_no = Val(s_temp)

Else



    str = "select max(CaseId) from New_Case_Id_Master"
    cmd = New SqlCommand(str, cn.getConnection())
    dr = cmd.ExecuteReader()'showing this line number in error
    If dr.Read = True Then
        Dim s_no_temp, s_no_temp1 As String
        Dim no_temp As Integer
        no_temp = dr.Item(0)
        s_no_temp = no_temp.ToString

        s_no_temp1 = s_no_temp.Substring(0, 4)
        s_no = Val(s_no_temp1)

        If temp_no > s_no Then
            s_no = Val(temp_no.ToString + "000001")
        Else
            s_no = no_temp + 1
        End If
    End If

End If

Posted 20-Sep-12 1:03am

neldesai

Add a Solution

Comments

[no name] 20-Sep-12 7:06am

Yes and? The error is perfectly clear. dr is still open when you try and open it again.

neldesai 20-Sep-12 8:01am

thank you......

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

**Malli_S** · Accepted Answer · 2012-09-20T01:18:00

Check the underlined solution.

VB

Dim temp As Integer = 0
str = "select CaseId  from New_Case_Id_Master where CaseId >" & temp & ""
cmd = New SqlCommand(str, cn.getConnection())
dr = cmd.ExecuteReader()
If dr.Read = False Then
    Dim s_temp As String
    s_temp = temp_no + "000001"
    s_no = Val(s_temp)

Else
    str = "select max(CaseId) from New_Case_Id_Master"
    cmd = New SqlCommand(str, cn.getConnection())
    dr.Close();
    dr = cmd.ExecuteReader()'showing this line number in error
    If dr.Read = True Then
        Dim s_no_temp, s_no_temp1 As String
        Dim no_temp As Integer
        no_temp = dr.Item(0)
        s_no_temp = no_temp.ToString

        s_no_temp1 = s_no_temp.Substring(0, 4)
        s_no = Val(s_no_temp1)

        If temp_no > s_no Then
            s_no = Val(temp_no.ToString + "000001")
        Else
            s_no = no_temp + 1
        End If
    End If

End If

Hope you are using the dr outside this function. If not, please close that data reader (dr) before exiting the function (as it seems member/global variable).