Transaction no has already been decleared

Question

0.00/5 (No votes)

See more:

want to insert data of gridview to database, got an error ->"Transaction no has already been decleared" Plz help me with this. Thanx

C#

String query = "insert into Account_Credit(Transaction_No,Account_No,Amount_Credit,Credit_Date,Total_Amount_Credit)values(@Transaction_No,@Account_No,@Amount_Credit,@Credit_Date,@Total_Amount_Credit)";
                cmd = new SqlCommand(query, cn);
               cmd.Prepare();

               int i = dataGridView1.CurrentRow.Index;
               cmd.Parameters.AddWithValue("@Account_No", dataGridView1.Rows[i].Cells[0].Value);
               for (i = 0; i <= dataGridView1.Rows.Count - 1; i++)
               {


                   cmd.Parameters.AddWithValue("@Transaction_No", dataGridView1.Rows[i].Cells[1].Value);
                   cmd.Parameters.AddWithValue("@Amount_Credit", dataGridView1.Rows[i].Cells[2].Value);
                   cmd.Parameters.AddWithValue("@Credit_Date", dataGridView1.Rows[i].Cells[3].Value);
                   cmd.Parameters.AddWithValue("@Total_Amount_Credit", dataGridView1.Rows[i].Cells[4].Value);
                   cn.Open();


                   cmd.ExecuteNonQuery();
                   cn.Close();
               }

Posted 30-Dec-12 0:22am

zeshanazam

Updated 30-Dec-12 0:34am

Sandeep Mewara

v2

Add a Solution

Comments

Jibesh 30-Dec-12 6:43am

double check the order of the parameters added to the SQLCmd and the order in query are matched.
The First Parameter Passed to the SqlCmd is AcctionNo but inside the insert query its Transaction_No. Check that

zeshanazam 30-Dec-12 6:47am

u are wrong

Jibesh 30-Dec-12 6:50am

can you post the exception stack what you are getting for better understanding of the issue

zeshanazam 30-Dec-12 6:52am

loop works only for one time and then error occurs Transaction no has already been decleared

Jibesh 30-Dec-12 7:10am

moment...

what are you doing with query execution inside the loop? that means you are adding the parameters to the sqlCmd for each row. you need to reconsider the logic here.

i.e starting from Transaction_No the parameters are added again and again to the sql Cmd.

2 solutions

Solution 2

Change the query like below

C#

String query = "insert into Account_Credit(Transaction_No,Account_No,Amount_Credit,Credit_Date,Total_Amount_Credit)values(@Transaction_No,@Account_No,@Amount_Credit,@Credit_Date,@Total_Amount_Credit)";
          
int i = dataGridView1.CurrentRow.Index;
              
for (i = 0; i <= dataGridView1.Rows.Count - 1; i++)
{
    cmd = new SqlCommand(query, cn);
    cmd.Prepare();
    cmd.Parameters.AddWithValue("@Account_No", dataGridView1.Rows[i].Cells[0].Value);

    cmd.Parameters.AddWithValue("@Transaction_No", dataGridView1.Rows[i].Cells[1].Value);
    cmd.Parameters.AddWithValue("@Amount_Credit", dataGridView1.Rows[i].Cells[2].Value);
    cmd.Parameters.AddWithValue("@Credit_Date", dataGridView1.Rows[i].Cells[3].Value);
    cmd.Parameters.AddWithValue("@Total_Amount_Credit", dataGridView1.Rows[i].Cells[4].Value);
    cn.Open();

    cmd.ExecuteNonQuery();
    cn.Close();
}

Posted 30-Dec-12 1:13am

Jibesh

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2012-12-30T01:12:00

AddWithValue adds a parameter with its value to the current command. Since you are executing it in a loop, you need to remove existing copies of the parameters before you add new ones.
There are two things you can do:
1) Put this line at teh top of your loop:

C#

cmd.Parameters.Clear();

2) Add the parameters without values outside the loop, and then set the parameter values only inside the loop.