problem with delete vector**

Question

0.00/5 (No votes)

See more:

hi to all.
What is the problem? why? :-?

C++

std::vector<int>** indexes = new std::vector<int>*[8];
for(int i = 0; i < 8; i++)
{
    indexes[i] = new std::vector<int>[8];
}

//statments...

for(int i = 0; i < 8; i++)
{
    //problem is here !!!
    //Debug Assertion Failed!
    //expression : _BLOCK_TYPE_IS_VALID(pHead->nBlockUse)
    delete indexes[i];
}
delete indexes;

Posted 2-Jan-13 22:50pm

__UFNHGGI_H__

Add a Solution

Comments

Andreas Gieriet 3-Jan-13 16:32pm

Having a variable of type std:vector<int>** look dubious.
I suggest to revisit your data type design.
Your immediate question is well answered by CPallini in Solution#2, but the root cause of your problem is probably your data type implementation as highlighted by H.Brydon in solution#4.
Cheers
Andi

3 solutions

Solution 3

In my opinion, already the allocation is wrong:

indexes[i] = new std::vector<int>[8];

When I understand your code correctly, you want each cell indexes[i] to point to a std::vector<int>. So it should be:

indexes[i] = new std::vector<int>;

And of course, CPallini is right in that you should apply array brackets when finally deleting indexes. But this is not the problem that threw the assertion.

Posted 2-Jan-13 23:50pm

nv3

Updated 3-Jan-13 8:29am

v2

Comments

Philippe Mori 3-Jan-13 22:01pm

Or maybe new std::vector<int>(8); if you want an array with an initial size of 8 elements.

Add a Solution

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

CPallini · Accepted Answer · 2013-01-02T23:15:00

Solution 2

Quote:
delete indexes[i];

you forgot to delete[] on the array of objects, use:

C++

delete [] indexes[i];

Posted 2-Jan-13 23:15pm

CPallini

Comments

__UFNHGGI_H__ 3-Jan-13 5:19am

heeeeeeeeeeeeeeee.
thanks 1tera byte! :D

CPallini 3-Jan-13 5:23am

You are welcome.

H.Brydon · Accepted Answer · 2013-01-03T05:16:00

Looks like you want a 2D array. I would suggest instead something like:

C++

std::vector<std::vector<int>> indexes;

//statements...

and then you don't need to worry about the memory management. That is one of the main purposes of std::vector.

If you want a 3D array, then:

C++

std::vector<std::vector<std::vector<int>>> indexes;

//statements...

problem with delete vector**

3 solutions

Solution 2

Solution 3

Solution 4

Add your solution here

Preview 0

problem with delete vector**

3 solutions

Solution 2

Solution 3

Solution 4

Add your solution here

Preview 0

Existing Members

...or Join us