C# Function return value error

Question

0.00/5 (No votes)

See more:

I have a method in a Windows Form application that I'm making declared as:

C#

public  Color get_color(double str)
  {
      Color clr;
     // int k = 0;
      if (Convert.ToDouble(str) < 25 && Convert.ToDouble(str) > 0)
      {
          // for (int j = 5; j < 11; j++)
          {
              return clr = Color.FromArgb(255, 0, 0);

          }


      }
  }

While building the solution I'm having the error:
Error 3 "menu.Form2.get_color(double)': not all code paths return a value"

can someone please explain what is it that im doing wrong here, It'll be really helpful.

Posted 24-Jan-13 1:43am

suramrit

Add a Solution

3 solutions

Solution 2

In the code you have written, you have returned from within the if condition.

But what if execution fails the if condition. In that case there is no return value.
As a result build fails.

Try putting a return condition for the else part as well.

Posted 24-Jan-13 1:49am

Abhinav S

Comments

suramrit 24-Jan-13 7:52am

Ya, got that... but the problem is now its showing
Error 3 Use of unassigned local variable 'clr'

Solution 3

Add return clr; before you end you method. so that at every case it will return something.

Posted 24-Jan-13 1:58am

siraj hussain

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Vani Kulkarni · Accepted Answer · 2013-01-24T01:44:00

Solution 1

You need to write return code out of if condition.
Try below code:

C#

public  Color get_color(double str)
        {
            Color clr = new Color();
           // int k = 0;
            if (Convert.ToDouble(str) < 25 && Convert.ToDouble(str) > 0)
            {
                // for (int j = 5; j < 11; j++)
                {
                     clr = Color.FromArgb(255, 0, 0);
 
                }

            }
            return clr;
        }

Posted 24-Jan-13 1:44am

Vani Kulkarni

Updated 24-Jan-13 2:03am

v3

Comments

suramrit 24-Jan-13 7:46am

No, Doesnt solve it.

Vani Kulkarni 24-Jan-13 7:48am

Does it give same error?

suramrit 24-Jan-13 7:49am

Ya,perhaps I'm not declaring and returning the Color correctly?

suramrit 24-Jan-13 7:52am

No, Sorry, this time the error is
Use of unassigned local variable 'clr'

Vani Kulkarni 24-Jan-13 7:55am

Try:Color clr = new Color();
Then continue with your if condition.

suramrit 24-Jan-13 7:58am

I've modified it to

public Color get_color(double str)
{
Color clr;
// int k = 0;
if (Convert.ToDouble(str) < 25 && Convert.ToDouble(str) > 0)
{
// for (int j = 5; j < 11; j++)

return clr = Color.FromArgb(255, 0, 0);

}
else return "clr"= Color.FromArgb(255,255,255);
}

but still for the clr in "" it says use of unassigned local variable

Vani Kulkarni 24-Jan-13 8:02am

Updated my answer.

suramrit 24-Jan-13 8:03am

even after making it color clr = new color();
I have the same error

Vani Kulkarni 24-Jan-13 8:03am

I just tried it..works perfect for me. No error at all.

suramrit 24-Jan-13 8:06am

Yes, it does work. Thanks a LOT.. You Rock..