Cross thread operation

Question

3.00/5 (1 vote)

See more:

I am trying to access a combobox created by drop down from the toolbox and then created a new Thread and trying add items in the combobox through the newly created thread and tje error arise like Cross-thread operation not valid: Control 'comboBox1' accessed from a thread other than the thread it was created on.

all the valuable solution will be appreciated

Posted 12-Jul-13 0:47am

rajeeshsays

Add a Solution

Comments

[no name] 12-Jul-13 7:00am

Well the obvious solution is not to try and access controls from the non-UI thread. If you insist that you just have to do it, then use a Dispatcher for WPF or Control.Invoke for Winforms.

rajeeshsays 24-Jul-13 5:30am

Solution 1 is good. I could run my program properly by add this line of code

rajeeshsays 24-Jul-13 5:31am

Thank Mr.Kim Togo

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Kim Togo · Accepted Answer · 2013-07-12T01:01:00

Solution 1

You can only change UI Control elements from the same thread that created them. Usually Main Thread (UI Thread).
If it is WinForm, you have to switch from worker thread to Main Thread via Control.Invoke[^] commands.

You can do something like this:

C#

Invoke(new Action(() => comboBox1.Items.Add("Hello from Thread"));

Posted 12-Jul-13 1:01am

Kim Togo

Comments

rajeeshsays 12-Jul-13 7:45am

private void AddValue()
{
this.Invoke(new Action(() => comboBox1.Items.Add("Hello from Thread")));
//comboBox1.Items.Add("hai");
}

private void Form1_Load(object sender, EventArgs e)
{

MessageBox.Show("Current Thread" + Thread.CurrentThread.Priority);
}

private void button1_Click(object sender, EventArgs e)
{
Second = new Thread(new ThreadStart(this.Invoke(new Action(() => comboBox1.Items.Add("Hello from Thread"))););
Second.Start();

}

rajeeshsays 12-Jul-13 7:46am

this is my code
can you please tell what is wrong with it?

Kim Togo 12-Jul-13 7:59am

Yes I can.

Change:
Second = new Thread(new ThreadStart(this.Invoke(new Action(() => comboBox1.Items.Add("Hello from Thread"))););

To:
Second = new Thread(() => this.Invoke(new Action(() => comboBox1.Items.Add("Hello from Thread"))));

Sushil Mate 12-Jul-13 8:18am

much better than me..my +5,

mine deleted :)

Kim Togo 12-Jul-13 8:23am

Thanks Sushil :-)
But you do not need to delete your solution if it works.