selected city_id is not getting inserted

Question

4.00/5 (1 vote)

See more:

C#

SqlDataAdapter da1 = new SqlDataAdapter("select * from city where state_id='" + ddlstate.SelectedValue + "'", con);
        DataTable dt1 = new DataTable();
        da1.Fill(dt1);
        ddlcity.DataSource = dt1;
        ddlcity.DataTextField = "city_name";
        ddlcity.DataValueField = "city_id";
        ddlcity.DataBind();

above code is to select city for particular state...

and the below code is to insert city_id into the tabel

SQL

cmd.Parameters.AddWithValue("@state_id", ddlstate.SelectedValue);
    cmd.Parameters.AddWithValue("@city_id", ddlcity.SelectedValue);

but when i insert.. city_id is same as state_id
eg. if i select state having id=1, and city_id having id=3 then...
state_id gets inserted as 1 and also city_id as 1...
so plz help me to solve this..

Posted 30-Mar-13 5:48am

Member 9671810

Updated 30-Mar-13 6:37am

Maciej Los

v2

Add a Solution

Comments

Member 9581488 30-Mar-13 11:59am

share your sql insert statement.

Member 9671810 30-Mar-13 12:12pm

insert into registration (firstname,lastname,username,password,state_id,city_id,pincode,mobile_no,phone_no,e_mail,address,security_ques,security_ans,reg_date)
values(@firstname,@lastname,@username,@password,@state_id,@city_id,@pincode,@mobile_no,@phone_no,@e_mail,@address,@security_ques,@security_ans,getdate())

Member 9581488 30-Mar-13 12:18pm

can you use break-point and see what is the value of ddlcity.selectedValue?

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

S. M. Ahasan Habib · Answer 1 · 2013-03-30T06:28:00

Solution 1

Your insert sql code and data binding code is completely alright. What your problem is Your Event handler code. When you change your State you should handle ddlState (state drop down) selected index change event. You should make sure when State is changed then in the same time your above city dropdown list changed code need to fire. When you change your state then debug your code and make sure ddlCity dropdown repoulated and after user selection city and press button then debug and see the ddlCity.SelectedValue and make sure it is showing the last changed value.

Posted 30-Mar-13 6:28am

S. M. Ahasan Habib

Comments

Member 9671810 30-Mar-13 13:58pm

how to do this sir..? i mean i am new, so i need more explanation..

S. M. Ahasan Habib 30-Mar-13 14:13pm

Show you code where you handle selected index change event, where you handle page load event and save event. Need to see where you bind your ddlState dropdown. My guess is when you press save button at the moment ddlState dropdown may be rebind if you not use page.IsPostBack property.

Member 9671810 31-Mar-13 0:48am

i have binded ddlstate in page load..

if (!IsPostBack)
{
{
//state
ddlstate.Items.Insert(0, "select state");
SqlDataAdapter da = new SqlDataAdapter("select * from state", con);
DataTable dt = new DataTable();
da.Fill(dt);
ddlstate.DataSource = dt;
ddlstate.DataTextField = "state_name";
ddlstate.DataValueField = "state_id";
ddlstate.DataBind();
}

and ddlcity in ddlstate's selected index change..

and the i have chkboxes having autopost back on..

and do i have to bind ddlcity also in page load even.. or is it ok to bind in ddlstate's selected index chaged...?

S. M. Ahasan Habib 31-Mar-13 1:39am

You should bind ddlCity in ddlState selected index changed event not page load event. Now from the save button click event you set break point to ddlState.SelectedValue and ddlCity.SelectedValue and see its value as the expected value found there or not.

Member 9671810 · Answer 2 · 2014-05-30T09:45:00

C#

if (cmbstate.SelectedValue.ToString() == null)
            {
                MessageBox.Show("Please select proper state", "ERROR", MessageBoxButtons.OK, MessageBoxIcon.Error);
            }
            else
            {
                int id;
                bool paresOK = Int32.TryParse(cmbstate.SelectedValue.ToString(), out id);
                SqlDataAdapter cityda = new SqlDataAdapter("select * from city where state_id = '" + id + "' ", con);
                DataTable citydt = new DataTable();
                cityda.Fill(citydt);
                cmbcity.Text = "-Select-";
                cmbcity.DataSource = citydt;
                cmbcity.DisplayMember = "city_name";
                cmbcity.ValueMember = "city_id";
            }