|I found this routine sometimes produces incorrect tesselation. When certain points in the polygon winding are colinear, it can skip over them and produce triangles outside of the original polygon.
My fix simply classifies points on the edge of the test triangle as 'inside' instead of 'outside'. This appears to be a stable and beneficial fix so far.
poly normal (0.000f,-0.500f,0.866f)
(0.700f,6.500f,4.071f) // 0
(0.700f,5.500f,3.494f) // 1 This point gets mis-classified with 2,8,9 triangle
(-1.700f,5.500f,3.494f) // 2
(-1.700f,6.500f,4.071f) // 3
(-2.500f,6.500f,4.071f) // 4
(-7.300f,1.700f,1.300f) // 5
(11.300f,1.700f,1.300f) // 6
(7.500f,5.500f,3.494f) // 7
(4.300f,5.500f,3.494f) // 8
(4.300f,6.500f,4.071f) // 9
Old Code in function IsPointInside():
pmq2.Vector(m_e1,ntmp); if( (B0=m_N.Dot(ntmp)) <= 0.0 ) return false;
m_e0.Vector(pmq2,ntmp); if( (B1=m_N.Dot(ntmp)) <= 0.0 ) return false;
return ( (m_A-B0-B1) > 0.0 ? true : false );
pmq2.Vector(m_e1,ntmp); if( (B0=m_N.Dot(ntmp)) < 0.0 ) return false;
m_e0.Vector(pmq2,ntmp); if( (B1=m_N.Dot(ntmp)) < 0.0 ) return false;
return ( (m_A-B0-B1) < 0.0 ? false : true);
Helpful explaination of internal variables:
//(I replaced spaces with dots as they were not preserved in post?)
// I,J,K (points of current test triangle, indices or indirect indices)
// e0,e1 (edges from IK, JK)
// A (Area of current triangle, is actually area*2)
// N (Normal of current triangle, not unit length)
// p Test point if in current triangle.
Further testing shows that neither the old or new code correctly and consistently handles coincident and colinear points. (Eg. An example of a coincident point, is a Figure '8' polygons that does not actually cross over, just converges in the middle.)
// Eg. Coincident point, figure 8 style
poly normal (0.000f,-0.500f,0.866f)
This should help more with coincident points:
Old code in IsAnyPointInside():
if( ( ip < i || ip > k ) &&
if( ip < i || ip > k )
// NOTE: This is Vector3 exact equality test
continue; // Identical points are not inside, they do not hurt turns
if( IsPointInside(points[m_nIndex[ip]],points[ik]) )
If topus's suggested change is valid, it should read
// j is alligned from i to k ?
if( ((-FLT_EPSILON) < m_A && m_A < FLT_EPSILON) || // Area OR Poor Normal
((-FLT_EPSILON) < m_N && m_N < FLT_EPSILON &&
(-FLT_EPSILON) < m_N && m_N < FLT_EPSILON &&
(-FLT_EPSILON) < m_N && m_N < FLT_EPSILON ))
// NOTE: This code is more efficient on PC with eg. 'fabsf(m_A) <= FLT_EPSILON' to reduce float compares.
Also note that you can help the algorithm by removing 'junk' before processing. Eg. project 3D points onto plane (of which normal is used). Remove degeneracies like coincident and colinear points. Snapping and merging points may help, but could lead to bad-snaps that cause self intersections.
I have found another case which I believe shows a flaw in the algorithm. As 'ears' are clipped off the polygon, the remaining polygon can become self intersecting and fail 'point in poly' test, to produce triangles outside the original shape.
in function Triangulate()
in 'case convex :'
in else, after 'RemoveVertex'
// Advance to preserve poly integrity
i = j;
j = k;
This allows the point AFTER the removed triangle point to be the start of the next test triangle. This helps with near colinear points that fan out from an otherwise stationary start point.
There are still issues with the code. The bottom line is that the original algorithm does not handle simple non-covex polys with colinear, but non intersecting segments. The overall algorithm does not handle polygons that intersect in anyway, including at single points, though it often produces a correct or near correct result.
Please comment on this.