Click here to Skip to main content
Click here to Skip to main content

Generic repositories – A silly abstraction layer

, 22 Feb 2012
Rate this:
Please Sign up or sign in to vote.
Let’s look at what generic repositories give you.

Update: The post is all about GENERIC repositories as in Repository<T>, not about all types of repositories. Repositories are a great way to abstract away the data source and make your code testable and flexible. Read the comment by Joseph Webster, CISSP to find out more.

My recommendation is against generic repositories since they don't give you any additional value compared to regular repository classes which have been written specifically for the requirements that your project have.

Let’s look at what generic repositories give you:

You can change OR/M implementation at any time.

Seriously?

  1. If you find yourself having switch OR/M during a project you have not done you homework before you started the project.
  2. The OR/M choice doesn’t matter since you have abstracted away the features of the chosen OR/M

imho you’ll stick with one OR/M during a project and switch for the next one (if you have to switch).

You have to write less code.

Here is a Generic repository (NHibernate implementation) from a SO question:

public interface IRepository<T> : IQueryable<T>
{
  void Add(T entity);
  T Get(Guid id);
  void Remove(T entity);
}

public class Repository<T> : IQueryable<T>
{
  private readonly ISession session;

  public Repository(ISession session)
  {
    session = session;
  }

  public Type ElementType
  {
    get { return session.Query<T>().ElementType; }
  }

  public Expression Expression
  {
    get { return session.Query<T>().Expression; }
  }

  public IQueryProvider Provider
  {
    get { return session.Query<T>().Provider; }
  }  

  public void Add(T entity)
  {
    session.Save(entity);
  }

  public T Get(Guid id)
  {
    return session.Get<T>(id);
  }

  IEnumerator IEnumerable.GetEnumerator()
  {
    return this.GetEnumerator();
  }

  public IEnumerator<T> GetEnumerator()
  {
    return session.Query<T>().GetEnumerator();
  }

  public void Remove(T entity)
  {
    session.Delete(entity);
  }
}

Take a look at the methods. All they do is to call methods in NHibernate. You do not win anything by doing so. All you get is an abstraction layer that removes the good things with nhibernate/ef/whatever.

It’s better to create a proper base class and move all repeated (DRY) functionality into it (and therefore still be able to take advantage of the features in your favorite OR/M).

Summary

Did I miss something that a generic repository gives you? Please make a comment.

License

This article, along with any associated source code and files, is licensed under The GNU Lesser General Public License (LGPLv3)

About the Author

jgauffin
Founder Gauffin Interactive AB
Sweden Sweden
Founder of OneTrueError, a .NET service which captures, analyzes and provide possible solutions for exceptions.
 
blog | twitter
Follow on   Twitter   LinkedIn

Comments and Discussions

 
QuestionDon't repeat yourself. Don't repeat yourself. PinmemberAn00bus23-Jan-13 4:44 
GeneralMy vote of 3 Pinmemberjim lahey24-Feb-12 4:29 
GeneralRe: My vote of 3 Pinmemberjgauffin25-Feb-12 20:44 
GeneralMy vote of 5 PinmemberPaul Tait22-Feb-12 18:27 
AnswerWhat about when you are not using (only) an ORM? PinmemberJoseph Webster, CISSP22-Feb-12 10:33 
GeneralRe: What about when you are not using (only) an ORM? Pinmemberjgauffin22-Feb-12 18:44 
GeneralMy vote of 5 Pinmember_FleX22-Feb-12 8:59 
GeneralMy vote of 1 PinmemberDean Oliver22-Feb-12 8:40 
GeneralRe: My vote of 1 Pinmemberjgauffin22-Feb-12 18:41 

General General    News News    Suggestion Suggestion    Question Question    Bug Bug    Answer Answer    Joke Joke    Rant Rant    Admin Admin   

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.

| Advertise | Privacy | Mobile
Web03 | 2.8.140709.1 | Last Updated 23 Feb 2012
Article Copyright 2012 by jgauffin
Everything else Copyright © CodeProject, 1999-2014
Terms of Service
Layout: fixed | fluid