Click here to Skip to main content
Click here to Skip to main content

CEditLog - fast logging into an edit control with cout

By , 1 Nov 2003
 

Problem

I once wanted to use an edit control for fast, asynchronous text output. I need to log messages from a lot of threads, sometimes more than 1000 per second. And since I created already functions to dump my objects to std::cout I also wanted to use an edit control as std::ostream.

Features

  • Asynchronous, very fast output to any edit control
  • User can scroll back, select and copy text and so on during output
  • Can be used with or without MFC (Sample is a MFC project)
  • Uses window-subclassing, so you can use it even with CEdit-derived controls
  • Save to be used by multiple threads
  • Special basic_streambuf class to create or redirect a std::ostream (such as std::cout) to an edit control

Using CEditLog

Just create an Instance of CEditLog and attach an edit control to it using the SetEditControl() function. Then you can add text to the end of the edit control using one of the AddText() members:

class CEditLog : protected CSubclassWnd
{
public:
    typedef CSubclassWnd root_type;

    // Constructs the CEditLog. You can pass the edit controls handle

    // here or set it later using the SetEditCtrl() function.

    // To increase performance CEditLog repaints the edit-control

    // only if the caret resides in the last line. Otherwise the

    // control will be refreshed only every nMaxRefreshDelay msec.

    CEditLog( HWND hEdit = NULL, UINT nMaxRefreshDelay = 500 );
    
    // Adds some text to the end of the edit control. Works asynchronously

    // (using PostMessage()) and is save to be called by multiple threads.

    // If you pass true for bLFtoCRLF every LF (ASCII 10) (as it is used in

    // most cases for end-of-line) will be converted to a CR/LF (ASCII 10/13)

    // sequence as it is needed by the windows edit control. 

    virtual void AddText( LPCWSTR pwszAdd, bool bLFtoCRLF = false );
    
    // Converts pszAdd to UNICODE and calls the above

    void AddText( LPCSTR pszAdd, bool bLFtoCRLF = false );

    // Sets the edit-control to be used for logging.

    // Pass NULL to stop text logging.

    virtual void SetEditCtrl( HWND hEdit );

    HWND GetEditCtrl() const

    ...
};

The sample project

The included sample project shows the usage of CEditLog and how to use basic_editstrbuf to redirect std::cout to use the edit log.

CEditLog uses the CSubclassWnd class, written by William E. Kempf for implementation. I have included the soure of CSubclassWnd in the sample project, the complete article is also available here at CodeProject.

History

Version Comments
1.0 First Release
1.1 Minor Revision. Now uses V2.0 of SubclassWindow.
Now really works on Win9x (V1.0 used UNICODE for internal data handling and failed on Win9x systems. Now the code checks if it runs on Win9x and does the required conversions.)
1.2 Minor Revision. Now compiles fine even in VC.NET 2003.

License

This article, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

About the Author

Daniel Lohmann

Germany Germany
Daniel Lohmann (daniel@losoft.de) is Assistant Professor at the Distributed Systems and Operating Systems department at Friedrich-Alexander-University Erlangen-Nuremberg, Germany. His main research topic is the design of a highly customizable and scalable operating system product line for deeply embedded systems using static configuration and aspect-oriented techniques. Before joining Universität Erlangen he worked as a freelance trainer and consultant for NT system programming, advanced C++ programming and OOA/OOD. He is interested in upcoming programming techniques like aspect-oriented programming, generative programming and C++ meta coding and has written some nice and handy tools for Windows NT which you can download at his web site.

Sign Up to vote   Poor Excellent
Add a reason or comment to your vote: x
Votes of 3 or less require a comment

Comments and Discussions

 
You must Sign In to use this message board.
Search this forum  
    Spacing  Noise  Layout  Per page   
GeneralPassed on compiling, but failed on running on Windows VistamemberGolden Lee3-Dec-09 19:25 
Dear Mr. Daniel Lohmann,
How are you? Thank you for your fast logging edit control.
 
CLogEdit control works (compile, link and execute by using VS 2008) like a charm on Windows XP operating system. On Windows Vista, CLogEdit control can pass compiling and linking, but con't run anymore. I trace from the application entry point step by step, and finally find an error in the statement ::SendMessage( hEdit, EM_LIMITTEXT, 0, 0 );
of the following routine:
 
void CEditLog::SetEditCtrl(
HWND hEdit
)
{
if( hEdit != GetHandle() && GetHandle() != NULL )
UnsubclassWindow();

if( SubclassWindow( hEdit ) ) {
// We want to support a lot of text...
// Note that Win9x supports no more than 64kb of text! - just too bad...
// Tip: Use NT/2k Smile | :)
::SendMessage( hEdit, EM_LIMITTEXT, 0, 0 );
}
}
 
When single-steped into the statement ::SendMessage( hEdit, EM_LIMITTEXT, 0, 0 ); an error message box was throwed, and said "Unhandled exception at 0x03613d1c in GVIPS.exe: 0x0000005; Access violation."
 
Could you help me to figure out this error. Thank you!
GeneralRe: Passed on compiling, but failed on running on Windows VistamemberDaniel Lohmann7-Dec-09 0:37 
Hi,
 
I am sorry, but my current work load does not leave me any time to look into this; moreover, I do not have a Vista box D'Oh! | :doh:
 
I assume, however, that the problem lies somewhere in the CSublassWindow-Code and the way it creates the Thunk-Code in a member variable. Probably Vista marks all data segments with the "no-exec" Flag supported by newer IA32/64 CPUs, which results in the Access Violation.
 
Maybe there is a newer Version of CSubclassWindow available somehwere (I found the original one here on CodeProject, but apparently it disappeared). Otherwise, someone has to rewrite the code so that the memory for the Tunk data structure is allocated from an executable memory region (VirtuallAlloc()). Another, simpler approach might be to use VirtualProtect() to set the "X"-flag on the memory region the Thunk member variables belong to.
 
--
 
Daniel Lohmann
 
http://www.losoft.de
(Hey, this page is worth looking! You can find some free and handy NT tools there Big Grin | :-D )

AnswerRe: Passed on compiling, but failed on running on Windows Vistamemberysliou19-May-11 3:53 
I have the same problem run on Windows 7. After setting the project property "Data Execution Prevention (DEP)" to off, the problem disapperred. Project property > Linker > Advanced > Data Execution Prevention (DEP) > Default or (/NXCOMPAT:NO). You can try it.
Y.S. Liou

GeneralRe: Passed on compiling, but failed on running on Windows Vistamember Randor 7-Jul-12 13:50 
Hi,
 
I took a look at the source code and found the problem. The CSubclassWnd class was written way back around 2000+/- by William E. Kempf. Back then processors did not have the NX bit and you could execute code located at arbitrary memory addresses with no problems. Today on more modern hardware/operating systems you will of course receive a DEP error.
 
In the file SubclassWnd.h find the the code block:
 
#if defined (_M_IX86)
	thunk.m_mov = 0x042444C7;  //C7 44 24 0C
	thunk.m_this = (DWORD)pThis;
	thunk.m_jmp = 0xe9;
	thunk.m_relproc = (int)proc - ((int)this+sizeof(Thunk));
#elif defined (_M_ALPHA)
 
Then change the memory protection on the thunk so it is executable:
 
#if defined (_M_IX86)
	thunk.m_mov = 0x042444C7;  //C7 44 24 0C
	thunk.m_this = (DWORD)pThis;
	thunk.m_jmp = 0xe9;
	thunk.m_relproc = (int)proc - ((int)this+sizeof(Thunk));
	DWORD dwOldProtection;
	VirtualProtect(&thunk,sizeof(Thunk),PAGE_EXECUTE_READWRITE,&dwOldProtection);
#elif defined (_M_ALPHA)
 
Best Wishes,
-David Delaune
GeneralRe: Passed on compiling, but failed on running on Windows VistamemberWalter Schmoll19-Sep-12 22:40 
The suggested solution might be a problem as, according to MSDN, one should avoid using VirtualProtect on memory that wasn't allocated with VirtualAlloc[Ex]. VirtualProtect changes the access rights on a complete memory page. If "thunk" crosses page boundaries, it even changes the rights of two pages, but that's just details. It's not done here, but if you remove read/write access from a page within the heap, you're in really big problems.
 
I came up with a similar solution, which is a little bit more complicated (and hopefully better Smile | :) ). For Details see my message "Fix to run with Data Execution Prevention" in the article "Pluggable Event Handler"
Pluggable Event Handler[^].
GeneralRe: Passed on compiling, but failed on running on Windows Vistamember Randor 17-Oct-12 14:09 
Hi Walter,
 
I have not looked at your modifications but I am sure that you have done an outstanding and thorough job. I was contacted by a former co-worker to have a look at this project and tell him why it was crashing. I think I spent a total of 5 minutes looking at the code. Thanks for the improved solution.
 
Best Wishes,
-David Delaune

General General    News News    Suggestion Suggestion    Question Question    Bug Bug    Answer Answer    Joke Joke    Rant Rant    Admin Admin   

Permalink | Advertise | Privacy | Mobile
Web01 | 2.6.130617.1 | Last Updated 2 Nov 2003
Article Copyright 2000 by Daniel Lohmann
Everything else Copyright © CodeProject, 1999-2013
Terms of Use
Layout: fixed | fluid