FooButton

Re: Double click - not giving a second click.

6:18 12 Jan '10

Let me eat that message and spit out another one. I love it! /ravi My new year resolution: 2048 x 1536 Home \| Articles \| My .NET bits \| Freeware ravib(at)ravib(dot)com
Sign In·View Thread·Permalink

Phil Outram

6:21 12 Jan '10

Sorry, also meant to thank you Ravi for absolutely rock-solid and extremely versatile buttons that are proving extremely useful. Many thanks, Phil.
Sign In·View Thread·Permalink

Use with Common Dialogs

daxack

1:35 25 Apr '09

Has anyone used FooButton with a Windows Common dialog? I am using bitmaps on my own dialogs, but would like the buttons on CFileDialog to have bitmaps as well. I thought it should be a simple matter of doing the following:

1) In the declaration for my derrived dialog class (class CLocalFileDlg : public CFileDialog), I have the following:

FooButton OpenButton,
CancelButton;

2) In DoDataExchange() I have:

DDX_Control(pDX, IDOK, OpenButton);
DDX_Control(pDX, IDCANCEL, CancelButton);

3) In OnInitDialog() I have:

OpenButton.setBitmapId( IDB_CHECK );
CancelButton.setBitmapId( IDB_EX );

The error I am getting appears to be a result of IDOK and IDCANCEL not being valid resource IDs in the dialog, even though Microsoft's documentation indicates they are. I tried using GetDlgItem() on both these IDs and both return NULL.

Anyone have an idea of what I am missing?

Why GROUPBOX Appears to be round?

librorum

15:25 19 Feb '09

This control really is cool! by the way, I can't find the way why the GROUPBOX(IDC_STATIC) appears to be rounded. Is there any related codes?
Sign In·View Thread·Permalink

Re: Why GROUPBOX Appears to be round?

Can't get CFont object from the button's GetFont() [modified]

15:31 19 Feb '09

Thanks! librorum wrote: I can't find the way why the GROUPBOX(IDC_STATIC) appears to be rounded. You need to add a manifest resource to the project in order to get the XP look and feel. /ravi My new year resolution: 2048 x 1536 Home \| Articles \| My .NET bits \| Freeware ravib(at)ravib(dot)com
Sign In·View Thread·Permalink

guocang

7:26 2 Dec '08

I created some FooButton objects dynamically and set the type to hyperlink. The FooButton::drawCaption rountine failed as GetFont() returns NULL. When I create a font and set the underline text, the control (inside of CListCtrl) is not clickable. Any help is appreciated. Thanks. modified on Tuesday, December 2, 2008 1:54 PM
Sign In·View Thread·Permalink

Re: Can't get CFont object from the button's GetFont()

Gradient suggest when disable button

1:30 18 Dec '08

Sorry for the late reply! Did you associate the `FooButton` instance with a Windows button control? /ravi My new year resolution: 2048 x 1536 Home \| Articles \| My .NET bits \| Freeware ravib(at)ravib(dot)com
Sign In·View Thread·Permalink

chogeha

23:52 26 Jun '08

I have little problem about the gradient feature.
If the button enable gradient and atteched bitmap.
When the button change to disable, the bitmap will show
the transparent area. So, I have add some code like below.

In the void FooButton::DisabledBlt() function

if(!m_bGradient)
{
FillRect (hdcDest,
CRect (nXDest, nYDest, nXDest + nWidth, nYDest + nHeight),
GetSysColorBrush (COLOR_3DFACE));
}

HBRUSH hb;

if(!m_bGradient)
hb = CreateSolidBrush (GetSysColor (COLOR_3DHILIGHT));
else
hb = CreateSolidBrush (RGB(200,200,200));

if(!m_bGradient)
{
BitBlt (hdcDest, nXDest, nYDest, nWidth, nHeight, bwDC, 0, 0, 0xB8074A);
}
The button will better then before when it's disable.

BTW, this class is really good.
Thanks

Enjoy!

Re: Gradient suggest when disable button

Missing update when changing text

3:56 27 Jun '08

Thanks for the fix! /ravi My new year resolution: 2048 x 1536 Home \| Articles \| My .NET bits \| Freeware ravib(at)ravib(dot)com
Sign In·View Thread·Permalink

K.Stein

21:47 17 Oct '07

Hi,
Thanks for this great class!
I enjoy to use it in my app.

I have found a little problem:
The text is not updated correctly when it is changed.
This happens when using the button with the style hyperlink or as hottrack and in combination with a menu. I change the text of the button according to the choice in the menu (comparable to a dropdown list).
It works fine as long as I use the mouse to select the menu item. If I use the keyboard to open the menu and to select the item the button shows the old and the new text on top of each other.
I could solve the problem by calling Invalidate() before setting the new text:

         if( !cstrText.IsEmpty() )
         {
            // necessary to delete old text when selecting menu entry by keyboard
            pBtn->Invalidate();
            pBtn->SetWindowText( cstrText );
         }

I think it would be better to modifiy the button text by a member function which cares for the necessary update.

Re: Missing update when changing text

2:42 18 Oct '07

Hi Klaus, thanks for your comments! I'll look into it asap. /ravi This is your brain on Celcius Home \| Music \| Articles \| Freeware \| Trips ravib(at)ravib(dot)com
Sign In·View Thread·Permalink

XP Themes

Tim Cook

3:15 14 Jun '07

I saw in a previous post that someone else asked about XP Theme support and you agreed. Is this something to difficult to add or is this something you are looking into. Great control, it just looks funny in my application when XP Themes are used. This control sticks out. Thanks so much, Tim.
Sign In·View Thread·Permalink	1.00/5 (1 vote)

7:27 14 Jun '07

Hi Tim, thanks for your post. I've been meaning to add support for themes but continue to buried under work. Hopefully I'll have some free cycles before long and eventually be able to get to this. Thanks, /ravi This is your brain on Celcius Home \| Music \| Articles \| Freeware \| Trips ravib(at)ravib(dot)com
Sign In·View Thread·Permalink	2.00/5 (1 vote)

4:21 26 Mar '10

I have put together an XP-themed demo using some code cannibalised from XPButtonST and modified by myself, plus some other stuff from CodeProject. I've tried it with about ten different themes and it seems to work nicely.

I can send you the modified code if you like.

- Pfft. Coddled kids. In my day, we used to telnet to port 80, then render the page with pencil and paper-- and that's the way we liked it!
- Pshaw! Youngster. Your UID barely fits inside 16 bits. In _my_ day we had to whistle the 1's and 0's through an acoustic coupler!

Tools that support "all of UTF-8 as long as it starts with ASCII" and tools that cannot handle these three [BOM] bytes at all are not really supporting UTF-8.
- Michael Kaplan

Jacob Skjoet

22:48 9 Jun '11

Dear David I'd very much to see your modified code as it seems that it has not made it into an update of this great control Jacob Skjøt
Sign In·View Thread·Permalink

1:51 10 Jun '11

Guilty as charged. Hoping I eventually get the time to update the article. /ravi My new year resolution: 2048 x 1536 Home \| Articles \| My .NET bits \| Freeware ravib(at)ravib(dot)com
Sign In·View Thread·Permalink

Jacob Skjoet

2:12 10 Jun '11

Dear Ravi

Good to see that you're still around monitoring comments on this versatile control.

We've just spent some time updating our app to support XP look (we're at the forefront of things here Wink | ;)

) by trying to figure out how to embed a manifest through a makefile.
Now that it works the FooButtons are visually sticking out a little.

Did you receive a draft from David or do you have a pointer on howto...

Any help much appreciated.

Jacob Skjøt

2:22 10 Jun '11

Hi Jacob,

I haven't recd. anything from David, but that's because I haven't had the chance to respond to his offer. I use FooButton in this[^] MFC app and enabled support for theming by using a manifest. Unfortunately I haven't done any MFC development for more than half a dozen years (currently work in C#/.NET and Android).

/ravi

My new year resolution: 2048 x 1536
Home | Articles | My .NET bits | Freeware
ravib(at)ravib(dot)com

2:25 10 Jun '11

Jacob Skjoet wrote: trying to figure out how to embed a manifest through a makefile. See this[^] CP article. /ravi My new year resolution: 2048 x 1536 Home \| Articles \| My .NET bits \| Freeware ravib(at)ravib(dot)com
Sign In·View Thread·Permalink

4:53 25 Jul '11

I'm recovering from tennis elbow (should that be mouse elbow??) right now, so I haven't been too attentive to messages and such. Nevertheless, if I can just recall what this is all about(!), I'll take a look at my code tomorrow.

5:05 25 Jul '11

Hope you feel better soon! /ravi My new year resolution: 2048 x 1536 Home \| Articles \| My .NET bits \| Freeware ravib(at)ravib(dot)com
Sign In·View Thread·Permalink

5:56 2 Aug '11

Thanks! Feeling better already.

OK, here we go. Deep breath because I'm going to post a fair bit of code. First, in this post, the modifications to FooButton itself. Then I'll post the other code that I've made it depend on.

Wherever I've modified a function, I've posted the whole function. My change is marked by "DP".

 
class FooButton : public CButton
{
  
  //! Sets the button's bitmap id.
  //! @param  nBitmapId       Bitmap id (-1 means none).
  //! @param  rgbTransparent  Bitmap's transparency color (default = RGB(255,0,255)
  void setBitmapId
    (int nBitmapId,
     COLORREF rgbTransparent = RGB (255, 0, 255), 
	  HINSTANCE hInstBitmapResHandle=NULL /*DP 26/03/2010: instance handle for loading bitmap*/);
 
protected:
	// DP 05/04/2010: Moved this out of OnMouseMove to allow re-start of tracking when bad MOUSELEAVE received
	void StartMouseTracking();
 
	// DP 26/03/2010: instance handle for loading bitmap
  HINSTANCE m_hInstBitmapResHandle;
}
 
----------------------------------------------------------------------------------------
 
// DP: Use Visual Styles singleton
#include "..\XPThemeSupport\VisualStylesXP.h"
#include "..\ButtonST\XPStyleButtonST.h"

//! Sets the button's bitmap id.
//! @param  nBitmapId       Bitmap id (-1 means none).
//! @param  rgbTransparent  Bitmap's transparency color (default = RGB(255,0,255)
void FooButton::setBitmapId
  (int nBitmapId,
   COLORREF rgbTransparent, 
	HINSTANCE hInstBitmapResHandle /*DP 26/03/2010: instance handle for loading bitmap*/)
{
  m_nBitmapId = nBitmapId;
  // DP 26/03/2010: instance handle for loading bitmap
  m_hInstBitmapResHandle = hInstBitmapResHandle;
  m_rgbTransparent = rgbTransparent;
  HWND hWnd = GetSafeHwnd();
  if ((hWnd != NULL) && ::IsWindow (hWnd))
     Invalidate();
}
void FooButton::OnMouseMove(UINT nFlags, CPoint point) 
{
  // Start tracking the mouse if we're a hot button
  if (m_bHot && !m_bTracking) {
//		  TRACKMOUSEEVENT tme;
//		  tme.cbSize = sizeof(tme);
//		  tme.hwndTrack = m_hWnd;
//		  tme.dwFlags = TME_LEAVE;
//		  tme.dwHoverTime = HOVER_DEFAULT;
//		  m_bTracking = _TrackMouseEvent(&tme);
		// DP 05/04/2010: Moved this out of OnMouseMove to allow re-start of tracking when bad MOUSELEAVE received
	  StartMouseTracking();
      HWND hWnd = GetSafeHwnd();
      if ((hWnd != NULL) && ::IsWindow (hWnd))
         Invalidate();
  }
  // Do default action
	CButton::OnMouseMove(nFlags, point);
}
// DP 05/04/2010: Moved this out of OnMouseMove to allow re-start of tracking when bad MOUSELEAVE received
void FooButton::StartMouseTracking()
{
  TRACKMOUSEEVENT tme;
  tme.cbSize = sizeof(tme);
  tme.hwndTrack = m_hWnd;
  tme.dwFlags = TME_LEAVE;
  tme.dwHoverTime = HOVER_DEFAULT;
  m_bTracking = _TrackMouseEvent(&tme);
}
LRESULT FooButton::OnMouseLeave
  (WPARAM wParam,
   LPARAM lParam)
{
  // To ignore "unreferenced formal parameter" warning
  wParam = wParam;
  lParam = lParam;
	// DP 05/04/2010: re-start tracking if false MOUSELEAVE message received
  // Check if mouse cursor has really left the button, or if this is a false MOUSELEAVE
  // See: http://www.codeproject.com/Messages/268824/WM_MOUSELEAVE-madness.aspx
	CPoint p; 
	CRect	rectButton;
	
	::GetCursorPos(&p); 
	ScreenToClient(&p);
	GetClientRect(&rectButton);
	// DP 06/04/2010: check if we're REALLY out of the button. If not, restart the tracking. But don't do this if we've clicked on the menu
	// drop-down, because then we need tracking to stop to allow the menu to paint properly
	if (rectButton.PtInRect(p) && !m_bMultiClicked)
	{
	  StartMouseTracking();
	}
	else
	{
		m_bTracking = false;
		TRACE0("Multiclicked to false FooButton::OnMouseLeave\n");
		m_bMultiClicked = false;
	  HWND hWnd = GetSafeHwnd();
	  if ((hWnd != NULL) && ::IsWindow (hWnd))
		  Invalidate();
	}
	return 0;
}
void FooButton::DrawItem (LPDRAWITEMSTRUCT lpDrawItemStruct) 
{
  CDC* pDC = CDC::FromHandle (lpDrawItemStruct->hDC);
  ASSERT (pDC != NULL);
  // Draw frame for non-radio and non-checkbox buttons
  if ((m_type != FooButton::checkBox) && (m_type != FooButton::radio))
     drawFrame (pDC, lpDrawItemStruct);
  // Draw button bitmap
  int nBmpRightEdge = 0;
  drawBitmap (pDC, lpDrawItemStruct, nBmpRightEdge);
  // Draw frame for radio and checkbox buttons
  if ((m_type == FooButton::checkBox) || (m_type == FooButton::radio))
     drawRadioCheckFrame (pDC, lpDrawItemStruct, nBmpRightEdge);
  // Draw drop-down indicator
  drawDropDown (pDC, lpDrawItemStruct);
  // Draw caption
  int nCaptionRightEdge = 0;
  drawCaption (pDC, lpDrawItemStruct, nBmpRightEdge, nCaptionRightEdge);
  // Draw focus rectangle
  drawFocus (pDC, lpDrawItemStruct, nBmpRightEdge, nCaptionRightEdge);
  // Draw default button border
  // DP 26/03/2010: only if not using themes (otherwise themes take care of it)
  if (!CVisualStylesXP::GetInstance()->IsAppUsingThemes())
  {
	drawDefaultBorder (pDC, lpDrawItemStruct);
  }
  return;
}
//! Draws the button's frame
void FooButton::drawFrame
  (CDC* pDC,
   LPDRAWITEMSTRUCT lpDrawItemStruct)
{
	CRect * pRect = (CRect*)(&(lpDrawItemStruct->rcItem));
	// DP 26/03/2010: draw XP background/border if possible
	if (DrawXPButtonBackground(GetSafeHwnd(), pDC, pRect, m_bDefaultButton, false, ((GetStyle() & WS_BORDER) == WS_BORDER), 
		m_bHot && !m_bChecked && m_bTracking, // mouse over?
		(((lpDrawItemStruct->itemState & ODS_SELECTED) == ODS_SELECTED) && !m_bMulti) || m_bChecked, // Pushed?
		(((lpDrawItemStruct->itemState & ODS_DISABLED) == ODS_DISABLED) || m_bChecked)) == -1)
	{
		  ASSERT (pDC != NULL);
		  ASSERT (lpDrawItemStruct != NULL);
		  // Draw button outline if we're not a static button or a hyperlink
		  if (!m_bStatic && !m_bHyperlink) {
				if (m_bHot && !m_bChecked)
					 drawHotButtonFrame (lpDrawItemStruct);
				else {
					 // Draw frame for non-hot button
					 UINT uFrameCtrl = DFCS_BUTTONPUSH;
					 if (m_bChecked)
						 uFrameCtrl |= DFCS_CHECKED;
					 else
						 if (((lpDrawItemStruct->itemState & ODS_SELECTED) == ODS_SELECTED) && !m_bMulti)
							 uFrameCtrl |= DFCS_PUSHED;
					 if ((lpDrawItemStruct->itemState & ODS_DISABLED) == ODS_DISABLED)
						 uFrameCtrl |= DFCS_INACTIVE;
					 pDC->DrawFrameControl (&(lpDrawItemStruct->rcItem), DFC_BUTTON , uFrameCtrl);
					 // Fill frame with gradient background, if required
					 if (isGradient()) {
						  CRect rect = lpDrawItemStruct->rcItem;
						  rect.left++;
						  rect.top++;
						  rect.right -= 2;
						  rect.bottom -= 2;
						  COLORREF rgbTop = (m_bTracking ? m_rgbTopGradientHot : m_rgbTopGradient);
						  COLORREF rgbBottom = (m_bTracking ? m_rgbBottomGradientHot : m_rgbBottomGradient);
						  drawGradientRect (pDC, rect, rgbTop, rgbBottom, true);
					 }
					 // For multi pushbuttons, fill the area of the drop-down indicator with
					 // a light color if the multi button is currently pressed
					 if (m_bMulti && m_bMultiClicked)
						 drawMultiDropDownRegion (pDC, lpDrawItemStruct);
				}
		  }
	}
}
//! Draws the button's bitmap
void FooButton::drawBitmap
  (CDC* pDC,
   LPDRAWITEMSTRUCT lpDrawItemStruct,
   int& nBitmapRightEdge)
{
  ASSERT (pDC != NULL);
  ASSERT (lpDrawItemStruct != NULL);
  // Load bitmap - return if unable
  nBitmapRightEdge = 0;
  if (m_nBitmapId == 0)
     return;
//  HBITMAP hBitmap = ::LoadBitmap (AfxGetResourceHandle(), MAKEINTRESOURCE (m_nBitmapId));
  // DP 05/04/2010: Load bitmap properly from specified res handle
  HBITMAP hBitmap = ::LoadBitmap (m_hInstBitmapResHandle, MAKEINTRESOURCE (m_nBitmapId));
  ASSERT (hBitmap != NULL);
  if (hBitmap == NULL)
     return;
  // Get bitmap dimensions
  BITMAP  rBitmap;
  ::GetObject (hBitmap, sizeof (BITMAP), &rBitmap);
  CSize bitmapSize;
  bitmapSize.cx = rBitmap.bmWidth;
  bitmapSize.cy = rBitmap.bmHeight;
  // Position the bitmap - if the button contains no text or is a checkbox/radio,
  // leave C_BitmapBorder_X pixels from the L edge.  Otherwise, center it horizontally.
  CRect rectButton;
  GetClientRect (&rectButton);
  CPoint pt;
  if (m_bText || (m_type == FooButton::checkBox) || (m_type == FooButton::radio))
     pt.x = rectButton.left + C_BitmapBorder_X;
  else
     pt.x = (rectButton.right - rBitmap.bmWidth) / 2;
  pt.y = (rectButton.bottom - rBitmap.bmHeight) / 2;
  if ((m_type != FooButton::checkBox) && (m_type != FooButton::radio))
     if (!m_bStatic && !m_bHyperlink && !m_bMultiClicked)
        if (lpDrawItemStruct->itemState & ODS_SELECTED)
           pt.Offset (1, 1);
  // Draw the bitmap
  if ((lpDrawItemStruct->itemState & ODS_DISABLED) == ODS_DISABLED)
      DisabledBlt (pDC->m_hDC,
                   pt.x, pt.y,
                   rBitmap.bmWidth, rBitmap.bmHeight,
                   hBitmap,
                   0, 0);
  else
      TransparentBlt (pDC->m_hDC,
                      pt.x, pt.y,
                      rBitmap.bmWidth, rBitmap.bmHeight,
                      hBitmap,
                      0, 0,
                      m_rgbTransparent,
                      NULL);
  // Return right edge of bitmap
  nBitmapRightEdge = pt.x + rBitmap.bmWidth;
  // Free bitmap
  ::DeleteObject (hBitmap);
}

Re: XP Themes [modified]