Coding Horrors

FUNCTION verify_location()


	DECLARE c_det_cur CURSOR FOR 
		SELECT frerc.from_loc_id, frerc.to_loc_id
		FROM frerc
			WHERE frerc.dc_id = m_i_frerc_rec.dc_id
			  AND frerc.whse_id = m_i_frerc_rec.whse_id
	
	# check if select worked correctly
	IF SQLCA.SQLCODE <> 0
	THEN
		#...
		RETURN TRUE, 0
	END IF

	OPEN c_det_cur 
	IF SQLCA.SQLCODE <> 0
	THEN
		#...
		RETURN TRUE, 0
	END IF

	FETCH c_det_cur INTO m_from_loc, m_to_loc

	IF m_modify = 0 AND m_i_frerc_rec.from_loc_id >= m_from_loc
		AND m_i_frerc_rec.from_loc_id <= m_to_loc 
	THEN
		CALL sh_err_msg("S2096")
		LET m_from = 1
		LET m_modify = 1
	END IF
	
	IF m_modify = 0 AND m_i_frerc_rec.to_loc_id >= m_from_loc
		AND m_i_frerc_rec.to_loc_id <= m_to_loc 
	THEN
		CALL sh_err_msg("S2097")
		LET m_from = 1
		LET m_modify = 1
	END IF
	
	IF m_from_loc >= m_i_frerc_rec.from_loc_id
		AND m_from_loc <= m_i_frerc_rec.to_loc_id
	THEN
		CALL sh_err_msg("S2097")
		LET m_from = 1
		LET m_modify = 1
	END IF
	
	IF m_modify = 0 AND m_to_loc >= m_i_frerc_rec.from_loc_id
		AND m_to_loc <= m_i_frerc_rec.to_loc_id
	THEN
		CALL sh_err_msg("S2096")
		LET m_to = 1
	END IF 	

	IF m_to = 0 AND 
		m_from = 0
	THEN
		WHILE SQLCA.SQLCODE = 0
			FETCH c_det_cur INTO m_from_loc, m_to_loc

			IF m_i_frerc_rec.from_loc_id >= m_from_loc
				AND m_i_frerc_rec.from_loc_id <= m_to_loc 
			THEN
				CALL sh_err_msg("S2096")
				LET m_from = 1
				EXIT WHILE
			END IF

			IF m_i_frerc_rec.to_loc_id >= m_from_loc
				AND m_i_frerc_rec.to_loc_id <= m_to_loc 
			THEN
				CALL sh_err_msg("S2097")
				LET m_from = 1
				EXIT WHILE
			END IF

			IF m_from_loc >= m_i_frerc_rec.from_loc_id
				AND m_from_loc <= m_i_frerc_rec.to_loc_id
			THEN
				CALL sh_err_msg("S2097")
				LET m_to = 1
				EXIT WHILE
			END IF
		
			IF m_to_loc >= m_i_frerc_rec.from_loc_id
				AND m_to_loc <= m_i_frerc_rec.to_loc_id
			THEN
				CALL sh_err_msg("S2096")
				LET m_from = 1
				EXIT WHILE
			END IF
	
		END WHILE
	END IF
	
	LET m_modify = 0

END FUNCTION

   
protected int GetTransactionLength(string transaction)
{
    return transaction.Length;
}

transaction.Length

GetTransactionLength(transaction)

outside cosmic wrote:

He left.. He was Microsoft certified

protected int GetTransactionLength(string transaction)
{
    if(transaction == null)
        return 0;
    return transaction.Length;
}

0x3c0 wrote:

And if you get an zero-length string?

0x3c0 wrote:

It's uncommon

keefb wrote:

Heavily depends upon the context, but IMO 0 is better as, the need to differentiate between null and "" when getting the length is rare (diffent for the object itself of course).

OSDev

keefb wrote:

Are the best ways to declare a string if you don't already have a value for it.

IFormatProvider culture = new System.Globalization.CultureInfo("en-US", true);
string year = itemDT["YEARBARRIER"].ToString();

string dateYear = "01" + "/" + "01" + "/" + year;

DateTime convertedDate = DateTime.Parse(dateYear, culture, System.Globalization.DateTimeStyles.AssumeLocal);

objBarrierFacade.YearBarrier = convertedDate;

objBarrierFacade.YearBarrier = new DateTime((int)itemDT["YEARBARRIER"], 1, 1);

// getting some user session settings
if(!!isLocked)
{
   // abort the login and show an error message.
}
else
{
   // login the user.
}

nathan.northcutt@gmail.com wrote:

if(!!isLocked)

supercat9 wrote:

Anything wrong with that?