Coding Horrors

OriginalGriff wrote:

Unless they are VB developers, obviously

ragnaroknrol wrote:

You are both horrible liars.

Member 4487083 wrote:

I'm working with some really bad code at the moment. There is some code which joins a load of values (integers) with '~', and then it passes it to a function. So it would be something like 1~5~12~3 etc. In the function it then splits this values on the '~' to get each value. It would be so much more readable, efficient, and less frangile if they had used an array. It amazes me how these people do their job. The other code in the project isn't much better either, actually the other problems are more difficult to fix. I hate blaming other peoples code, but I think that's what I will need to do.

VickyC# wrote:

Does the language support lists?

string foobar(string xml)
{
   XmlDocument doc = new XmlDocument();
   doc.LoadXml(xml);

   // ... do something to doc

   // pick out some part of the doc that another function processes...
   string sXmlSelection = xml.SelectSingleNode("//xmlSelection").OuterXml;
   sXmlSelection = foo(sXmlSelection);
   string sXmlRestriction = xml.SelectSingleNode("//xmlRestriction").OuterXml;
   sXmlRestriction = foo(sXmlRestriction);

   ...

   return doc.OuterXml;
}

string foo(string xml)
{
   XmlDocument doc = new XmlDocument();
   doc.LoadXml(xml);
   // ... do something to doc
   // pick out some part of the doc that another function processes...
   string s = xml.SelectSingleNode(...).OuterXml;
   s = bar(s);

   ...

   return doc.OuterXml;
}

string bar(string xml)
{
   XmlDocument doc = new XmlDocument();
   doc.LoadXml(xml);

   // ... do something to doc

   return doc.OuterXml;
}

void main()
{
   string xmlSelection = "";
   xmlSelection += "" + getElem() + ";
   xmlSelection += "" + getElem() + ";
   xmlSelection += "" + getElem() + ";
   xmlSelection += "" + getElem() + ";
   xmlSelection += "");

   string xmlRestriction = "";
   
   string xmlData = <xmlSelection>" + xmlSelection + "</xmlSelection>";
   xmlData += "<xmlRestriction>" + xmlRestriction + "</xmlRestriction>";

   foobar(xmlData);
}

dojohansen wrote:

string is the perfect data structure

supercat9 wrote:

Strings are a reasonable data structure for information storage in many contexts.

public List GetOrders(Customer c, DateTime start, DateTime end)
public List GetOrders(int customerID, DateTime start, DateTime end) 

public string GetOrders(string xmlData)

public string FormatBarContent(string foo1,
    string foo2, string f003,
    // ...
    string foo14,
    )
{
    StringBuilder sb=new StringBuilder();
    sb.Append(foo1);
    sb.Append("\n");
    sb.Append(foo2);
    sb.Append("\n");
    // ...
    sb.Append(foo14);
//    sb.Append("\n");
    return sb.ToString();
}