The Weird and The Wonderful

kmoorevs wrote:

Anyone see how this might cause random crashes?

while(settext())
{
   // Command 1 (no parameters)
   if(!stricmp(text, "something"))
   {
      DoStuff();
      continue; // Skip command 2-3 & error check
   }

   // Command 2 (single parameter - text to match)
   if(!strincmp(text, sizeof("other thing ")-1, "other thing "))
   {
      for(unsigned int i = 0; i < StringArray.size(); ++i)
      {
          if(!stricmp(text+sizeof("other thing ")-1, StringArray[i]))
          {
             StringArray.erase(i);
             break; // or use goto JumpHere?
          }
      }

      // Did not find? You have to use a variable to check
      ReportError("parameter not found");
      continue; // Skip command 3 & error check
   }

   // Command 3 (not set up)
   if(!stricmp(text, "asparagus"))
   {
      continue; // Skip error check
   }

   // Error check
   ReportError("command not found);
   JumpHere:
      continue; // Labels must have a statement
}

while(settext())
{
   // Command 1 (no parameters)
   if(!stricmp(text, "something"))
   {
      DoStuff();
 //     continue; // Skip command 2-3 & error check
   }

   // Command 2 (single parameter - text to match)
   else if(!strincmp(text, sizeof("other thing ")-1, "other thing "))
   {
      for(unsigned int i = 0; i < StringArray.size(); ++i)
      {
          if(!stricmp(text+sizeof("other thing ")-1, StringArray[i]))
          {
             StringArray.erase(i);
             break; // or use goto JumpHere?
          }
      }

      // Did not find? You have to use a variable to check
      ReportError("parameter not found");
 //     continue; // Skip command 3 & error check
   }

   // Command 3 (not set up)
   else if(!stricmp(text, "asparagus"))
   {
 //      continue; // Skip error check
   }
   else

   {
      // Error check
      ReportError("command not found");
 //     JumpHere:
 //      continue; // Labels must have a statement
   }
}

if() {code(); end_if_checks();} if() {...}

for(unsigned int i = 0; i < StringArray.size(); ++i)
{
    if(!stricmp(text+sizeof("other thing ")-1, StringArray[i]))
    {
       StringArray.erase(i);
       break; // or use goto JumpHere?
    }
}

//somewhere outside the while
const int Sizer = sizeof("other thing ")-1;
//
 
int WalkTo = StringArray.size() - 1;

if (WalkTo >= 0)
{
    const char* Check = text + Sizer;
    int i = -1;
    int Found = 0;

    do
    {
       i++;
       if (!stricmp(Check, StringArray[i]))
       {
           StringArray.erase(i);
           Found = 1;
       }
    } while (!Found && (i < WalkTo));
}

std::vector<std::string> StringArray;