C# Discussion Boards - CodeProject

Re: Text file search, combobox and Datagridview C# Help

13-Jul-17 22:39

Of course ... Wink | ;)

If I see it right then one data-block goes from a line which contents "BLAST DRIVER ON" and ends with the line before the next "BLAST DRIVER ON" or EndOfFile - Am I right ?
The PU-Information is allways inside the line after the line with the content "BLAST SUMMARY"
The Det-Info is allways inside the line after the line with the content "BLASTING PLAN". If you have more than one Det the next Det-DataBlock comes after a line beginning with "PU"

So ... in fact this is the Programm you have to build :
- read the whole text-File into a List(of String) - as I allready wrote before
- scan the text-Lines for the required text-parts
- build Variables (Array's) to which the required Information could be assigned - better build a Class-Object with the required parts in it (but this could also be done later)
your Variables could be : TimeStamp (as string), Dets(as Array of string) and Blast_Data (as string or perhaps something Special)

Do you think that you could create the required code ?

Member 1329440813-Jul-17 22:57

Re: Text file search, combobox and Datagridview C# Help

13-Jul-17 22:57

Let me start by saying thank you for being patient with me.

I was very proud I got as far as I have and being a complete numbskull newbie, I have to say no, I have no idea what code to write for what you are saying. Dead | X|

Ralf Meier14-Jul-17 1:59

Re: Text file search, combobox and Datagridview C# Help

14-Jul-17 1:59

OK ... how should we come together ?

You have a method-part posted which imports the Textfile into a List(of string).
Now - instead of transfering this List into a Listbox try to search one of the Keywords in the List and try to work with it like I described.
Don't see the complete exercise - see it part by part - programming works like this.
And ... don't work with RegEx - who told you to do it like this ?

As I wrote before : I don't write the code for you ... but I would guide you to the solution (if you want) ...

Member 1329440814-Jul-17 2:10

Re: Text file search, combobox and Datagridview C# Help

14-Jul-17 2:10

HI,

Your guidance would be appreciated.

I will work on what you have given me and then repost what I have done for you to assist, if you do not mind.

I do not want anyone to write the code for me, I just want a starting place.

I googled a lot for some answers and regex was one of them that came up.

Am I correct in Saying, I should start bye searching for Keyword:
BLAST DRIVER ON

Thanks again

Member 1329440814-Jul-17 3:07

Re: Text file search, combobox and Datagridview C# Help

14-Jul-17 3:07

Thank you for your help thusfar.

I managed to search for the lines as you suggested:

public void Extract()
        {
            String Fname = openFileDialog2.FileName;
            int counter = 0;
            string line;
            

            var BDate = ("BLAST DRIVER ON");
            var Dets = ("BLAST SUMMARY");
            var BPlan = ("BLASTING PLAN");
            
            
            System.IO.StreamReader file = new System.IO.StreamReader(Fname);

            while ((line = file.ReadLine()) != null)
            {
                if (line.EndsWith(BDate) | line.Contains(Dets) | line.Contains(BPlan))
                {
                    listBox1.Items.Add(line);
                }
                
                    counter++;
                }
            }

The only reason I use the listbox is to see what it returns.

Now for my next questions:
1. How do I return the line after ("BLAST SUMMARY")
2. How do I Extract and only work on the information between the date selected and the next date?

Once I know this I should be getting closer.

Ralf Meier14-Jul-17 9:41

Re: Text file search, combobox and Datagridview C# Help

14-Jul-17 9:41

The approach with the 3 String-Parts is very good.
But now you do it different :
- add the line(s) into a List(of String)
- after that iterate with a loop through this List (List gives you with Count the number of entries in it)
- if you now find at index-Position a string which contains the Dets you take the index+1 into your ?ListBox?
- if you want to seperate a Block you could do it in the same way :
- iterate throught the List and find the first BDate - here starts your Block (memorize the index1)
- continue iterating and find the next BDate (or End of the List) - here Ends your Block (memorize the index2)
- your data-block information now is between index1 and index2

Will you try to realize that ?

Member 1329440817-Jul-17 20:18

Re: Text file search, combobox and Datagridview C# Help

17-Jul-17 20:18

Hi Ralf,

Thank you for the input. I have worked on it over the weekend and am no further.

Could you please explain the index approach as I am not clear on it.

I can find all the info from the text file, but am really struggling to index the found words as I have no idea how to.

What would you suggest?
1. Find the words and index them as follows:
a. Blast driver on - index 1
b blast driver on - index 2 and so on?

Please guide me in the right direction as I am running in circles now.

Please just give me the code to create the index of each find and i will carry on from there.

Regards

Ralf Meier17-Jul-17 21:33

Re: Text file search, combobox and Datagridview C# Help

17-Jul-17 21:33

List<string> lines = new List<string>();
 using (var sr = new StreamReader("file.txt"))
 {
      while (sr.Peek() >= 0)
          lines.Add(sr.ReadLine());
 }


for (int i = 0; i < lines.Count; i++)
{
   if (lines(i).contains(Dets)) {
	listbox.Items.Add(lines(i + 1));
   }
}

Here is a Little sample (much more you will find with Google).
- at first I read the whole content of the file into lines which is a List<string>
- after that I iterate with a Loop through the List and search for 'Dets' - the line after will be transfered into the Listbox (in the moment)

I think, with this sample you could the next steps (as I described before).
Try it first to find the required entries only in the first datablock of your file. If this works we would go to the next step.

Member 1329440828-Jul-17 0:25

Re: Text file search, combobox and Datagridview C# Help

28-Jul-17 0:25

Thank you for all the help. I have got it working they way I want it to.

Ralf Meier28-Jul-17 0:26

Re: Text file search, combobox and Datagridview C# Help

28-Jul-17 0:26

Very good ... Smile | :)

I am interested how you done it - would you provide the code ?

BillWoodruff5-Jul-17 21:44

BillWoodruff

5-Jul-17 21:44

Hi, The Types of your Columns tell me that you want to extract typed objects from your text-data. As Ralf suggests, you are going to have to create a parser to convert text to typed objects, and a typed structure to hold the typed objects. That structure could be a Class, a DataTable, or, a Struct.

But first, consider the source of your data: will that source provide the data in some structured format like XML, JSON, or, even CSV. If the data is in any one of those formats, your work is much simpler.

If it is your code generating the data, then you could focus on simply writing a serializer and de-serializer for your objects/classes. Not hard to do these days.

Also, if there are relatively few data in the text file that you need to parse into objects, and display in the DataGridView, perhaps a "scraping" technique would get what you need, possibly by use of a RegEx.

Suggestion: make an outline of the underlying structure your text file embodies; assuming many instances of the structure in one text file (?): define what markers define the beginning and end of each instance. What fields are always present, which are, optionally, omitted.

Sketch: (ref. : [^])

using System;
using System.IO;
using System.Runtime.Serialization;

namespace MasterBlaster
{
    [DataContract]
    public class Blast
    {
        //>17/05/15-16:40:13:BLAST DRIVER ONic DateTime BlastDriveerOn { set; get; }
        [DataMember]
        public string BlastId { set; get; }

        [DataMember]
        public DateTime BlastTime { set; get; }

        //>PU1053(0005 DETS):
        [DataMember]
        public int BlastInitialDets { set; get; }

        //>1/7B7C35;11/7B70B2;21/7B7058;31/7B83A1;41/7B70D1;
        [DataMember]
        public string[] BlastInitialData { set; get; }
        
        // will not be serialized !
        public string tempInfo;

        public Blast(string id, int idets, params string[] idata)
        {
            BlastId = id;
            BlastInitialDets = idets;
            BlastInitialData = idata;
        }
        
        // keep going ...
        
        // define a serializer
        public static class BlastsSerializer
        {
            static DataContractSerializer dcs = new DataContractSerializer(typeof(Blast[]));

            public static void Serialize(string filepath, Blast[] blasts)
            {
              // will create necessary folder structure if it does not exist
    Directory.CreateDirectory(Path.GetDirectoryName(filepath));
                
                using (var writer = new FileStream(filepath, FileMode.Open, FileAccess.Write))
                {
                    dcs.WriteObject(writer, blasts);
                }
            }

            public static Blast[] DeSerialize(string filepath)
            {
                Blast[] blasts;
                
                using (var reader = new FileStream(filepath, FileMode.Open, FileAccess.Read))
                {
                    blasts = dcs.ReadObject(reader) as Blast[];
                }
 
                return blasts;
            }
        }
    }
}

cheers, Bill

«Beauty is in the eye of the beholder, and it may be necessary from time to time to give a stupid or misinformed beholder a black eye.» Miss Piggy

modified 6-Jul-17 7:37am.

Is this madness? The pursuit of single-statement methods

Kevin Li (Li, Ken-un)4-Jul-17 10:13

Kevin Li (Li, Ken-un)

4-Jul-17 10:13

My code started out as something fairly easy to follow like this:

void RemoveDuplicatesButton_Click(object sender, RoutedEventArgs e)
{
    // Create a set to hold a collection of lines that have already been processed.
    SortedSet<T> seen = new SortedSet<T>();
    // Create a StringBuilder to avoid the performance penalty of concatenating strings repeatedly.
    StringBuilder stringBuilder = new StringBuilder();
    // Split the text from the text box by lines and examine each one.
    foreach (string line in this.InputTextBox.Text.Split(new char[] { '\r', '\n' }))
    {
         // If the string is successfully added to the set, then it has not been processed before.
        if (seen.Add(line))
        {
            // Add the line to the output.
            stringBuilder.AppendLine(line);
        }
    }
    // Build the string and assign it to the text box.
    this.InputTextBox.Text = stringBuilder.ToString();
}

Then I factored out some of the code into extension methods, removed the unnecessary curly braces, and got this:

void RemoveDuplicatesButton_Click(object sender, RoutedEventArgs e)
{
    // Create a StringBuilder to avoid the performance penalty of concatenating strings repeatedly.
    StringBuilder stringBuilder = new StringBuilder();
    // Split the text from the text box into a collection of unique lines.
    foreach (string line in this.InputTextBox.Text.SplitLines().Unique<string>())
        // Add the line to the output.
        stringBuilder.AppendLine(line);
    // Build the string and assign it to the text box.
    this.InputTextBox.Text = stringBuilder.ToString();
}

And then I took it a step further.

void RemoveDuplicatesButton_Click(object sender, RoutedEventArgs e) =>
    // Take the text from the text box, split it by lines, remove the duplicates, and assign the results to the text box.
    this.InputTextBox.Text = this.InputTextBox.Text.SplitLines().Unique<string>().Aggregate<string, StringBuilder, string>(
        new StringBuilder(),
        (StringBuilder stringBuilder, string line) => stringBuilder.AppendLine(line),
        (StringBuilder stringBuilder) => stringBuilder.ToString());

And the one-liner:

void RemoveDuplicatesButton_Click(object sender, RoutedEventArgs e) => this.InputTextBox.Text = this.InputTextBox.Text.SplitLines().Unique().Aggregate(new StringBuilder(), (sb, line) => sb.AppendLine(line), sb => sb.ToString());

I get great joy as a programmer by factoring out as much code as possible, but at which point should I have stopped for this example? Should I perhaps switch to another programming language that’s more conducive to this style of writing?

Re: Is this madness? The pursuit of single-statement methods

PIEBALDconsult4-Jul-17 10:21

PIEBALDconsult

4-Jul-17 10:21

You shouldn't be doing that directly in the Click event handler. You need to refactor that functionality into a library of such routines. Jig | [Dance]

Re: Is this madness? The pursuit of single-statement methods

Richard Deeming4-Jul-17 11:09

Richard Deeming

4-Jul-17 11:09

The first method is a good example of "evil" comments - they just repeat the code in different words. Smile | :)

Fighting Evil in Your Code: Comments on Comments - Simple Talk[^]

I'd be inclined to move the final Aggregate to its own extension method - JoinLines perhaps? You can also simplify it by using String.Join[^]:

public static string JoinLines(this IEnumerable<string> lines) => string.Join(Environment.NewLine, lines);

void RemoveDuplicatesButton_Click(object sender, RoutedEventArgs e) => this.InputTextBox.Text = this.InputTextBox.Text.SplitLines().Unique().JoinLines();

"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer

Re: Is this madness? The pursuit of single-statement methods

Pete O'Hanlon5-Jul-17 4:44

Re: Is this madness? The pursuit of single-statement methods

5-Jul-17 4:44

Great minds think alike Smile | :)

This space for rent

Marc Clifton4-Jul-17 11:26

Marc Clifton

4-Jul-17 11:26

Kevin Li (Li, Ken-un) wrote:
but at which point should I have stopped for this example?

I think what you've done is fantastic. It's considerably more readable than the first implementation.

Kevin Li (Li, Ken-un) wrote:
Should I perhaps switch to another programming language that’s more conducive to this style of writing?

Your only other option to achieve this level of elegance (as far as I know and without dealing with arcane symbols) is F#, IMO.

But I'm with Richard -- I think the Aggregate is unnecessary.

Marc

Latest Article - Create a Dockerized Python Fiddle Web App

Learning to code with python is like learning to swim with those little arm floaties. It gives you undeserved confidence and will eventually drown you. - DangerBunny

Artificial intelligence is the only remedy for natural stupidity. - CDP1802

Re: Is this madness? The pursuit of single-statement methods

Bernhard Hiller4-Jul-17 21:31

Bernhard Hiller

4-Jul-17 21:31

In Backus' paper introducing Fortran (1957), the primary focus was on the speed of writing code; a secondary focus was on debugging.
Uncle Bob's most famous book "Clean Code" (2008) focuses on readability.
Why do we see that paradigm shift?
In 1957, most projects were green-field projects: for a problem, new code was written, the problem was solved and the code was no more needed. Old code need not be maintained.
Nowadays, maintenance of code (brown-field projects) dominate the scene. We have to read code for more often than we write code.
And now simply ask yourself: when someone else - or even you after a couple of weeks - reads that code, how long will it take him to understand it?

Re: Is this madness? The pursuit of single-statement methods

ScottM14-Jul-17 22:49

ScottM1

4-Jul-17 22:49

I personally would have left it at the first one but wouldn't have included the first three comments.

Re: Is this madness? The pursuit of single-statement methods

Pete O'Hanlon5-Jul-17 1:08

Re: Is this madness? The pursuit of single-statement methods

5-Jul-17 1:08

One minor point, you could avoid the StringBuilder in your first example with the use of string.Join. I'm not saying you should, just that you could.

SortedSet<string> seen = new SortedSet<string>();
foreach (string line in longString.Split('\r', '\n'))
{
  seen.Add(line);
}
return string.Join(Environment.NewLine, seen);

If you're interested, this returns this IL:

.maxstack 5
.locals init (
    [0] class [System]System.Collections.Generic.SortedSet`1<string> seen,
    [1] string[] strArray,
    [2] int32 num,
    [3] string line,
    [4] string str)
L_0000: nop
L_0001: newobj instance void [System]System.Collections.Generic.SortedSet`1<string>::.ctor()
L_0006: stloc.0
L_0007: nop
L_0008: ldarg.1
L_0009: ldc.i4.2
L_000a: newarr char
L_000f: dup
L_0010: ldc.i4.0
L_0011: ldc.i4.s 13
L_0013: stelem.i2
L_0014: dup
L_0015: ldc.i4.1
L_0016: ldc.i4.s 10
L_0018: stelem.i2
L_0019: callvirt instance string[] [mscorlib]System.String::Split(char[])
L_001e: stloc.1
L_001f: ldc.i4.0
L_0020: stloc.2
L_0021: br.s L_0035
L_0023: ldloc.1
L_0024: ldloc.2
L_0025: ldelem.ref
L_0026: stloc.3
L_0027: nop
L_0028: ldloc.0
L_0029: ldloc.3
L_002a: callvirt instance bool [System]System.Collections.Generic.SortedSet`1<string>::Add(!0)
L_002f: pop
L_0030: nop
L_0031: ldloc.2
L_0032: ldc.i4.1
L_0033: add
L_0034: stloc.2
L_0035: ldloc.2
L_0036: ldloc.1
L_0037: ldlen
L_0038: conv.i4
L_0039: blt.s L_0023
L_003b: call string [mscorlib]System.Environment::get_NewLine()
L_0040: ldloc.0
L_0041: call string [mscorlib]System.String::Join(string, class [mscorlib]System.Collections.Generic.IEnumerable`1<string>)
L_0046: stloc.s str
L_0048: br.s L_004a
L_004a: ldloc.s str
L_004c: ret

This space for rent

Pete O'Hanlon5-Jul-17 4:20

Re: Is this madness? The pursuit of single-statement methods

5-Jul-17 4:20

Okay, I pondered and pondered and realised that you could refactor to this:

void RemoveDuplicatesButton_Click(object sender, RoutedEventArgs e) => this.InputTextBox.Text = string.Join(Environment.NewLine, new SortedSet<string>(longString.Split('\r', '\n')));

It's as easy as that.

This space for rent

Rob Philpott5-Jul-17 23:22

Rob Philpott

5-Jul-17 23:22

Does the fact that you pondered so long not suggest you might be over-engineering it? There will probably be an equal amount of pondering to working out how it works.

Each to their own, but I much prefer a few simple lines to one clever one.

I suspect you've lost the preservation of order of the original implementation, and why are people using a SortedSet rather than a HashSet?

Regards,
Rob Philpott.

Re: Is this madness? The pursuit of single-statement methods

Pete O'Hanlon6-Jul-17 0:04