Click here to Skip to main content

The Insider News

   

The Insider News is for breaking IT and Software development news. Post your news, your alerts and your inside scoops. This is an IT news-only forum - all off-topic, non-news posts will be removed. If you wish to ask a programming question please post it here.

Get The Daily Insider direct to your mailbox every day. Subscribe now!

 
GeneralRe: 5 Ways Microsoft Could Fix The PC (and Windows 8) PinprotectorAspDotNetDev29-Apr-13 10:19 
NewsCan You Hear Me Now? Cellphone Satellites Phone Home PinstaffTerrence Dorsey28-Apr-13 9:59 
NewsWindows 7 still rules the enterprise, but that's starting to change PinstaffTerrence Dorsey28-Apr-13 9:59 
NewsWhy Your Code's UX Matters PinstaffTerrence Dorsey25-Apr-13 11:00 
GeneralRe: Why Your Code's UX Matters PinadminChris Maunder25-Apr-13 12:15 
GeneralRe: Why Your Code's UX Matters PinprofessionalMatthew Faithfull25-Apr-13 14:52 
GeneralRe: Why Your Code's UX Matters Pinmemberjim lahey25-Apr-13 22:40 
GeneralRe: Why Your Code's UX Matters PinprotectorMarc Clifton28-Apr-13 3:02 
Terrence Dorsey wrote:
If everyone on the team is scared to code review your code because you make them feel dumb, you’re doing it wrong.

 
Sure, if everyone on the team had my skill level, then that would indicate something is very wrong, but then again, if everyone on the team had my skill level, nobody would be afraid of code reviews.
 
The reality is that teams are made up of people of different skills levels, some with less skills than me, others with more skills than me. And frankly, everyone who has the attitude "I can learn something from somebody else" doesn't walk into a code review scared. I've had junior level programmers ask me to explain a piece of code and only then do I realize that I did something poorly.
 
Being scared of a code review has nothing to do with complicated code. It has everything to do with the manager sitting in on the meeting, not understanding what is going on, and asking "why aren't we using VB?" or "can't this be done in SharePoint?" I kid you not.
 
It also has to do with not knowing how to facilitate a code review so that it isn't a waste of time or finger pointing and blaming. A code review should be a learning experience for everyone not a free form forum for criticism.
 
Those same people that fear code reviews are the same ones that don't like to use source control to check in their work at regular intervals, waiting instead for "when its perfect." (If you're reading this, you know who you are.) And that's based on insecurity stemming from knowing that you aren't as good as your resume says and you know you fooled people in their crappy interview processes, and now you're hiding.
 
Dumbing down code for the most junior person on the team isn't productive. If someone on your team feels dumb, then your team is fubar'd to begin with. I've worked with many junior level programmers and at worse, they will realize how much they still have to learn, but they are always grateful that someone is helping them learn, and guess what, they become productive members of the team.
 
Marc

NewsTasks are not Threads PinstaffTerrence Dorsey25-Apr-13 11:00 
GeneralRe: Tasks are not Threads PinmemberClifford Nelson25-Apr-13 16:21 
NewsNeed for (coding) Exercises PinstaffTerrence Dorsey25-Apr-13 10:59 
NewsWhy shipping on time is hard PinstaffTerrence Dorsey25-Apr-13 10:59 
NewsOpen-source Salt vs. Puppet for Configuration Management PinstaffTerrence Dorsey25-Apr-13 10:58 
GeneralRe: Open-source Salt vs. Puppet for Configuration Management PinprofessionalBrisingr Aerowing25-Apr-13 12:32 
NewsMacBook Pro declared 'best performing' Windows laptop PinstaffTerrence Dorsey25-Apr-13 10:06 
GeneralRe: MacBook Pro declared 'best performing' Windows laptop PinmemberClifford Nelson25-Apr-13 10:58 
GeneralRe: MacBook Pro declared 'best performing' Windows laptop Pinmembered welch25-Apr-13 11:41 
GeneralRe: MacBook Pro declared 'best performing' Windows laptop PinmemberClifford Nelson25-Apr-13 14:01 
GeneralRe: MacBook Pro declared 'best performing' Windows laptop Pinmembergstolarov25-Apr-13 16:56 
GeneralRe: MacBook Pro declared 'best performing' Windows laptop PinprofessionalMatthew Faithfull25-Apr-13 14:47 
NewsTwitter Should Shut Me Down PinstaffTerrence Dorsey25-Apr-13 10:05 
NewsUbuntu 13.04 boosts graphics performance to prepare for phones, tablets PinstaffTerrence Dorsey25-Apr-13 10:05 
NewsHere Comes the Next Xbox PinstaffTerrence Dorsey25-Apr-13 10:04 
GeneralRe: Here Comes the Next Xbox PinmemberClifford Nelson25-Apr-13 11:02 
News6 predictions for the future of tech from Google exec Eric Schmidt PinstaffTerrence Dorsey25-Apr-13 10:04 

General General    News News    Suggestion Suggestion    Question Question    Bug Bug    Answer Answer    Joke Joke    Rant Rant    Admin Admin   

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.


Advertise | Privacy | Mobile
Web02 | 2.8.141022.2 | Last Updated 24 Oct 2014
Copyright © CodeProject, 1999-2014
All Rights Reserved. Terms of Service
Layout: fixed | fluid