 |
|
|
Dear Jack,
Dear all,
I used this function in comparing two strings the first is Pattern(* KK *) and the second is Text(TT KK ZZ) and the function return pass. thats briliant,but my question how I can edit the function to be able to catch or handle the characters of matched * to save them in variables. for example:
X = TT
Y = ZZ
to deal with them later on in my system.
I tried many times but its not working well so far.
So please any one have an idea to do that please let me know and its will be appreciated.
Best Regards.
|
| Sign In·View Thread·PermaLink | |
|
|
|
|
|
|
|
|
|
Great code, but when trying this I realized that the following pattern is a match:
Search: ????????
Text to search: ABC
The problem is that the pattern can be LONGER than the text searched, in which case it should return a not found, but instead returns found.
Also, this example succeeds:
Search: y*n
Text to search: yessir
But of course should fail, since I'm looking for a text that ends with n
So I re-wrote your program to this, to correctly handle this situation.
bool StrWildCmp(char* wildstring, char *matchstring){
char stopstring[1];
*stopstring = 0;
while(*matchstring) {
if (*wildstring == '*') {
if (!*++wildstring) {
return true;
} else {
*stopstring = *wildstring;
}
}
if(*stopstring) {
if(*stopstring == *matchstring ) {
wildstring++;
matchstring++;
*stopstring = 0;
} else {
matchstring++;
}
} else if((*wildstring == *matchstring) || (*wildstring == '?')) {
wildstring++;
matchstring++;
} else {
return false;
}
if(!*matchstring && *wildstring && *wildstring != '*') {
return false;
}
}
return true;
}
Thanks again for the inspiration. 
|
| Sign In·View Thread·PermaLink | 2.00/5 (1 vote) |
|
|
|
|
|
|
some cases don't work properly:
wildstring = "a*bc"
matchstring = "abbc"
should be true, but it returns false
wildstring = "a*b"
matchstring = "a"
should be false, but it returns true
wildstring = "a*?b"
matchstring = "axb"
should be true, but it returns false
wildstring = "a**b"
matchstring = "axb"
should be true, but it returns false (ok, the two ** aren't useful, but they should work)
I solved the last 3 bugs, but the first one is a bit tricky...
bool StrWildCmp(char* wildstring, char *matchstring){
char stopstring[1];
*stopstring = '\0';
while(*matchstring != '\0')
{
if (*wildstring == '*')
{
do
{
wildstring++;
} while (*wildstring == '*');
if (*wildstring == '\0') {
return TRUE;
}
else
{
*stopstring = *wildstring; }
}
if(*stopstring != '\0')
{
if((*stopstring == *matchstring) || (*stopstring == '?') )
{
wildstring++;
*stopstring = '\0';
}
matchstring++;
}
else
if((*wildstring == *matchstring) || (*wildstring == '?'))
{
wildstring++;
matchstring++;
}
else
{
return FALSE;
}
if( (*matchstring == '\0') && (*wildstring != '\0') )
{
while (*wildstring == '*') wildstring++;
if (*wildstring == '\0') return TRUE;
else
return FALSE;
}
}
|
| Sign In·View Thread·PermaLink | |
|
|
|
|
|
|
|
|
|
I recommend against PathMatchSpec(). I used that function in my own code and it just bit me. Its wildcard behavior is broken for all but the simplest cases. For example, these two commands incorrectly return false:
::PathMatchSpec("C:\\Windows", "C:\\Windows.*");
::PathMatchSpec("C:\\Windows", "C:\\Windows.");
|
| Sign In·View Thread·PermaLink | |
|
|
|
|
|
|
|
|
|
This is the version of the wildcmp function in XBLite programming language:
FUNCTION SBYTE wildcmp( wildcard$, search$)
' wildcmp(const char *wild, const char *string)
' Written by Jack Handy - jakkhandy@hotmail.com
ULONG cp
ULONG mp
STRING s_txt$
ULONG sp
STRING w_txt$
ULONG wp
IFZ search$ THEN RETURN $$FALSE
IFZ wildcard$ THEN RETURN $$FALSE
w_txt$ = wildcard$ + "\0\0" ' Just to be sure
s_txt$ = search$ + "\0\0"
DO WHILE (s_txt${sp}) && (w_txt${wp} != '*')
IF (w_txt${wp} != s_txt${sp} ) && (w_txt${wp} != '?') THEN RETURN $$FALSE
INC wp
INC sp
LOOP
DO WHILE (s_txt${sp})
IF ( w_txt${wp} == '*' ) THEN
INC wp
IF !(w_txt${wp}) THEN RETURN $$TRUE
mp = wp
cp = sp + 1
ELSE
IF (w_txt${wp} == s_txt${sp} ) || (w_txt${wp} == '?') THEN
INC wp
INC sp
ELSE
wp = mp
sp = cp
IF s_txt${sp} THEN INC cp
ENDIF
ENDIF
LOOP
DO WHILE (w_txt${wp} == '*' )
INC wp
LOOP
RETURN !w_txt${wp}
END FUNCTION
|
| Sign In·View Thread·PermaLink | |
|
|
|
|
|
|
I had converted the wildcmp to C#, it's very easy to wildcard string, thanks so much.
bool WildCompare(string strWild, string strEmail)
{
int cp = 0;
int mp = 0;
int wildIndex = 0;
int emailIndex = 0;
while ((!ValueIsNullOrEmpty(strEmail, emailIndex)) && (ValueAt(strWild, wildIndex) != '*'))
{
if ((ValueAt(strWild, wildIndex) != ValueAt(strEmail, emailIndex)) && (ValueAt(strWild, wildIndex) != '?'))
{
return false;
}
wildIndex++;
emailIndex++;
}
while (!ValueIsNullOrEmpty(strEmail,emailIndex))
{
if (ValueAt( strWild, wildIndex) == '*')
{
wildIndex++;
if (ValueIsNullOrEmpty(strWild,wildIndex ))
{
return true;
}
mp = wildIndex;
cp = emailIndex + 1;
}
else if ((ValueAt(strWild, wildIndex).Equals(ValueAt(strEmail, emailIndex)) || (ValueAt(strWild, wildIndex) == '?')))
{
wildIndex++;
emailIndex++;
}
else
{
wildIndex = mp;
emailIndex = cp++;
}
}
while (ValueAt(strWild, wildIndex) == '*')
{
wildIndex++;
}
return ValueIsNullOrEmpty(strWild, wildIndex);
}
   :~
|
| Sign In·View Thread·PermaLink | |
|
|
|
|
|
|
|
|
|
Well, as direct as I could come up with anyway. Makes use of unsafe to enable pointer arithmetic. Unfortunately, because fixed is required to prevent the GC from moving the pointers, I had to change it to use increment indexers instead of directly manipulating the pointers. Alternatively, you could use stackalloc to instantiate two native char[]'s and copy the values, but that seems contrary to this function's low-memory footprint, high performance goals.
Has been tested against every test case presented in the comments section as well as some additional cases I threw in.
public unsafe static bool GlobCompare( string glob, string path )
{
fixed ( char* pGlob = glob, pPath = path )
{
int pGlobInc = 0;
int pPathInc = 0;
int mp = 0;
int cp = 0;
while ( ( *( pPath + pPathInc ) != 0 ) && ( *( pGlob + pGlobInc ) != '*' ) )
{
if ( ( *( pGlob + pGlobInc ) != *( pPath + pPathInc ) ) && ( *( pGlob + pGlobInc ) != '?' ) )
{
return false;
}
pGlobInc++;
pPathInc++;
}
while ( *( pPath + pPathInc ) != 0 )
{
if ( *( pGlob + pGlobInc ) == '*' )
{
if ( 0 == *( pGlob + ++pGlobInc ) )
{
return true;
}
mp = pGlobInc;
cp = pPathInc + 1;
}
else if ( ( *( pGlob + pGlobInc ) == *( pPath + pPathInc ) ) || ( *( pGlob + pGlobInc ) == '?' ) )
{
pGlobInc++;
pPathInc++;
}
else
{
pGlobInc = mp;
pPathInc = cp++;
}
}
while ( *( pGlob + pGlobInc ) == '*' )
{
pGlobInc++;
}
return ( 0 == *( pGlob + pGlobInc ) );
}
}
|
| Sign In·View Thread·PermaLink | |
|
|
|
|
|
|
|
|
|
I am using this in Artistic Style, a popular multi-platform code formatter available at SourceForge.
http://astyle.sourceforge.net/
Release 1.22 added directory recursion to the project. Wildcard processing was made internal to the program. Linux has a glob function but Windows doesn't. I just used this for both of them. It let me process both platforms in a similar manner.
A minor change was made for Windows to make the comparison case insensitive. Linux was left case sensitive.
Thanks for making it available. Using this was a lot easier than writing my own. I doubt that mine would have been this sophisticated.
|
| Sign In·View Thread·PermaLink | |
|
|
|
|
|
|
 Boy do I feel stupid. I worked on an algorithm like this for days, and never got it quite right. Then, I see the wonderful, and simplistic work of someone like this, and it reminds me that sometimes we all are guilty of 'over-engineering'...
Thanks Mr. Handy!
|
| Sign In·View Thread·PermaLink | 1.00/5 (1 vote) |
|
|
|
|
|
|
How can this code be converted to do a replace? I need to provide a find/replace dialog in an application and I don't want to jump through the hoops of the Boost library. Can anyone help?
Patrick
|
| Sign In·View Thread·PermaLink | 2.00/5 (1 vote) |
|
|
|
|
|
|
Here's RegExp version (may be easily ported to C++).
Pros: More readable, Relies on proven RegExp
Cons: Maybe slower?, If eval string contains RegExp keywords then it might result in unexpected result
public static bool Match(string eval, string pattern, bool caseSensitive)
{
bool match = false;
if (!caseSensitive)
{
eval = eval.ToLower();
pattern = pattern.ToLower();
}
pattern = pattern.Replace(".", @"\.");
pattern = pattern.Replace('?', '.').Replace("*", ".*");
pattern = @"\A" + pattern + @"\z";
try
{
match = Regex.IsMatch(eval, pattern);
}
catch
{
}
return match;
}
|
| Sign In·View Thread·PermaLink | 1.83/5 (3 votes) |
|
|
|
|
|
|
|
|
|
Hi,
wildcmp("*<*>", "<field1><field2>") return 1 while I think it should return 0 (I maybe wrong, so please tell me).
If someone knows how to fix it, I will appreciate.
Regards
|
| Sign In·View Thread·PermaLink | 1.00/5 (1 vote) |
|
|
|
|
|
|
|
|
|
I think it's better to make the function return a bool value. Anyway, many string comparision functions return 0 when the strings equal.
|
| Sign In·View Thread·PermaLink | |
|
|
|
|
|
|
if wild = "*?.abc", str = "abc.abc"
wildcmp(wild, str) not work
but if wild = "?*.abc", str = "abc.abc"
wildcmp(wild, str) do work
does anyone have any idea about the case?
|
| Sign In·View Thread·PermaLink | 3.50/5 (2 votes) |
|
|
|
|
|
|
Having similar problems with "*Hallo 200? ueberalles*.ddd".
It doesn´t work. I think, when the first * is finished, it does not expect an other wildcard in the pattern to follow.
|
| Sign In·View Thread·PermaLink | |
|
|
|
|
|
|
Ignore my last email,
like usually the problem sits in front of the screen.
(I mixed a project built with multibyte Chars with this code which was only chars. And of course I used a Umlaut instead of 'ue' in my tests. So no wonder, why it crashed after the '?' )
I´m very sorry!
|
| Sign In·View Thread·PermaLink | |
|
|
|
|
|
|
|
|
|
i got the overall flow of the program I didnt get the logic of the second loop completely. I understand that in the second loop it checks if there is nothing after * if so then it is a match but if there is something it stores them in the two pointers and then goes on.
also in the final else it goes like else
{
wild = mp;
string = cp++;
}
am sorry but am not getting the logic totally.
can someone please explain?
|
| Sign In·View Thread·PermaLink | |
|
|
|
|
General 
News 
Question 
Answer 
Joke 
Rant 
Admin 
