Click here to Skip to main content

Welcome to the Lounge

   

For lazing about and discussing anything in a software developer's life that takes your fancy except programming questions.

Technical discussions are encouraged, but click here to ask your programming question.

The Lounge is rated PG. If you're about to post something you wouldn't want your kid sister to read then don't post it. No flame wars, no abusive conduct, no programming questions and please don't post ads.


 
GeneralRe: Programming Question Pinmemberkmoorevs17-Jan-13 12:28 
GeneralRe: Programming Question PinmemberEarl Truss18-Jan-13 7:55 
GeneralRe: Programming Question Pinmember_Josh_16-Jan-13 17:07 
GeneralRe: Programming Question PinprotectorAspDotNetDev16-Jan-13 17:34 
GeneralRe: Programming Question Pinmember_Maxxx_16-Jan-13 17:51 
GeneralRe: Programming Question PinprotectorAspDotNetDev16-Jan-13 18:03 
GeneralRe: Programming Question Pinmember_Maxxx_16-Jan-13 18:09 
GeneralRe: Programming Question PinmemberMark_Wallace16-Jan-13 22:00 
GeneralRe: Programming Question PinmemberNagy Vilmos16-Jan-13 23:15 
GeneralRe: Programming Question PinmemberM Towler17-Jan-13 23:18 
GeneralRe: Programming Question Pinmembergreldak17-Jan-13 23:32 
GeneralRe: Programming Question PinmemberM Towler18-Jan-13 1:27 
GeneralRe: Programming Question Pinmemberliordino18-Jan-13 2:29 
GeneralRe: Programming Question Pinmemberpatbob18-Jan-13 6:53 
greldak wrote:
That comment adds meaning to the code - it tells me that the rate is obtained from a service as opposed to being determined within the function.

Actually, that's a poor comment. It tells you about what the GetTaxRate() function is doing.. something this function has no control over nor should it care. What if tomorrow, GetTaxRate() were reimplemented to get a tax rate some other way? Now, at best, the comment here is misleading. At worst, if the remainder of this function depends on that tax rate having been looked up in some service, it will break.
 
So, since the source of the tax rate is unimportant to the code written here, the comment should really read:
// Get the tax rate
 
And how is that more helpful than the code itself:
double taxRate = GetTaxRate();
 
Like you suggested, if its important that the tax rate is fetched from a service, then the code should read:
double taxRate = GetTaxRateFromAppropriateService();
 
Which still probably doesn't need a comment here because what an "appropriate" service is, is defined within GetTaxRateFromAppropriateService().
We can program with only 1's, but if all you've got are zeros, you've got nothing.

GeneralRe: Programming Question PinmemberJackDingler18-Jan-13 7:52 
GeneralRe: Programming Question PinmemberCHill6018-Jan-13 2:28 
GeneralRe: Programming Question PinmemberJohn Atten18-Jan-13 3:32 
GeneralRe: Programming Question Pinmemberjrscherer18-Jan-13 5:08 
GeneralRe: Programming Question Pinmemberjharano18-Jan-13 5:46 
GeneralRe: Programming Question PinmemberFlorin Jurcovici18-Jan-13 20:06 
GeneralRe: Programming Question PinmemberKlaus-Werner Konrad24-Jan-13 2:56 
GeneralRe: Programming Question Pinmember_Maxxx_24-Jan-13 3:10 
GeneralRe: Programming Question PinmemberPIEBALDconsult16-Jan-13 18:09 
GeneralRe: Programming Question Pinmember_Maxxx_16-Jan-13 18:20 
GeneralRe: Programming Question PinmemberPIEBALDconsult16-Jan-13 18:23 
GeneralRe: Programming Question Pinmemberahmed zahmed17-Jan-13 6:12 
JokeRe: Programming Question PinmemberHarry Neethling17-Jan-13 20:52 
GeneralRe: Programming Question PinadminChris Maunder16-Jan-13 18:44 
GeneralRe: Programming Question PinmemberBrisingr Aerowing17-Jan-13 2:28 
GeneralRe: Programming Question Pinmemberjharano18-Jan-13 5:49 
GeneralRe: Programming Question [modified] Pinmembergggustafson18-Jan-13 4:58 
GeneralRe: Programming Question PinadminChris Maunder18-Jan-13 5:24 
GeneralRe: Programming Question Pinmemberjharano18-Jan-13 5:51 
GeneralRe: Programming Question Pinmembergggustafson18-Jan-13 6:41 
GeneralRe: Programming Question PinadminChris Maunder18-Jan-13 10:52 
GeneralRe: Programming Question Pinmembergggustafson18-Jan-13 6:41 
GeneralRe: Programming Question PinadminChris Maunder18-Jan-13 10:34 
GeneralRe: Programming Question Pinmembergggustafson18-Jan-13 12:45 
GeneralRe: Programming Question Pinmember_Damian S_16-Jan-13 18:51 
GeneralRe: Programming Question PinprotectorAspDotNetDev16-Jan-13 18:55 
GeneralRe: Programming Question Pinmember_Damian S_21-Jan-13 13:49 
GeneralRe: Programming Question Pinmemberjschell17-Jan-13 9:50 
GeneralRe: Programming Question PinmemberMark_Wallace16-Jan-13 21:28 
GeneralRe: Programming Question Pinmemberharold aptroot16-Jan-13 22:41 
GeneralRe: Programming Question PinprotectorPete O'Hanlon16-Jan-13 23:07 
GeneralRe: Programming Question Pinmember_Maxxx_17-Jan-13 0:43 
GeneralRe: Programming Question PinmemberNagy Vilmos16-Jan-13 23:07 
GeneralRe: Programming Question PinmemberMaximilien17-Jan-13 2:06 
GeneralRe: Programming Question Pinmember_Maxxx_17-Jan-13 2:38 
GeneralRe: Programming Question Pinmemberjschell17-Jan-13 9:52 

General General    News News    Suggestion Suggestion    Question Question    Bug Bug    Answer Answer    Joke Joke    Rant Rant    Admin Admin   

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.


Advertise | Privacy | Mobile
Web04 | 2.8.150327.1 | Last Updated 31 Mar 2015
Copyright © CodeProject, 1999-2015
All Rights Reserved. Terms of Service
Layout: fixed | fluid