Click here to Skip to main content
15,895,011 members
Articles / Programming Languages / C++11
Tip/Trick

Removing Ugly Flags in C++

Rate me:
Please Sign up or sign in to vote.
4.00/5 (13 votes)
18 Oct 2011CPOL 64K   6   29
Using the Call Gate idiom to reduce number of boolean flags and state variables.
Let's consider a typical use case.

C++
struct car
{
  car()
    :started_(false)
  {
  }
  ~car()
  {
    stop();
  }

  void start()
  {
    if(started_)
       return;
    do_start();
    started_=true;
  }
  void stop()
  {
    if(!started_)
       return;
    do_stop();
    started_=false;
  }
private:
  bool started_;

  // do actual work
  void do_start();
  void do_stop();
};

Doesn't the 'started_' flag look ugly? It does to me. With the Call Gate idiom, that could be changed to:

C++
struct car
{
  car()
    :start_( boost::bind(&car::do_play, get_this()) )
    ,stop_( boost::bind(&car::do_stop, get_this()) )
  {
    //wire the gates
    start_.wire_on(stop_); //'start' opens the 'stop' gate
    stop_.wire_on(start_); //'stop' opens the 'start' gate
  }
  ~car()
  {
    stop();
  }

  void start()
  {
    start_();
  }
  void stop()
  {
    stop_();
  }

private:
  gate start_;
  gate stop_;

  car* get_this() { return this; }

  // do actual work
  void do_start();
  void do_stop();
};


Replacing only one bool with call gates is probably an overkill, but there is a more interesting sample in Call Gate Idiom, and an actual implementation of the call gates.

License

This article, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)


Written By
United States United States
This member has not yet provided a Biography. Assume it's interesting and varied, and probably something to do with programming.

Comments and Discussions

 
GeneralRe: Why replace an ugly flag with two more ugly objects at the cost of functionality and maintainability? Pin
Stefan_Lang25-Oct-11 5:58
Stefan_Lang25-Oct-11 5:58 
GeneralRe: Why replace an ugly flag with two more ugly objects at the cost of functionality and maintainability? Pin
egladysh25-Oct-11 7:01
egladysh25-Oct-11 7:01 
GeneralFeedback Mechanism Absent Pin
xelous218-Oct-11 3:26
xelous218-Oct-11 3:26 
GeneralRe: Feedback Mechanism Absent Pin
egladysh18-Oct-11 7:50
egladysh18-Oct-11 7:50 
QuestionCouple of criticisms Pin
Don Clugston17-Oct-11 21:34
Don Clugston17-Oct-11 21:34 
AnswerRe: Couple of criticisms Pin
egladysh18-Oct-11 7:55
egladysh18-Oct-11 7:55 
AnswerRe: Couple of criticisms Pin
egladysh18-Oct-11 14:25
egladysh18-Oct-11 14:25 
AnswerDisagree Pin
raspopov17-Oct-11 16:33
raspopov17-Oct-11 16:33 
I think that two "knobs" are more uglier than one flag.

General General    News News    Suggestion Suggestion    Question Question    Bug Bug    Answer Answer    Joke Joke    Praise Praise    Rant Rant    Admin Admin   

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.