|
Let us remember, first of all, why we do code reviews. One of the most important goals of any professional software developer is to continually improve the quality of their work. Have those lessons been reviewed?
|
|
|
|
|
Quote: Millions of years ago, apes descended from the trees, evolved opposable thumbs and—eventually—turned into human beings.
Someone forgot to peer-review the author's intelligence factor...
|
|
|
|
|
I think it's reckless to use the word descended in this context.
|
|
|
|
|
Doesn't "opposable thumbs" indicate that you have two thumbs on the same hand?
|
|
|
|
|
No. It means you can fold your thumb over sideways on top of your palm. Try gripping various things either not using your thumb or only using it in the same curl method you can do with your other fingers. It's much harder.
Did you ever see history portrayed as an old man with a wise brow and pulseless heart, waging all things in the balance of reason?
Is not rather the genius of history like an eternal, imploring maiden, full of fire, with a burning heart and flaming soul, humanly warm and humanly beautiful?
--Zachris Topelius
Training a telescope on one’s own belly button will only reveal lint. You like that? You go right on staring at it. I prefer looking at galaxies.
-- Sarah Hoyt
|
|
|
|
|
ed welch wrote: Doesn't "opposable thumbs" indicate that you have two thumbs on the same hand?
No, it means that they're only right some of the time.
I wanna be a eunuchs developer! Pass me a bread knife!
|
|
|
|
|
A patient dead on the table is a lesson.
|
|
|
|
|
I'm not going to your teaching hospital...
TTFN - Kent
|
|
|
|
|
Well, you may go; you may not come back. 
|
|
|
|
|
Find me a programmer that is competent to review my code, and I'll be happy to do a code review. Otherwise, bugger-off.
Marc
|
|
|
|
|
The article states some reasons for code review, e.g.
ensure that at least one other person is familiar with your code.
help train new staff by exposing them to the code of more experienced developers. Does your statement mean that you are not at all interested in sharing your knowledge? Hm, strange, you've provided so many articles to CP, what a contradiction!
|
|
|
|
|
He didn't say he wouldn't, he said: "Give me a competent programmer"
That's very different
M.D.V. 
If something has a solution... Why do we have to worry about?. If it has no solution... For what reason do we have to worry about?
Help me to understand what I'm saying, and I'll explain it better to you
Rating helpful answers is nice, but saying thanks can be even nicer.
|
|
|
|
|
Bernhard Hiller wrote: Does your statement mean that you are not at all interested in sharing your knowledge?
While I understand the reasons you quoted, they're sort of pie-in-the-sky wishful thinking. From my personal experiences, "familiarity with code" is really only achieved by working with the code and, more importantly, knowing the over-arching architectural decisions. I've found that I can show other people (even experienced devs) my code but, unless they are actively working with it, then its an "in one ear, out the other" experience. This stuff doesn't really stick. Certainly, that's my experience when someone shows me their code -- it only starts to stick when I have to work with it.
I've been down the path of helping to train new staff as well. The phrase "more experienced develoeprs" is a rabbit hole. Are the devs more experienced generally, for example in the framework or the language, or are they "merely" more experienced in the specific domain?
If the former, showing green devs complex code simply doesn't work. They need training, not show-and-tell. Ironically, green devs learn best by having people review their code, not my code, which results in a eye-glazing experience.
If the latter, then usually code is the worst way to learn about the business domain as it's often too narrow (and often biased) perspective of the business domain. New senior devs should be reading documentation, working with the product(s), and talking to both management and other devs about goals / issues. Another great technique for new senior devs is to participate in pair programming, that way they learn about how the architecture drives the code that supports the domain. A code review is far too disconnected from that process.
So, that's my hopefully more intelligent response to your very good question.
Marc
|
|
|
|
|
You sound like a pleasure to work with.
|
|
|
|
|
Member 8617829 wrote: You sound like a pleasure to work with.
I have been told exactly that, no sarcasm. In fact, several people have told me that after doing programming with me, they can't imagine going back to the "old ways" of thinking and doing development.
Marc
|
|
|
|
|
Microsoft has put its spin on Google's Chromecast with a device that lets people mirror what's on their PC, laptop or smartphone wirelessly onto their TV. "On the big screen they showed us a sun"
|
|
|
|
|
But, I thought they were gonna stop supporting Windows 7 next January-ish?!
There went $27... And I was gonna upgrade to Win 7 Ultimate, too!
|
|
|
|
|
The popular Linux and Unix shell has a serious security problem that means real trouble for many web servers. Fortunately, a patch -- as source code -- is available. We're not even safe where we live anymore!
|
|
|
|
|
Still no "Critical security hole" in OpenVMS? 
|
|
|
|
|
When you're the only guy still working on it, it will take you to write it 
TTFN - Kent
|
|
|
|
|
Quote: follow Akamai's recommendation and switch "away from using Bash to another shell."
yes, right... EVERY other shell is well tested and without security holes...
--
"My software never has bugs. It just develops random features."
|
|
|
|
|
From DevOps to cloud to agile (and nine more), following at least some of these development trends means you're keeping with the times.
Mobile, agile and DevOps. Guy really went out of the box on this one.
|
|
|
|
|
SD Times wrote: following at least some of these development trends means you're a follower ![Sheep | [baah]](https://codeproject.freetls.fastly.net/script/Forums/Images/sheep.gif) , not a leader
FTFY
|
|
|
|
|
Here are 12 attributes that characterize the new mode of application development beginning to make inroads in enterprises:
And sadly, all 12 of those attributes are the wrong "modes" (though I am willing to remove "mobile" from that count, but what he says about "mobile" is all wrong, IMO.)
And I wonder why I cry at night when I think of where software development is heading.
Marc
|
|
|
|
|
13 Buzzword compliant.
Did you ever see history portrayed as an old man with a wise brow and pulseless heart, waging all things in the balance of reason?
Is not rather the genius of history like an eternal, imploring maiden, full of fire, with a burning heart and flaming soul, humanly warm and humanly beautiful?
--Zachris Topelius
Training a telescope on one’s own belly button will only reveal lint. You like that? You go right on staring at it. I prefer looking at galaxies.
-- Sarah Hoyt
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
