Store array of classes in a list in C#

Question

2.18/5 (5 votes)

See more:

I have a class as below:

C#

class EUInput
{
    public EUInput()
    {
        RtID = 0;
    }

    public int RtID { get; set; }
}

I want to store this class with different RtID values in a list. I tried as below:

C#

static void Main(string[] args)
{
    EUInput clsEUInput = new EUInput();

    List<euinput> list = new List<euinput>();

    for (int i = 0; i < 5; i++)
    {
        clsEUInput.RtID = i;
        list.Add(clsEUInput);
    }

    foreach (EUInput obj in list)
    {
        Console.WriteLine(obj.RtID.ToString());
    }


    Console.ReadLine();
}

I am getting an output as

4
4
4
4
4

But I need an outupt as

0
1
2
3
4

Posted 16-Jul-15 3:07am

guruece24

Updated 16-Jul-15 3:16am

Leo Chapiro

v2

Add a Solution

Comments

[no name] 16-Jul-15 9:13am

That is because you are storing the same object in the list.

Sergey Alexandrovich Kryukov 16-Jul-15 10:16am

Of classes, or perhaps instances of some class(es)? :-)
—SA

Matt T Heffron 16-Jul-15 12:23pm

+4 (Not a "bad" question, just inexperience.)

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Leo Chapiro · Accepted Answer · 2015-07-16T03:19:00

Solution 1

This is the error like Wes Aday already pointed:

//EUInput clsEUInput = new EUInput();

You have to create the new objects in the for-loop for each new value:

C#

        static void Main(string[] args)
        {
            //EUInput clsEUInput = new EUInput();
            EUInput clsEUInput;
 
            List<euinput> list = new List<euinput>();
           
            for (int i = 0; i < 5; i++)
            {
                // you need to create new object every time
                clsEUInput = new EUInput();
                clsEUInput.RtID = i;
                list.Add(clsEUInput);                
            }
 
            foreach (EUInput obj in list)
            {
                Console.WriteLine(obj.RtID.ToString());                
            }
 
          
            Console.ReadLine();
        }
</euinput></euinput>

Posted 16-Jul-15 3:19am

Leo Chapiro

Updated 16-Jul-15 3:23am

v3

Comments

guruece24 16-Jul-15 9:25am

I told that to my boss, he is not accepting it and asking any other solution?

[no name] 16-Jul-15 9:28am

Sure there is. Get a new boss.

phil.o 16-Jul-15 9:28am

What is he not accepting? The fact that a new object has to be created at each iteration? I'm sorry, no pun intended, but if it is so, he's a moron.

Sergey Alexandrovich Kryukov 16-Jul-15 10:19am

Than think who are talking with. If you don't make any decisions, why you are wasting out time here? Let your "boss" asking questions.
—SA

Sergey Alexandrovich Kryukov 16-Jul-15 10:17am

5ed.
—SA

Leo Chapiro 16-Jul-15 10:18am

Thank you! :)

Matt T Heffron 16-Jul-15 12:24pm

+5

Leo Chapiro 16-Jul-15 12:37pm

Thanks, Matt :)

guruece24 17-Jul-15 1:26am

Thank you for everyone who has answered me. He may use your solution but he want to torture me that why he is not accepting. Thanks once again.

guruece24 17-Jul-15 5:43am

Better way can be to use struct instead of class. The problem not coming.

class Program
{
static void Main(string[] args)
{
//EUInput clsEUInput = new EUInput();
structEUInput strctEuinput = new structEUInput();
List<structeuinput> list = new List<structeuinput>();

for (int i = 0; i < 5; i++)
{
strctEuinput.RtID = i;
list.Add(strctEuinput);
}

foreach (structEUInput obj in list)
{
Console.WriteLine(obj.RtID.ToString());
}

}
}

public struct structEUInput
{
public int RtID { get; set; }
}