Multiple infowindows for multiple markers.. getting same content for all infowindows!!?

Question

0.00/5 (No votes)

See more:

for (i=0;i<x.length;i++)>
{
xx=x[i].getElementsByTagName("Lat");
out1=xx[0].firstChild.nodeValue;
xx=x[i].getElementsByTagName("long");
out2=xx[0].firstChild.nodeValue;
xx=x[i].getElementsByTagName("Name");
out3=xx[0].firstChild.nodeValue;
xx=x[i].getElementsByTagName("Phoneno");
out4=xx[0].firstChild.nodeValue;
markers[i] = new google.maps.Marker({
position: { lat:parseFloat(out1), lng: parseFloat(out2)},
map: map
});
var infowindow = new google.maps.InfoWindow({
content: '

Donor Location:' + markers[i].getPosition() +'Name'+' '+out3+'Phoneno'+out4+' '+ '

'
});
google.maps.event.addListener(markers[i], 'click', function() {
infowindow.open(map, markers[i]);
});

google.maps.event.addDomListener(window, 'load', initialize);
}

Here i retreived latitude and longitude values from xml and using markers i plotted all points. but when i click on each marker the content of infowindow remains same. the content am getting is the last parsed xml lat long name phone but what i need is for each loc corresponding name phoneno..
what should i do ??

Posted 8-Sep-15 3:44am

moyna coder

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Moykn · Accepted Answer · 2015-09-08T04:13:00

First:
This should not be inside the for loop:

JavaScript

google.maps.event.addDomListener(window, 'load', initialize);

Second:

JavaScript

var infowindow = new google.maps.InfoWindow({

Javascript doesn't have scope in blocks, so this declaration is inside a containing function. Take a look at this:
http://www.sitepoint.com/demystifying-javascript-variable-scope-hoisting/[^]
and i suggest you learn about closures too.

So, for this to work you could do something like:

JavaScript

for (i=0;i<x.length;i++)
{
  // Here i'm declaring a function and executing it immediately,
  // creating a new scope, in which i can declare new var without affecting others.
  (function (i) {
    xx=x[i].getElementsByTagName("Lat");
    out1=xx[i].firstChild.nodeValue;
    xx=x[i].getElementsByTagName("long");
    out2=xx[i].firstChild.nodeValue;
    xx=x[i].getElementsByTagName("Name");
    out3=xx[i].firstChild.nodeValue;
    xx=x[i].getElementsByTagName("Phoneno");
    out4=xx[i].firstChild.nodeValue;

    var marker = new google.maps.Marker({
                  position: { lat:parseFloat(out1), lng: parseFloat(out2)},
                  map: map
                 }),
        infowindow = new google.maps.InfoWindow({
                          content: '
                             Donor Location:' + marker.getPosition() +'Name'+' '+out3+'Phoneno'+out4+' '+ '
  
                          '
    });
    google.maps.event.addListener(marker, 'click', function() {
      infowindow.open(map, marker);
    });
  }(i))
}

------------------------------EDIT----------------------------------------------
There's something i didn't noticed before, but you are not using the var "i" when setting values on out1, out2, out3, out4 vars. You always get it from the first element on array.