I am using access database and I am developing update code. It gives me error like "Syntax error in UPDATE statement." . So please help me for this error.

Question

1.00/5 (1 vote)

See more:

Syntax error in UPDATE statement:-

VB

public int UpdateClientInfo(ClientMaster currentSelectedItem)
{
   string strQuery = "UPDATE ClientMaster SET " +
   "SubgroupName = '" + currentSelectedItem.Subgroup_Name + "' , " +
   "FirstName = '" + currentSelectedItem.FirstName + "' , " +
   "FirstAge = '" + currentSelectedItem.FirstAge + "' , " +
   "FirstPAN = '" + currentSelectedItem.FirstPAN + "' , " +
   "FatherHusbandName = '" + currentSelectedItem.Father_husbandName + "' , " +
   "Address1 = '" + currentSelectedItem.Address1 + "' , " +
   "Area = '" + currentSelectedItem.Area + "' , " +
   "City = '" + currentSelectedItem.City + "' , " +
   "Pincode = '" + currentSelectedItem.Pincode + "' , " +
   "Mobile = '" + currentSelectedItem.Mobile + "' , " +
   "DPName = '" + currentSelectedItem.DP_Name + "' , " +
   "DematNo = '" + currentSelectedItem.Demat_No + "' , " +
   "BankName = '" + currentSelectedItem.BankName + "' , " +
   "BranchName = '" + currentSelectedItem.BranchName + "' , " +
   "WHERE Id = " + currentSelectedItem.Client_Id;
   return oConnectionClass.ExecuteNonQuery(strQuery);
}

Posted 14-Oct-15 23:37pm

keyur_raval

Updated 14-Oct-15 23:42pm

phil.o

v3

Add a Solution

Comments

$*Developer - Vaibhav*$ 15-Oct-15 5:51am

Please database table structure...so it will be easy to identify.......

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

phil.o · Accepted Answer · 2015-10-14T23:50:00

Never, ever construct a SQL statement by concatenating strings obtained from user inputs. This leaves your code wide open to SQL injection attacks.
Better user parameterized queries instead.
Something like:

C#

string query = "UPDATE ClientMaster SET SubGroupName = @subGroupName, FirstName = @firstName, FirstAge = @firstAge, FirstPAN = @firstPAN, FatherHusbandName = @fatherHusbandName, Address1 = @address1, Area = @area, City = @city, PinCode = @pinCode, Mobile = @mobile, DPName = @dpName, DematNo = @dematNo, BankName = @bankName, BranchName = @branchName WHERE Id = @id";
using (SqlConnection connection = /* construct your connection here */)
using (SqlCommand command = new SqlCommand(query, connection))
{
   connection.Open();
   command.Parameters.AddWithValue("@subGroupName", currentSelectedItem.Subgroup_Name);
   command.Parameters.AddWithValue(/* etc. */);
   // ...
   return command.ExecuteNonQuery();
}

F-ES Sitecore · Accepted Answer · 2015-10-14T23:51:00

Change

SQL

"BranchName = '" + currentSelectedItem.BranchName + "' , " +
   "WHERE Id = " + currentSelectedItem.Client_Id;

to

SQL

"BranchName = '" + currentSelectedItem.BranchName + "' " +
   "WHERE Id = " + currentSelectedItem.Client_Id;

However you'll also get this error if any of your text fields have an apostrophe in them. And the code also leaves you open to sql injection attacks. Use parameterised queries instead (google for examples).

I am using access database and I am developing update code. It gives me error like "Syntax error in UPDATE statement." . So please help me for this error.

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0