What have I written wrongly?

Question

1.00/5 (1 vote)

See more:

I am attempting to change the text of a paragraph with javascript as shown but nothing seem to be changing on my PC. What is wrong?

HTML

<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />
<title>Untitled Document</title>
<script>

function ChangeText(Mynumber)
{
 	return 'Paragraph Changed';
}

function Reset()
{
		
	document.getElementById("demo").innerHTML = ChangeText(1)';
}



</script>
</head>


<body>

<h1>My Web Page</h1>

<p id="demo">A Paragraph</p>

<button type="button" onclick="Reset()">Try it</button>

</body>
</html>

Posted 10-Jan-16 2:31am

Gbenbam

Add a Solution

Comments

Kornfeld Eliyahu Peter 10-Jan-16 8:49am

The only problem I can see is that quote (') here:
document.getElementById("demo").innerHTML = ChangeText(1)';
It creates a JavaScript syntax error (can see it in your debugger)...

Gbenbam 10-Jan-16 8:55am

Thanks. I fixed it. Everything is fine now.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Thomas Daniels · Accepted Answer · 2016-01-10T02:38:00

Solution 1

You made a small typo here:

JavaScript

document.getElementById("demo").innerHTML = ChangeText(1)';

There is a single quote before the semicolon, which mustn't be there.

Posted 10-Jan-16 2:38am

Thomas Daniels

Comments

Wendelius 10-Jan-16 8:53am

Nicely spotted!

Thomas Daniels 10-Jan-16 8:56am

Thanks!

Gbenbam 10-Jan-16 8:56am

Thanks. I have fixed it.

Thomas Daniels 10-Jan-16 8:56am

You're welcome!

Sergey Alexandrovich Kryukov 10-Jan-16 13:08pm

5ed.
—SA

Thomas Daniels 10-Jan-16 13:48pm

Thank you.