Change password funtionality in ASP.NET MVC(unable to fetch value from database)

Question

0.00/5 (No votes)

See more:

I am creating an MVC application.I am getting a null value in variable when I fetching data from database.

My Model Class Code

C#

public partial class tblUser
{
    public int Id { get; set; }

    [Required(ErrorMessage = "Please Enter Your Email Id")]
    [EmailAddress(ErrorMessage = "Invalid Email Address")]
    public string Email { get; set; }

    [Required(ErrorMessage = "Please Enter Your Password")]
    [DataType(DataType.Password)]
    [StringLength(18, ErrorMessage = "The password must be atleast 3 characters long", MinimumLength = 3)]
    public string Password { get; set; }

    [Required(ErrorMessage = "Please Enter Your Password")]
    [DataType(DataType.Password)]
    [StringLength(18, ErrorMessage = "The password must be atleast 3 characters long", MinimumLength = 3)]
    public string NewPassword { get; set; }
}

Here is my change password view code

HTML

@using (Html.BeginForm("Changepassword", "Home", FormMethod.Post))
       {

               <table class="center">


                   <tr>
                       <td>Old Password</td>
                       <td>
                           @Html.EditorFor(pass => pass.Password)
                       </td>
                       <td>@Html.ValidationMessageFor(pass => pass.Password)</td>
                   </tr>
                   <tr class="rowspace">
                       <td>New Password</td>

                       <td>
                           @Html.EditorFor(pass => pass.NewPassword)
                       </td>
                       <td>@Html.ValidationMessageFor(pass => pass.NewPassword)</td>
                   </tr>

                   <tr class="rowspace">
                       <td colspan="3" id="button">
                           <input type="submit" value="Change Password" /></td>
                   </tr>
                   <tr class="rowspace"><td colspan="3">@ViewBag.Message</td></tr>
               </table>

       }

Here is my Home controller code.

Problem I am facing - var userDetail is returning null and when i checked and debug my code using breakpoint my login.Email is not fetching email from database and it is returning null.

C#

public ActionResult Changepassword(tblUser login)
       {
           using (UserDetailsEntities db = new UserDetailsEntities())
           {
               var detail = db.tblUsers.Where(log => log.Password == login.Password).FirstOrDefault();
               if (detail != null)
               {
                   var userDetail = db.tblUsers.FirstOrDefault(c => c.Email == login.Email);


                   if (userDetail != null)
                   {
                       userDetail.Password = login.NewPassword;

                       db.SaveChanges();
                       ViewBag.Message = "Record Inserted Successfully!";
                   }
                   else
                   {
                       ViewBag.Message = "Password not Updated!";
                   }

               }
           }

           return View(login);
       }

What I have tried:

I thought my view does not have a HiddenFor for the Email property of the model, so it will be null in my HttpPost method but it didn't work out.

Posted 30-Apr-16 17:40pm

BeginCoding92

Updated 1-May-16 5:11am

Add a Solution

Comments

Ehsan Sajjad 1-May-16 11:05am

what is exact value in the login.Email when you debug and what is in the table?

F-ES Sitecore 1-May-16 15:02pm

login.email is coming from your model, not the database. You should do this in a single call anyway;

var detail = db.tblUsers.Where(log => log.Password == login.Password && log.Email == login.Email).FirstOrDefault();

You shouldn't store your passwords in plain text anyway, do some research into storing passwords as hashed values with salt.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Ehsan Sajjad · Answer 1 · 2016-05-01T05:11:00

Your problem lies on the following line:

C#

var userDetail = db.tblUsers.FirstOrDefault(c => c.Email == login.Email);

i suspect you want it to be :

var userDetail = db.tblUsers.FirstOrDefault(c => c.Email == detail.Email);

because login isntance will have Email null as you are not passing that from view as hidden field so it will be null, you are fetching user on the basis of password match right now, and if any row found you are want to pass the emial returned from that instance to use to fetch user details.

Please note that, your way of getting row on the basis of password is not right, as multiple users can have same password con-incidently, so in that case there will be problems, if user 1 is updating his password and user2 also has same password, the password for which user will get updated? Think about that scenario.