How do I answer this this and how to change it into right codes

Question

0.00/5 (No votes)

See more:

Using arrays, prompt the user to input how many random number to generate in the range of -10 to 10. Valid input is from 1-50. Display all the negative numbers entered and compute and output the sum of all the negative numbers entered. Also, display all the positive numbers entered and compute and output the product of all the positive numbers entered.

What I have tried:

C++

        do{
            cout<<"No. of random numbers (-10-10): "<<endl;
            cin>>howmany;
                if(howmany<1 || howmany >50)
                cout<<"INVALID INPUT"<<endl;
        }while (howmany<1 || howmany>50);

    cout<<endl<<endl
    <<"The "<<howmany<<" random numbers from 1-50 are :"<<endl;

srand(time(0));

    for (ctr=0,negativectr=0,positivectr=0; ctr<howmany;>     {
        randnum[ctr]= rand() % 50-1;
        cout<<randnum[ctr]<<"\t";

        if (randnum[ctr] % 2 ==0)
            {
                positive[positivectr]=randnum [ctr];
                positivectr++;
            }

        else
            {
                negative[negativectr]=randnum [ctr];
                negativectr--;
            }

{
    cout<<endl<<endl<<"There are "<<positivectr<<" positive numbers generated"<<endl;
for(ctr=0;ctr<positivectr;ctr++);>
}
    cout<<positive[ctr]<<"\t";
}

cout<<endl;

cout<<"There are "<<negativectr<<" negative numbers generated"<<endl;
for(ctr=0;ctr<negativectr;ctr++)>
{
    cout<<negative[ctr]<<"\t";
}

Posted 10-Aug-16 22:05pm

Member 12680725

Updated 10-Aug-16 22:31pm

Patrice T

v2

Add a Solution

Comments

Patrice T 11-Aug-16 4:08am

And what is the problem in this code ?

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2016-08-10T22:31:00

Start by looking at your random number generation code: does it generate numbers in the required range?
Simply put: no.
Your code generates numbers between 0 and 48 inclusive, not values between -10 and 10 inclusive. Rememebr, "%" is the modulus operator: it returns the remainder of a division, so x % 10 will always return values below 10, i.e. "0" to "9" inclusive.

Try changing it to something like:

C++

eachRandomNumber = (rand() % 21) - 10;

The "21" is there so it generates values between 0 and 20 inclusive, then it subtracts 10 to offset the values into your range -10 to 10.

And then use the debugger to work out what else is going on.