Show message when incorrect login

Question

3.00/5 (1 vote)

See more:

When i login with incorrect username and password then it redirect to webform2.aspx where i want to show message Wrong username and password

how i do that ?

i am trying below code but it is not working

C#

protected void Button1_Click(object sender, EventArgs e)
    {
        if(loginmethod(txt_us.Text,txt_pwd.Text)!="NA")
        {
            FormsAuthentication.Initialize();
            String strRole =Assignroles(txt_us.Text);
            FormsAuthenticationTicket fat = new FormsAuthenticationTicket(1, txt_us.Text, DateTime.Now, DateTime.Now.AddMinutes(30), false, strRole, FormsAuthentication.FormsCookiePath);
            Response.Cookies.Add(new HttpCookie(FormsAuthentication.FormsCookieName,
            FormsAuthentication.Encrypt(fat)));
            loginmethod(txt_us.Text, txt_pwd.Text);
            Response.Redirect("WebForm2.aspx");
        }
        else
        {
            Label1.Text = ("Incorrect UserName/Password");
            Label1.Visible = true;
        }
        txt_us.Text = "";
        txt_pwd.Text = "";
    }
    private string loginmethod(string UserName, string Password)
    {
       try
       {
           login_class lg_class = new login_class();
           Entities2 login = new Entities2();
           string logn = Convert.ToString(lg_class.loginfu(UserName, Password).Rows[0]["id"]);
           Session["ID"] = logn.ToString();
           return (logn);
       }
       catch (Exception ex)
       {

           return (ex.Message.ToString());

       }

    }

What I have tried:

loginfu method

public DataTable loginfunction(string username,string password)
{
try
{
Entities2 lg = new Entities2();
List<sp_getlogin_result> gr = lg.SP_GetLogin(username, password).ToList();
DataTable dt = new DataTable();
dt.Columns.Add("id", typeof(string));
foreach (var l in gr)
{
dt.Rows.Add(l.id);
}
return dt;
}

catch (Exception)
{
throw new Exception();

}

}

Posted 4-Sep-16 19:16pm

super_user

Add a Solution

Comments

Karthik_Mahalingam 5-Sep-16 4:36am

debug and check the value in dt

super_user 5-Sep-16 7:04am

dt returns id .. this return id against username and password

Karthik_Mahalingam 5-Sep-16 7:12am

okas per your code, if the id is not 'na' it will validate and redirect to nextpage (WebForm2)
else it will display the error message in the label.

super_user 6-Sep-16 8:02am

yes @Karthik Bangalore

Karthik_Mahalingam 6-Sep-16 10:16am

then! what is the issue

super_user 7-Sep-16 1:20am

issue is when i enter wrong username and password and click on button then this redirect to WebForm2.aspx page whereas i want to show message on login page i.e. incorrect username and password when wrong information is entered

Karthik_Mahalingam 7-Sep-16 11:58am

you have to modify your sp in such a way that, if the credentials are wrong it should return as 'na'

i guess it is returning something else. pls check.

super_user 7-Sep-16 2:26am

@Karthik Bangalore i try this ..

updated

protected void Button1_Click(object sender, EventArgs e)
{
try
{
loginmethod(txt_us.Text, txt_pwd.Text);
FormsAuthentication.Initialize();
String strRole = Assignroles(txt_us.Text);
FormsAuthenticationTicket fat = new FormsAuthenticationTicket(1, txt_us.Text, DateTime.Now, DateTime.Now.AddMinutes(30), false, strRole, FormsAuthentication.FormsCookiePath);
Response.Cookies.Add(new HttpCookie(FormsAuthentication.FormsCookieName,
FormsAuthentication.Encrypt(fat)));
loginmethod(txt_us.Text, txt_pwd.Text);
Response.Redirect("home.aspx");
}
catch
{
Label1.Text = ("Incorrect UserName/Password");
Label1.Visible = true;
}
txt_us.Text = "";
txt_pwd.Text = "";
}
login method

private bool loginmethod(string UserName, string Password)
{
if((txt_us.Text!="NA") && (txt_pwd.Text!= "NA"))
{
login_class lg_class = new login_class();
Entities2 login = new Entities2();
string logn = Convert.ToString(lg_class.loginfunction(UserName, Password).Rows[0]["id"]);
Session["ID"] = logn.ToString();
return (logn);
}
else
{
return false;
}

}

private string Assignroles(string username)
{
if ((txt_us.Text !=string.Empty) && (txt_pwd.Text!= string.Empty))
return "";
else
return string.Empty;
}
when i try above code and when i login with wrong username and password then this show error incrrect username and password

but when i enter correct information i.e. username and password then this always show incorrect username and password where as i want to redirect another page when info is correct

Karthik_Mahalingam 7-Sep-16 11:59am

this code doesnt have any condition.
dont check the status in catch block, it is wrong way of coding.

super_user 8-Sep-16 0:41am

ok so that means i check condition through if else?

Karthik_Mahalingam 8-Sep-16 0:43am

yes, draw a flowchart and how the flow goes and code based on that.

super_user 8-Sep-16 1:06am

but when i do that through if else then when i enter wrong information then this redirect to page whereas i want to show error as i posted my code in question

Karthik_Mahalingam 8-Sep-16 3:31am

if(invalid){ show error }
else
{
redirect to new page.
}

super_user 8-Sep-16 1:08am

flow..
login.aspx --> wrong information--> login.aspx
|
correct info
|
Webform2.aspx

Karthik_Mahalingam 8-Sep-16 3:32am

check above sample code.

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)