Silly question .....

Question

0.00/5 (No votes)

See more:

Private Sub Cmb_Line_ID_GotFocus(ByVal sender As Object, ByVal e As System.EventArgs) Handles Cmb_Line_ID.GotFocus
    Cmb_Line_ID.Items.Clear()
    Dim Cmb_Line_ID_SQL As String = "select * from line"
    Call Fill_Combo_Box(Cmb_Line_ID_SQL)
    Do While myData.Read
        Cmb_Line_ID.Items.Add(myData.Item(0))
    Loop
End Sub

Private Function Fill_Combo_Box(ByVal ComboSQL As String)
    Dim Con As OleDbConnection
    Dim sqlCmd As OleDbCommand = New OleDbCommand(ComboSQL)
    Dim myData As OleDbDataReader
    Con = New OleDbConnection(Main_Form.ConString)
    Try
        Con.Open()
        sqlCmd.Connection = Con
        myData = sqlCmd.ExecuteReader
        Return myData
    Catch 'ex As OledbException
        Return Err.Number
    End Try
End Function

In Do While the myData reader is empty.
Why??????

Thanks and regards.

Posted 7-Apr-11 5:48am

Vagelisr

Add a Solution

Comments

Sandeep Mewara 7-Apr-11 11:58am

Surely a silly title! :)

4 solutions

Solution 3

Oh, I shudder to look at this. You've got a function (Fill_Combo_Box) that doesn't have a return type. And you're taking advantage of that by returning an OleDbDataReader on success and by returning a number on failure. To make matters worse, you're not capturing the return value when you call it in Cmb_Line_ID_GotFocus. So, since myData is declared as a local variable in Fill_Combo_Box, and since you're not capturing the return value from Fill_Combo_Box in Cmb_Line_ID_GotFocus, you can't see it in Cmb_Line_ID_GotFocus.

You need to go back and take a look at some instruction on how to properly declare and use functions, including using their return values.

Posted 7-Apr-11 5:56am

Marc A. Brown

Comments

Sergey Alexandrovich Kryukov 7-Apr-11 15:20pm

Well, good catch, my 5.
--SA

Solution 5

Thanks all of you for yoyr time............

I have a lot of hours in my job..........

Posted 7-Apr-11 6:06am

Vagelisr

Add a Solution

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

#realJSOP · Accepted Answer · 2011-04-07T05:55:00

Solution 2

Because even though you're calling the Fill_Combo_Box method, you're not actually using it's returned object in the calling method. You probably want this:

VB

Dim myData as OleDbDataReader = Fill_Combo_Box(Cmb_Line_ID_SQL)

Not only that, but the method in question doesn't have a return type, which should be OleDbDataReader.

Posted 7-Apr-11 5:55am

#realJSOP

Updated 7-Apr-11 5:59am

v3

Comments

Wild-Programmer 7-Apr-11 11:58am

+5 to you.

Sergey Alexandrovich Kryukov 7-Apr-11 15:20pm

Mine too.
--SA

Maciej Los · Accepted Answer · 2011-04-07T05:59:00

myData is declared inside Fill_Combo_Box function (local variable). You can't "see" it in your Cmb_Line_ID_GotFocus sub.
Solutions:
1) declare myData as global variable (outside both procedures)
or
2) pass reference to your function:

Private Function Fill_Combo_Box(ByVal ComboSQL As String, ByRef myData as OleDbDataReader)
'body
End Function

Using (in Cmb_Line_ID_GotFocus sub):

Fill_Combo_Box(Cmb_Line_ID_SQL, mData)

Silly question .....

4 solutions

Solution 2

Solution 3

Solution 4

Solution 5

Add your solution here

Preview 0

Silly question .....

4 solutions

Solution 2

Solution 3

Solution 4

Solution 5

Add your solution here

Preview 0

Existing Members

...or Join us