Passing Inner-Html to Div

Question

2.50/5 (2 votes)

See more:

Hi to all.

i am making following function:

<pre lang="cs">function generatesciprtofwidget()
{
 //facebook like code
var facebooklike="you like facebookbutton";
document.getElementById('getlikecode').innerHTML = facebooklike; 
//getlikecode is a div which is located in body tag
alert(facebooklike);

return false;

 //facebook like code end
}

in body tag i am giving value to div

<pre lang="xml"><div id="getlikecode">
    <script>
     alert(document.getElementById('getlikecode').value)
    </script>
    </div>

On click button i call the generatesciprtofwidget() function here is code

<input id="Submit1" onclick="generatesciprtofwidget();"  type="submit" value="submit" />

now the problem is alert show undefine why please help!

Posted 5-May-11 21:51pm

balongi

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

jim lahey · Answer 1 · 2011-05-05T23:04:00

Solution 1

Probably because the HtmlElement you're returning with document.getElementById('getlikecode') doesn't have a property called value. You're setting it by writing to the innerHTML property, so read it back out like that too:

XML

<div id="getlikecode">
    <script>
     alert(document.getElementById('getlikecode').innerHTML);
    </script>
    </div>

Posted 5-May-11 23:04pm

jim lahey

Comments

balongi 6-May-11 5:28am

ok thanks

Sergey Alexandrovich Kryukov 6-May-11 10:15am

You're right about "value" (should not be used at all), but I don't see any sense in this alert.
Please see my answer.
--SA

Sergey Alexandrovich Kryukov · Answer 2 · 2011-05-06T04:10:00

I think the problem is putting script in the div in question.

Think of it: you're putting the script as inner HTML of the element which you want to modify with other script. I don't see a sense.
Put the script in the HTML head (I would recommend, always). The element div always have innerHTML (you can make if empty in your HTML code).

How, Jim is right about value, you should not use it for div. You modification code is correct.

XML

document.getElementById('getlikecode').innerHTML = facebooklike;

I recently tested such code, it works.

—SA