How to traverse a linked list in C

Question

4.00/5 (1 vote)

See more:

I want to traverse this linklist (stoListItem) in C

this is the code i have written:

C

typedef struct ListItem
{
    char* pc_Serial_Number;
    int n_Availability;
    char* pc_Color;	
    char* pc_IPAddress;
    struct ListItem *pstNextListItem;
} ListItem_t;

ListItem_t stoListItem;
ListItem_t *stoNext;

stoNext = &stoMVCIListItem;
if (stoNext !=0)
{
    while (stoNext->pstNextListItem!= 0)
    {
        printf("\n Device (%d)", iMVCI_No);
        printf("\n SerialNumber = %s \n Availability = %d"
            "\n Colour = %s \n IP = %s",
            stoListItem.pc_Serial_Number, stoListItem.n_Availability,
            stoNext->pc_Color, stoNext->pc_IPAddress);
        i_No++;
        /*stoNext = stoNext->pstNextListItem;*/
        stoNext = stoListItem.pstNextListItem;
    }
    i_No = 0;
}

Please tell me what is wrong in this..Why iam not able to get the proper values from the linked list

Posted 13-May-11 1:43am

dinesh_redhawk

Updated 13-May-11 2:03am

Olivier Levrey

v2

Add a Solution

Comments

Olivier Levrey 13-May-11 8:04am

Edited for readability.

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Olivier Levrey · Answer 1 · 2011-05-13T02:08:00

Manfred's answer is almost correct. You just need to keep your commented statement:

C

stoNext = &stoMVCIListItem;
 
while (stoNext != 0)
{
    printf("\n Device (%d)",iMVCI_No);
    printf("\n SerialNumber = %s \n Availability = %d"                     "\n Colour = %s \n IP = %s",
        stoNext->pc_Serial_Number,
        stoNext->n_Availability,
        stoNext->pc_Color,
        stoNext->pc_IPAddress
    );
    i_No++;
    //your commented statement was the correct one actually
    //it updates current pointer to the next item in the list
    stoNext = stoNext->pstNextListItem;
}

Manfred Rudolf Bihy · Answer 2 · 2011-05-13T01:53:00

It should read more like this:

C#

typedef struct ListItem
{
    char* pc_Serial_Number;
    int n_Availability;
    char* pc_Color;
    char* pc_IPAddress;
    struct ListItem *pstNextListItem;
}ListItem_t;

ListItem_t stoListItem;
ListItem_t *stoNext;

stoNext = &stoMVCIListItem;

while (stoNext != 0)
{
    printf("\n Device (%d)",iMVCI_No);
    printf("\n SerialNumber = %s \n Availability = %d"                     "\n Colour = %s \n IP = %s",
        stoNext->,pc_Serial_Number,
        stoNext->n_Availability,
        stoNext->pc_Color,
        stoNext->pc_IPAddress
    );
    i_No++;
    stoNext=stoNext->pstNextListItem;
}

i_No=0;

That's all! The if block can be eliminated completely and all the nescessary work is now done in the while loop.

Best Regards,

-MRB

How to traverse a linked list in C

2 solutions

Solution 2

Solution 1

Add your solution here

Preview 0