Must declare the scalar variable on sql update

Question

5.00/5 (1 vote)

See more:

Hi everyone, my project has this error: Must declare the scalar variable "@SerialNo". What's cause?
thanks

private void btnUpdate_Click(object sender, RoutedEventArgs e)
        {
            SqlConnection con = new SqlConnection();
            con.ConnectionString = @"Data Source=.\SQLEXPRESS;AttachDbFilename=|DataDirectory|\Tickets.mdf;Integrated Security=True;User Instance=True";

            SqlCommand cmd = new SqlCommand();
            cmd.Connection = con;

            SqlDataAdapter da = new SqlDataAdapter();
            da.UpdateCommand = new SqlCommand(@"Update [Ticket] Set No = @No, Date = @Date, [From] = @From, [To] = @To, IssueDate = @IssueDate, FlightNo = @FlightNo, ClassBasis = @ClassBasis, Issuer = @Issuer, Code = @Code, Form = @Form, SerialNo = @SerialNo Where No = @No", con);


            da.UpdateCommand.Parameters.Add("@No", SqlDbType.Int).Value = (txtNo.Text).ToString();
            da.UpdateCommand.Parameters.Add("@Date", SqlDbType.NVarChar).Value = txtDate.Text;
            da.UpdateCommand.Parameters.Add("@From", SqlDbType.NVarChar).Value = txtFrom.Text;
            da.UpdateCommand.Parameters.Add("@To", SqlDbType.NVarChar).Value = txtTo.Text;
            da.UpdateCommand.Parameters.Add("@IssueDate", SqlDbType.NVarChar).Value = txtIssueDate.Text;
            da.UpdateCommand.Parameters.Add("@FlightNo", SqlDbType.NVarChar).Value = txtFlightNo.Text;
            da.UpdateCommand.Parameters.Add("@ClassBasis", SqlDbType.NVarChar).Value = txtClassBasis.Text;
            da.UpdateCommand.Parameters.Add("@Issuer", SqlDbType.NVarChar).Value = txtIssuer.Text;
            da.UpdateCommand.Parameters.Add("@Code", SqlDbType.NVarChar).Value = txtCode.Text;
            da.UpdateCommand.Parameters.Add("@Form", SqlDbType.NVarChar).Value = txtForm.Text;
            da.UpdateCommand.Parameters.Add("@SerilNo", SqlDbType.NVarChar).Value = txtSerial.Text;

            con.Open();
            da.UpdateCommand.ExecuteNonQuery();
            con.Close();

            this.ShowData();

Posted 6-Mar-12 21:58pm

M.H. Shojaei

Add a Solution

6 solutions

Solution 3

mistake is @SerialNo instead of @SerilNo

hiii guys we can write stored procedure for this we can avoid this type of error...............

we can use stored procedures also

C#

Create procedure updateproc(@No int,@Date varchar(50)  ,@From varchar(50)  ,@IssueDate varchar(50)  ,@FlightNo varchar(50)   ,@ClassBasis  varchar(50) ,@Issuer varchar(50) ,@SerialNo  varchar(50))
As 
Begin
Update [Ticket] Set No = @No, Date = @Date, [From] = @From, [To] = @To, IssueDate = @IssueDate, FlightNo = @FlightNo, ClassBasis = @ClassBasis, Issuer = @Issuer, Code = @Code, Form = @Form, SerialNo = @SerialNo Where No = @No"
end

Posted 6-Mar-12 22:57pm

tirumalarao123

Updated 6-Mar-12 22:59pm

v3

Comments

walterhevedeich 7-Mar-12 5:03am

Care to explain why creating a stored procedure can avoid that type of error?

Solution 4

when we complile stored procedure....the errors comes like this we can easily find it............Procedure or function 'updateproc' expects parameter '@SerilNo', which was not supplied.

other wise we get like this......declare the scalar variable "@SerialNo" this is confusing error shows

Posted 6-Mar-12 23:18pm

tirumalarao123

Solution 5

you make a mistake when adding parameter in update command. Its nothing but a typing mistake.Just change "@SerilNo" to "@SerialNo"

C#

da.UpdateCommand.Parameters.Add("@SerilNo", SqlDbType.NVarChar).Value = txtSerial.Text;

as

C#

da.UpdateCommand.Parameters.Add("@SerialNo", SqlDbType.NVarChar).Value = txtSerial.Text;

And you will find your code will run perfectly.You should check when using string query from back-end.

Posted 7-Mar-12 20:46pm

Yaseer Arafat

v2

Comments

M.H. Shojaei 8-Mar-12 7:10am

Thanks all

Solution 6

SQL

create trigger trig on city1
for insert
as
begin
declare @id int;
declare @name nvarchar(50);
declare @city nvarchar(50);
declare @adres nvarchar(50);
declare @indate datetime;

select @id=i.id from inserted i;
select @name =i.name from inserted i;
select @city= i.city from inserted i;
select @adres='after trigger fired';
select @indate='after trigger fired';

insert into city11 (id,name,city,adres,indate) values(@id,@name,@city,@adres,getdate());

end

Error:

Must declare the scalar variable "@id".

Posted 15-Jan-15 21:22pm

Shashank Goel

Comments

CHill60 16-Jan-15 4:39am

What does this have to do with the original post (that is nearly 3 years old and resolved) ???

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

walterhevedeich · Accepted Answer · 2012-03-06T22:01:00

Solution 1

I think the cause is this line

C#

da.UpdateCommand.Parameters.Add("@SerilNo", SqlDbType.NVarChar).Value = txtSerial.Text;

This should be @SerialNo instead of @SerilNo

Posted 6-Mar-12 22:01pm

walterhevedeich

Comments

Pete O'Hanlon 7-Mar-12 4:03am

Exactly right. My 5.

walterhevedeich 7-Mar-12 4:05am

Thank you Pete.

M.H. Shojaei 7-Mar-12 4:14am

Ok, thanks :)

member60 · Accepted Answer · 2012-03-06T22:17:00

Solution 2

have a look at the following:
http://blogs.msdn.com/b/spike/archive/2010/03/03/must-declare-the-scalar-variable.aspx[^]
this might help you.

Posted 6-Mar-12 22:17pm

member60