pass more than 1 values to the Send_Mail() method

Question

0.00/5 (No votes)

See more:

Dear Friends,
i have a dataset in which i get more than 1 values like Itemdescription and its Quantity,
and that (Itemdescription,Quantity) i pass to another Method
Send_Mail(Itemdescription,Quantity)...but while sending the values i m only getting 1 value not the other's.
following is the code:

C#

for (int j = 0; j <= dsTotalQuantity.Tables["TotalUnitsRequired"].Rows.Count; j++)
   {
   MaterialDescpt = ds.Tables["TotalUnitsRequired"].Rows[j]["MaterialDesc"].ToString();
   TotalUnitsRequired = ds.Tables["TotalUnitsRequired"].Rows[j]["TotalUnitsRequired"].ToString();
   }

Send_Mail(MaterialDescpt,TotalUnitsRequired);

what could be done!!!

Regards,
Aamir

[edit]Code block added - OriginalGriff[/edit]

Posted 29-Jun-12 19:05pm

aamir07

Updated 29-Jun-12 19:11pm

OriginalGriff

v2

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2012-06-29T19:14:00

When you run code like that in a loop, you overwrite the string each time you loop round. Either use the "+=" operator instead:

C#

for (int j = 0; j <= dsTotalQuantity.Tables["TotalUnitsRequired"].Rows.Count; j++)
   {
   MaterialDescpt += ds.Tables["TotalUnitsRequired"].Rows[j]["MaterialDesc"].ToString();
   TotalUnitsRequired += ds.Tables["TotalUnitsRequired"].Rows[j]["TotalUnitsRequired"].ToString();
   }

Send_Mail(MaterialDescpt,TotalUnitsRequired);

Or better, use a StringBuilder:

C#

StringBuilder sbMat = new StringBuilder();
StringBuildersbTot = new StringBuilder();
for (int j = 0; j <= dsTotalQuantity.Tables["TotalUnitsRequired"].Rows.Count; j++)
   {
   sbMat.Append(ds.Tables["TotalUnitsRequired"].Rows[j]["MaterialDesc"].ToString());
   sbTot.Append(ds.Tables["TotalUnitsRequired"].Rows[j]["TotalUnitsRequired"].ToString());
   }

Send_Mail(sbMat.ToString(),sbTot.ToString());

You may also want to add some separator characters in there...