Click here to Skip to main content
11,712,126 members (66,807 online)
Rate this: bad
Please Sign up or sign in to vote.
See more: PHP
I am using some code to redirect to the page from where login is requested.
But the code is not working at all.

please help.

// Inialize session
// Check, if user is already login, then jump to secured page
if (isset($_SESSION['username'])) {
header('Location: '.$_REQUEST['from']);
<title>Kanu Bhawan - Member Login</title>
<h3>User Login</h3>
<table border="0">
<form method="GET" action="loginproc.php">
<tr><td>Username</td><td>:</td><td><input type="text" name="email" size="20"></td></tr>
<tr><td>Password</td><td>:</td><td><input type="password" name="password" size="20"></td></tr>
<tr><td>&nbsp;</td><td>&nbsp;</td><td><input type="submit" value="Login"></td></tr>
<input type="hidden"  name="id">


require "config.php"; 
$login = mysql_query("SELECT * FROM members WHERE (email = '" . mysql_real_escape_string($_POST['email']) . "') and (password = '" . mysql_real_escape_string(md5($_POST['password'])) . "')");
// Check username and password match
if (mysql_num_rows($login) == 1) {
// Set username session variable
$_SESSION['username'] = $_POST['email'];
// Jump to secured page
header('Location: '.$_GET['from']);
else {
// Jump to login page
header('Location: login.php');


// Inialize session
// Check, if username session is NOT set then this page will jump to login page
if (!isset($_SESSION['username'])) {
header('Location: login.php?from='.rawurlencode($_SERVER['REQUEST_URI'])); 
<title>Secured Page</title>
<p>This is secured page with session: <?php echo $_SESSION['username']; ?>
<br>You can put your restricted information here.</p>
<p><a href="logout.php">Logout</a></p>
please help
Posted 21-Sep-12 10:48am
Edited 21-Sep-12 11:34am
Tushar Sriv at 21-Sep-12 16:56pm
are you posting the address of the url from where you have come to this (current page ie login page)... inside the form through some hidden links ?
Tushar Sriv at 21-Sep-12 16:57pm
Since if it is the case, then you must have to check what you are posting, since otherwise this code is correct...
Sourav Sarkar-SS at 21-Sep-12 16:59pm
the second lase line means
header('Location: '.$_POST['from']);
$_POST['from'] contains nothing
Sourav Sarkar-SS at 21-Sep-12 16:58pm
no hidden links
all the code is given.
please refer this.
Tushar Sriv at 21-Sep-12 16:58pm
And as I have just seen, you are actually sending the 'from' into the url, in that case the $_POST['from'] will not work at all, use $_REQUEST['from'] or $_GET['from'] :-)
Rate this: bad
Please Sign up or sign in to vote.

Solution 1

Sourav Sarkar-SS at 21-Sep-12 17:11pm
You didn't read the question
worthless links.
sorry for down vote.
Tadit Dash at 21-Sep-12 17:16pm
Oh ok...
I am sorry for this...
I thought of the requirement and searched for you.
Can't you implement the things discussed in the links or do u have completely different requirement ?
Sourav Sarkar-SS at 21-Sep-12 17:27pm
I have completely different requirement.
Sourav Sarkar-SS at 21-Sep-12 17:36pm
now you can help me.
I post all the code i have used.
Rate this: bad
Please Sign up or sign in to vote.

Solution 2

Hi Friend,
Use this :

header('Location: '.$_REQUEST['from']);

It will work as the data 'from' is not posted but is sent into the url and is known as get method so better to keep yourself on safe side, use, $_REQUEST, yet you can also use $_GET

I have found a problem, See the code inside login.php :
<form method="get" action="loginproc.php">
Username :<input type="Text" name="username" />
Password :<input type="password" name="password" />
<input type="hidden" name="from" value=<?php echo $_REQUEST['from']; ?>

As you can See I have added an extra hidden field which is posting the address of redirection alongwith the form so, now the error will not occur.

Also, you need a code revision, as this code is not very well implemented and I will suggest you to implement it correctly. You can use some data flowchart kind of diagram to see how the request will flow between the pages when a login event occurs, so that a user never fall into a loop wherein the browser says, "The Browser is redirecting in a way that it will never complete" So, better have a visual look of how the request flows between all the pages, it will become very easy then to handle such situations Smile | :)

Hope it helped,
Tushar Srivastava
Sourav Sarkar-SS at 21-Sep-12 17:13pm

The page isn't redirecting properly
Firefox has detected that the server is redirecting the request for this address in a way that will never complete.
Tushar Sriv at 21-Sep-12 17:15pm
Ok.... Let me think for a while, since there is possible error in sending the address... Can you please post a snippet of code that you have just edited..
Sourav Sarkar-SS at 21-Sep-12 17:17pm
this is the quesrystring, which is sending
can we change it to only

instead of using
Tushar Sriv at 21-Sep-12 17:21pm
That will work possibly.. by the way, are you saving this project under C://xampp/htdocs/xampp/shadi/ ?
Please tell me this :-)
Sourav Sarkar-SS at 21-Sep-12 17:26pm
Tushar Sriv at 21-Sep-12 17:28pm
Ok... then the generated url is correct, ok try to just use fullprofile.php?id=3 and test, it will work 101%
Sourav Sarkar-SS at 21-Sep-12 17:31pm
how to get the url?
Tushar Sriv at 21-Sep-12 17:36pm
Well the best method to get the url is, the same method you are using, but remove the encodeurl and test again, actually, I am also testing what makes your code not run, but till now I have not found any fault..
Sourav Sarkar-SS at 21-Sep-12 17:35pm
I change the question and post all the code I used
please refer.
Tushar Sriv at 21-Sep-12 17:42pm
My friend, all the code is correct, and actually I ran the same same code on my system, and it is working fine that too in firefox :)
Sourav Sarkar-SS at 21-Sep-12 17:46pm
then where i am facing problem
and why?
Tushar Sriv at 21-Sep-12 17:53pm
Actually , your code didn't answered me one thing, where is the entry point... Is it the fullprofile.php since it is the only point I can see.. and seriously, I have tested your codes they are working perfectly on my system.. I copy pasted the codes and ran them.. I have IIS Server with PHP installed and I also have Xampp
Tushar Sriv at 21-Sep-12 18:13pm
I have updated the answer...

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

  Print Answers RSS
0 CHill60 335
1 Sergey Alexandrovich Kryukov 254
2 OriginalGriff 230
3 Andy Lanng 160
4 Maciej Los 130
0 CHill60 335
1 Sergey Alexandrovich Kryukov 245
2 OriginalGriff 230
3 Andy Lanng 160
4 Maciej Los 130

Advertise | Privacy | Mobile
Web02 | 2.8.150819.1 | Last Updated 22 Sep 2012
Copyright © CodeProject, 1999-2015
All Rights Reserved. Terms of Service
Layout: fixed | fluid

CodeProject, 503-250 Ferrand Drive Toronto Ontario, M3C 3G8 Canada +1 416-849-8900 x 100