Index was outside the bounds of the array the in Wcf Service. without this complex code my service is work fine

Question

1.00/5 (1 vote)

See more:

C#

using System;
using System.Collections.Generic;
using System.Linq;
using System.Web;
using System.Data.SqlClient;
using System.ServiceModel;
using System.ServiceModel.Channels;
using System.Data;
using System.Security.Cryptography;
using System.Text;
using System.Web.Security;
using System.Net;

namespace apiv2.travmechanix.com
{
    public class WCFTransactions
    {
        string strConnection = @"Data Source=********;Initial Catalog=*******;User Id=********;Password=******;";
        DataTable dt = new DataTable();
        bool Flag = false;
        public int Serch(string id, string pass)
        {
                //Convert password in md5 format 
         pass = FormsAuthentication.HashPasswordForStoringInConfigFile(pass, "MD5");
                //Get client IP address
                string host = Dns.GetHostName();
                IPHostEntry ip = Dns.GetHostEntry(host);
                string clientAddress = ip.AddressList[1].ToString();
                //Get All Authorize IP Addresses for this User
                DataTable dtIpAddresses = new DataTable();
         SqlDataAdapter objSqlDataAdapter = new SqlDataAdapter("select IP from t2security.AuthorisedIP", strConnection);
                objSqlDataAdapter.Fill(dtIpAddresses);
                //Finding IP Address exist or not
                for (int i = 0; i < dtIpAddresses.Rows.Count; i++)
                {
                    if (dtIpAddresses.Rows[i][0].ToString() == clientAddress)
                    {
                        Flag = true;
                        break;
                    }
                }
                //Finding User Address exist or not
                if (Flag == true)
                {
                    SqlDataAdapter dausers = new SqlDataAdapter("select * from t2security.userProfile where vcUserName='" + id + "'and vcUserPassword='" + pass + "' ", strConnection);
                    dausers.Fill(dt);
                    if (dt.Rows.Count > 0)
                        return 1;
                    else
                        return 0;
                }
                else
                    return 0;
       }
   }
}

Posted 4-Oct-12 23:59pm

niraj.kumar108

Updated 5-Oct-12 0:00am

D-Kishore

v2

Add a Solution

4 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

niraj.kumar108 · Answer 1 · 2012-11-08T23:47:00

Solution 5

OperationContext context = OperationContext.Current;
RemoteEndpointMessageProperty endpoint = (RemoteEndpointMessageProperty)
context.IncomingMessageProperties[RemoteEndpointMessageProperty.Name];
return endpoint.Address;

Posted 8-Nov-12 23:47pm

niraj.kumar108

niraj.kumar108 · Answer 2 · 2012-11-08T23:13:00

Solution 4

I am getting client IP address correct...
OperationContext context = OperationContext.Current;
RemoteEndpointMessageProperty endpoint = (RemoteEndpointMessageProperty)
context.IncomingMessageProperties[RemoteEndpointMessageProperty.Name];
return endpoint.Address;

Posted 8-Nov-12 23:13pm

niraj.kumar108

fjdiewornncalwe · Answer 3 · 2012-10-05T03:21:00

This is a situation where I would propose using foreach instead of a traditional for loop.

C#

foreach( DataRow row in dtIpAddresses.Rows )
{
   if( row[0] != null && row[0].ToString() == clientAddress )
   {
      Flag = true;
      break;
   }
}

But there is a deeper issue. That is the inefficiency of selecting all the allowed ip addresses when you are simply trying to match 1. A more efficient way would be this:

C#

if (clientAddress != string.Empty)
{
   var dbConn = new SqlConnection(strConnection);
   var cmd = new SqlCommand("SELECT count(*) FROM t2security.AuthorizedIP WHERE IP=@clientAddress", dbConn);
   cmd.Parameters.AddWithValue("@clientAddress", clientAddress);
   var dsResults = new DataSet("Results");
   var daResults = new SqlDataAdapter();
   daResults.SelectCommand = cmd;
   daResults.Fill(dsResults);

   if(dsResults.Rows.Count == 1)
   {
      Flag = ( Convert.ToInt32(dsResults.Rows[0].ToString()) == 1 );
   }

(Note: There may be typos in the code, but it should give you the general idea.)

Tejas Vaishnav · Answer 4 · 2012-10-05T02:41:00

please refere this modified code and check it out. Please read comments also.

and one more thing if it is possible then please debug your service and check where's the actual error is.

C#

pass = FormsAuthentication.HashPasswordForStoringInConfigFile(pass, "MD5");
            //Get client IP address
            string host = Dns.GetHostName();
            IPHostEntry ip = Dns.GetHostEntry(host);
            
            //Here you need to check wheather any IP address is selected or not
            //If your ip object has any count then and then you can directly get it with id.AddressList[1]
            string clientAddress = string.Empty;
            if (ip.AddressList.Count() > 0)
                clientAddress = ip.AddressList[1].ToString();

            //Put check validation for empty string so it will reduce burden when client address is empty
            if (clientAddress != string.Empty)
            {
                //Get All Authorize IP Addresses for this User
                DataTable dtIpAddresses = new DataTable();
                SqlDataAdapter objSqlDataAdapter = new SqlDataAdapter("select IP from t2security.AuthorisedIP", strConnection);
                objSqlDataAdapter.Fill(dtIpAddresses);

                //Finding IP Address exist or not
                for (int i = 0; i < dtIpAddresses.Rows.Count; i++)
                {
                    // i think here also you need to put validation for column checking
                    //if column value is null then please do not directly cast it to ToString() it will throw error
                    //Instead you can check like  String.IsNullOrEmpty("your string value") please implement that thing here.
                    if (dtIpAddresses.Rows[i][0].ToString() == clientAddress)
                    {
                        Flag = true;
                        break;
                    }
                }
            }
            //Finding User Address exist or not

            //Or if your Flag is type of bool or boolean then you need not to check like this
            //if(Flag == true) you can directly check like this if(Flag)
            if (Flag)
            {
                SqlDataAdapter dausers = new SqlDataAdapter("select * from t2security.userProfile where vcUserName='" + id + "'and vcUserPassword='" + pass + "' ", strConnection);
                dausers.Fill(dt);
                if (dt.Rows.Count > 0)
                    return 1;
                else
                    return 0;
            }
            else
                return 0;

Index was outside the bounds of the array the in Wcf Service. without this complex code my service is work fine

4 solutions

Solution 5

Solution 4

Solution 2

Solution 1

Add your solution here

Preview 0