how do you write your code?

Question

1.00/5 (1 vote)

See more:

Why do some people write this:

C#

public class NotifyObject
   {
       public NotifyObject(string message, string title)
       {
           this.message = message;
           this.title = title;
       }

       private string title;
       public string Title
       {
           get { return this.title; }
           set { this.title = value; }
       }

       private string message;
       public string Message
       {
           get { return this.message; }
           set { this.message = value; }
       }

       private int forbedringsnr;
       public int forberingsNr
       {
           get { return this.forbedringsnr; }
           set { this.forbedringsnr = value; }
       }
   }

instead of this:

C#

public class NotifyObject2
    {
        public NotifyObject2(string message, string title, int forbedringsnr)
        {
            this.message = message;
            this.title = title;
            this.forbedringsnr = forbedringsnr;
        }
        public string message;
        public string title;
        public int forbedringsnr;
    }

It just makes a score in the linecount, and clutters up the code i think

Posted 26-Nov-12 9:33am

MrDeej

Updated 26-Nov-12 10:48am

CPallini

v2

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

BC @ CV · Answer 1 · 2012-11-26T09:42:00

Why not write your code like this:

C#

public class NotifyObject3
    {
        public NotifyObject3(string message, string title)
        {
            this.Message = message;
            this.Title = title;
        }

        public string Title {get; set;}

        public string Message{get; set;}

    }

Its generally better to use properties instead of public fields so that if you need to add validation or any other code around the setter you won't break binary compatibility with the previous version by having to change from a field to a property.

Gregory Gadow · Answer 2 · 2012-11-26T10:20:00

In .Net, both C# and VB, the two forms you give and the one offered by BC @ CV in Solution 1 all compile to exactly the same intermediate code: you end up with a private allocation for the value and wrappers implementing the get and set property calls.

Of those three techniques, I prefer the first you you gave. Since the Framework will create the private variable declarations anyway, explicitly declaring them allows me to have some control over them. Because I made the variable declarations, I can squeeze out a bit of performance by using the variable directly, internal to the class: using your second method, or the one BC @ CV noted, requires always going through the wrappers.

If I wanted to add validation or additional processing later, I can do that easily without having to rewrite the code. If a property is a List, for example, I can check to see if the object is instantiated in the get and created if not; that way, the property will never, ever return a null value. Or perhaps on the set needs to validate against a list of options and determine if the value is in range or not. With text properties, I will usually call Trim to get rid of extraneous white space before storing the value. That sort of thing.

Rather than have different ways of declaring properties, I stick with the one technique that offers the most benefit, which is the fully explicit one. That makes it easy for me to find stuff when I come back to the code months or years later.