its not working i think there is a logic mistake the question is( Write recursive and non-recursive functions that check parenthesis in a string.)

Question

1.00/5 (1 vote)

See more:

C#

static int Control(int x=0)

     {
         string str = "(a(b(c)d)e)";

         for (int i = 0; i <= str.Length; i++)
         {
             if (str[i] =='(')

                 x++;

             if (str[i] == ')')
                 x--;
         }
         return x;

     }

     static void Main(string[] args)
     {
         int x = 0;

         bool flag = false;
         if (Control(x)==0)

         {
             flag = true;
         }
         Console.WriteLine(flag);

         Console.ReadLine();
     }

Posted 6-Jan-13 7:51am

marchest_21

Updated 6-Jan-13 7:54am

Wendelius

v2

Add a Solution

Comments

Wendelius 6-Jan-13 13:54pm

What's the return value and what would you think it should be?

Also have you tried yet creating the recursive version?

Wendelius 6-Jan-13 14:10pm

Also try using the debugger to see what actually happens. You can also try a bit different string. What happens with:


...
string str = "(a(b(cde)";
...

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sergey Alexandrovich Kryukov · Accepted Answer · 2013-01-06T08:12:00

You were ordered to write two functions, but you have written only one, incorrectly. Also, you did not explain your question properly.

From the very beginning: we are not going to do your homework for your. You are given a change to solve your assignments to learn something. Use this chance well.

Now, in your code there I can see two bugs. First, instead of '<=' you should use '<', in the ending condition of the loop. In the last element, you will get out-of-range exception; there are no elements at the index of [str.Length] or above.

The second one is the function signature. You don't need x as a parameter. Declare it locally.

One important practical advice: never ever create single-character names of any entities. How are you going to use "Find" functionality? How can you figure out what do they mean if you read your own code later? All the names should be semantic, maybe, not too long, but self-explaining and even without use of abbreviation: instead of "i" — "index"; instead of "x" — "count", or "balance".

Good luck with recursion version and everything else.

—SA