C programming of periodic table

Question

1.00/5 (1 vote)

See more:

i have a problem printing out the names of element in an array i used this code but it's not working

#include <stdio.h>
#include <string.h>
int main()

{


int  i;
    char element[20]= { "Hydrogen", "helium", "lithium", "berrylium", "boron",
    "carbon","Nitrogen","oxygen", "flourine","neon","sodium","magnesium",
    "aluminium","silicon","phosphorus","sulphur","chlorine","argon",
    "potassium","calcium"};

for(i=0; i<20; i++)
    {
        printf("%c\n", ( element[i]));
    }
    return 0;
}

Posted 25-Jan-13 2:12am

greato7

Updated 25-Jan-13 2:27am

Abhishek Pant

v3

Add a Solution

Comments

Sergey Alexandrovich Kryukov 25-Jan-13 9:35am

What you are doing has nothing to do with periodic table.
—SA

5 solutions

Solution 6

#include <stdio.h>
#include <string.h>
int main()

{
int i;
char element[20][20]={"Hydrogen", "helium", "lithium", "berrylium", "boron",
"carbon","Nitrogen","oxygen", "flourine","neon","sodium","magnesium",
"aluminium","silicon","phosphorus","sulphur","chlorine","argon",
"potassium","calcium"};

for(i=0; i<20; i++)
{
printf("%s\n", element[i]);
}
return 0;
}

Posted 22-Nov-15 1:05am

Member 12158657

Comments

Richard MacCutchan 22-Nov-15 8:09am

Please do not post in old questions, it is most unlikely the OP still has any interest in this issue.

Solution 4

C++

#include <stdio.h>
#include <string.h>
int main()

{


int  i;
    char element[20][20]= { "Hydrogen", "helium", "lithium", "berrylium", "boron",
    "carbon","Nitrogen","oxygen", "flourine","neon","sodium","magnesium",
    "aluminium","silicon","phosphorus","sulphur","chlorine","argon",
    "potassium","calcium"};

for(i=0; i<20; i++)
{
printf("%s\n", ( element[i]));
}
getch();
return 0;
}

Posted 25-Jan-13 2:34am

Anil Srivastava

Updated 25-Jan-13 2:40am

v2

Comments

H.Brydon 25-Jan-13 22:21pm

Using "char [20][20]" is not as robust as "char*[20]". Go with the suggestions in solution #3.

Solution 1

Try changing:

C++

printf("%c\n", ( element[i]));

To

C++

printf("%s\n", element[i]);

"%c" is a single character, "%s" is a null terminated string

Posted 25-Jan-13 2:30am

OriginalGriff

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

CPallini · Accepted Answer · 2013-01-25T02:34:00

Solution 3

You missed a star (*):

Quote:
char element[20]= { "Hydrogen", "helium", "lithium", "berrylium", "boron",

Should be

char * element[20]= { "Hydrogen", "helium", "lithium", "berrylium", "boron",

You chose the wrong output format:

Quote:
printf("%c\n", ( element[i]));

Should be

printf("%s\n", ( element[i]));

Posted 25-Jan-13 2:34am

CPallini

Comments

fjdiewornncalwe 25-Jan-13 12:59pm

+5.

CPallini 25-Jan-13 13:07pm

Thank you.

H.Brydon 25-Jan-13 22:21pm

+5 me too...

Filipe Marques · Accepted Answer · 2013-01-25T02:33:00

Solution 2

If you declare a variables as

C++

char element[20]

You are allocating an array of char type with 20 elements.

If you want allocate a array of strings, you need

C++

char* element[] = { "Hydrogen", "helium", ...};

Posted 25-Jan-13 2:33am

Filipe Marques

Comments

fjdiewornncalwe 25-Jan-13 12:59pm

+5.