Unreachable code detected

Question

1.00/5 (1 vote)

See more:

C#

public string getInformation()
{
      return (id + " " + Convert.ToString(courseType) + " " + Convert.ToString(CourseCode));

      string type = "";

      if (courseType == 'c')
      {
            type = "HNC";
      }
}

Hey, I was wondering, if anyone there would help me out with this solution.
Its giving me two errors -
1. "unreachable code detected" &
2. "the variable type is assigned but its value is never used".

Posted 16-Feb-13 4:23am

mohammed s

Updated 17-Feb-13 0:13am

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ)

v2

Add a Solution

Comments

Sergey Alexandrovich Kryukov 16-Feb-13 20:03pm

By the way, don't use immediate constants like 'c' and "". Instead of "", use string.Empty.
As to the question: why not reading the warning text thoroughly? it explains everything.
—SA

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ) · Accepted Answer · 2013-02-16T04:50:00

It is because you have written some code after the return statement, which are not getting executed.

That's why the codes written after the return statement are unreachable.
And the type variable is not used, only assigned.
So, your code should look like below.

C#

public string getInformation()
{
     string type = ""; // Use string.Empty instaed of "".

     // You can do this like courseType.Equals(yourVariable); inside if statement, 
     // where yourVariable will contain the character to compare.
     if (courseType == 'c') 
     {
          type = "HNC";
          // try to use this "type" variable or else it is unnecessary.
     }

     return (id + " " + Convert.ToString(courseType) + " " + Convert.ToString(CourseCode));
}

Note
I just corrected the current code. If you face any other problems with your logic, then you have to solve that. Otherwise it should work.

PIEBALDconsult · Accepted Answer · 2013-02-16T04:45:00

Solution 1

a) The first statement is a return; nothing after that will be executed.

b) You don't use the type variable.

c) This is basic stuff and the compiler is telling you what's wrong; no need to ask here.

Posted 16-Feb-13 4:45am

PIEBALDconsult

Updated 16-Feb-13 5:05am

v5

Comments

Sergey Alexandrovich Kryukov 16-Feb-13 20:05pm

My 5, especially for the item (c). I advised just to read the warning text thoroughly... :-)
—SA