Click here to Skip to main content
11,709,581 members (56,049 online)
Rate this: bad
good
Please Sign up or sign in to vote.
See more: SQL-server-2005 , +
is this efficient way of writing the stored procedure in a loop??

for (int i = 0; i < purchaseListView.Items.Count; i++)
                     {
Connection con = new Connection();
                     SqlCommand cmd = new SqlCommand();
                     SqlCommand cmdFifo = new SqlCommand();
                     con.OpenConnection();
                     cmd.Connection = con.DataBaseConnection;
                     cmd.CommandType = CommandType.StoredProcedure;
                     cmd.CommandText = "insertDetail";
                     cmdFifo.Connection = con.DataBaseConnection;
                     cmdFifo.CommandType = CommandType.StoredProcedure;
                     cmdFifo.CommandText = "insertInToMain";
please let me know the right way of looping the stored procedure
best regards
bunzitop
Posted 15-Mar-13 5:14am
bunzitop1.1K
Edited 15-Mar-13 5:38am
v2

1 solution

Rate this: bad
good
Please Sign up or sign in to vote.

Solution 1

No, because you open the connection again and again and again. Outside your loop, open the connection.
  Permalink  
Comments
bunzitop at 15-Mar-13 11:47am
   
suppose i kept the connection outside loop, then will it be standard form of codding and efficient way of coding ??? will my code perform high??
ryanb31 at 15-Mar-13 11:51am
   
For the most part. You can also move the creation of the Command object out and then just clear and readd parameters inside the loop. You might also want to look into using the keyword "using".
Sergey Alexandrovich Kryukov at 15-Mar-13 15:04pm
   
Good point, a 5.
—SA

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

  Print Answers RSS
0 Sergey Alexandrovich Kryukov 530
1 OriginalGriff 250
2 Peter Leow 229
3 Maciej Los 185
4 Mika Wendelius 160
0 OriginalGriff 9,428
1 Sergey Alexandrovich Kryukov 9,037
2 CPallini 5,189
3 Maciej Los 4,991
4 Mika Wendelius 3,856


Advertise | Privacy | Mobile
Web02 | 2.8.150819.1 | Last Updated 15 Mar 2013
Copyright © CodeProject, 1999-2015
All Rights Reserved. Terms of Service
Layout: fixed | fluid

CodeProject, 503-250 Ferrand Drive Toronto Ontario, M3C 3G8 Canada +1 416-849-8900 x 100