Click here to Skip to main content
11,496,146 members (665 online)
The site is currently in read-only mode for maintenance. Posting of new items will be available again shortly.
I tried Google and trying to solve this error but of no use. the error still persists.

When tried to execute this line

cmd.CommandText = string.Format("[dbo].[search_PIValue] {0},'{1}'", kpi,monthyear);

I got this error:

Error converting data type nvarchar to date.

I don't know what to change and where to make a change since i'm a newbie programmer.
Please help me.

This is my stored procedure:
ALTER proc [dbo].[search_PIValue]
(
 
@KPI int,
@monthyear DATE 
)
as
begin
  select 
 p.ObjectID,p.PIName,pt.PIvalue
 
 from PItable p
 inner join
 PITrantbl pt
 on
 p.ObjectID = pt.PID
 
 where p.KPIid=@KPI and pt.Month=MONTH(@monthyear)
end
Posted 3-Apr-13 1:24am
Velrats1.3K
Edited 3-Apr-13 1:25am
v2
Comments
patel_vijay at 3-Apr-13 6:28am
   
What is the value of "monthyear" parameter that you are passing?
Velrats at 3-Apr-13 6:38am
   
{14/05/2012 12:00:00 AM}

This is the value thats being passed @Patel_vijay
patel_vijay at 3-Apr-13 6:44am
   
Try to format your "monthyear" value in yyyy-MM-dd HH.mm.ss format.
It will work

Ex. MONTH('2012-05-14 12:00:00)
Velrats at 3-Apr-13 7:06am
   
I'm confused Where to make this change!?

in c# code or in SQL query?

1 solution

Assuming that monthyear is a DateTime (and it looks like it is from your example) pass it through as a Parameter instead of converting it at all:
cmd.CommandText = string.Format("[dbo].[search_PIValue] {0},@MY", kpi);
cmd.Parameters.AddWithValue("@MY", monthyear);
SQL should then sort it all out itself.
  Permalink  
Comments
Velrats at 3-Apr-13 8:53am
   
Thanks a lot @OriginalGriff it solved my problems and runs fine now :)
OriginalGriff at 3-Apr-13 9:25am
   
You're welcome!

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

  Print Answers RSS
0 RyanDev 230
1 Sergey Alexandrovich Kryukov 114
2 Richard Deeming 100
3 OriginalGriff 89
4 Mostafa Asaduzzaman 59
0 Sergey Alexandrovich Kryukov 10,401
1 OriginalGriff 8,910
2 Sascha Lefèvre 3,899
3 Maciej Los 3,422
4 Richard Deeming 2,600


Advertise | Privacy | Mobile
Web03 | 2.8.150520.1 | Last Updated 3 Apr 2013
Copyright © CodeProject, 1999-2015
All Rights Reserved. Terms of Service
Layout: fixed | fluid

CodeProject, 503-250 Ferrand Drive Toronto Ontario, M3C 3G8 Canada +1 416-849-8900 x 100