Error converting data type nvarchar to date.

Question

0.00/5 (No votes)

See more:

, +

I tried Google and trying to solve this error but of no use. the error still persists.

When tried to execute this line

C#

cmd.CommandText = string.Format("[dbo].[search_PIValue] {0},'{1}'", kpi,monthyear);

I got this error:

Error converting data type nvarchar to date.

I don't know what to change and where to make a change since i'm a newbie programmer.
Please help me.

This is my stored procedure:

SQL

ALTER proc [dbo].[search_PIValue]
(

@KPI int,
@monthyear DATE 
)
as
begin
  select 
 p.ObjectID,p.PIName,pt.PIvalue
 
 from PItable p
 inner join
 PITrantbl pt
 on
 p.ObjectID = pt.PID
 
 where p.KPIid=@KPI and pt.Month=MONTH(@monthyear)
end

Posted 3-Apr-13 0:24am

Velrats

Updated 3-Apr-13 0:25am

v2

Add a Solution

Comments

vijay__p 3-Apr-13 6:28am

What is the value of "monthyear" parameter that you are passing?

Velrats 3-Apr-13 6:38am

{14/05/2012 12:00:00 AM}

This is the value thats being passed @Patel_vijay

vijay__p 3-Apr-13 6:44am

Try to format your "monthyear" value in yyyy-MM-dd HH.mm.ss format.
It will work

Ex. MONTH('2012-05-14 12:00:00)

Velrats 3-Apr-13 7:06am

I'm confused Where to make this change!?

in c# code or in SQL query?

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2013-04-03T01:11:00

Solution 1

Assuming that monthyear is a DateTime (and it looks like it is from your example) pass it through as a Parameter instead of converting it at all:

C#

cmd.CommandText = string.Format("[dbo].[search_PIValue] {0},@MY", kpi);
cmd.Parameters.AddWithValue("@MY", monthyear);

SQL should then sort it all out itself.

Posted 3-Apr-13 1:11am

OriginalGriff

Comments

Velrats 3-Apr-13 8:53am

Thanks a lot @OriginalGriff it solved my problems and runs fine now :)

OriginalGriff 3-Apr-13 9:25am

You're welcome!