Php array not working

Question

1.00/5 (1 vote)

See more:

, +

The best way to start is with my code:

PHP

$passwords = file_get_contents('87941192.php'); 
$passwords_array = array($passwords); 

if((array_key_exists($_POST['uname'], $passwords_array))  
        and  
    ($passwords_array[$_POST['uname']] == $_POST['pass'])){ 
      $_SESSION['user'] = $u; 
      $_SESSION['logged'] = "yes";
	  echo "Login Successful, You can now access your profile <br /> You can also make transactions now.";

      }else{ 

      print "username or pass was incorrect"; 
    
     }

What happens is it gets passwords and usernames from a text file. Im not using a database as im only testing it, and there is no need at the moment. the passwords are in the format:

 'username' => 'password'
,'username1' => 'password1'

Every time it checks if the username and password are correct it turns back negative.

Why is this?

Posted 5-Aug-13 19:06pm

G4mm4R4y

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sergey Alexandrovich Kryukov · Accepted Answer · 2013-08-05T19:13:00

Solution 1

This is because you don't even try to parse your data in file. The fact that the file is in PHP makes no sense at all. By reading your file, you don't interpret it as PHP code. Your call to file_get_contents returns only the string, nothing else:
http://php.net/manual/en/function.file-get-contents.php[^].

You need to parse each like (stop formatting it as a PHP file, it won't help you), read each line, parse it into key/value pairs (it depends on format you choose) and add data with keys to the associative array. All PHP arrays are associative arrays (ordered maps):
http://php.net/manual/en/language.types.array.php[^].

[EDIT]

If you want to find my first recommendation, you would need to read line by line. Please see some code samples here: http://stackoverflow.com/questions/6073235/how-to-read-line-by-line-in-php[^].

Alternatively, you can read all file in the array, but using the function file instead:
http://php.net/manual/en/function.file.php[^].

As documentation says (please see), each line in a file will correspond to an array element. But you need a different array, and array of passwords indexed with file username values.

Then you need to create a new array out of the line array, parsing each separate line into username/password pairs. You can use the method explode: http://php.net/manual/en/function.explode.php[^].

—SA

Posted 5-Aug-13 19:13pm

Sergey Alexandrovich Kryukov

Updated 6-Aug-13 10:03am

v2

Comments

G4mm4R4y 6-Aug-13 1:31am

I've got the code online by stumbling across it, I figured I would give it a try, it's in php for I have no idea at all either but I figured it would not matter, how do I fix it excactly?

Sergey Alexandrovich Kryukov 6-Aug-13 11:38am

This is not a productive approach. You need to write on your own. I explained you in detail what to do. Which part of it you don't understand?
—SA

G4mm4R4y 6-Aug-13 12:45pm

Im confused: I want through line by line. I think it makes sense and should work. $passwords is the string of the passwords file. $passwords_array makes an array from the string. next it checks if the username(The key, is better to say) is in $passwords_array. It also checks if the username key is equal to the password value. But then it turns out false. Why is that? What am I explaining or getting wrong?

Sergey Alexandrovich Kryukov 6-Aug-13 13:37pm

One string, only one string, can you understand it? Your $passwords_array is useless: it has only one element: all text.

If you read line by line, you have one line per string. So you could put a single line in a single array element. In PHP, array is an associative array, did you get it. It is indexed by some "keys". In particular, you don't need to fix the size of array, it grows as you add elements.

You are missing something very basic. What?

—SA

G4mm4R4y 6-Aug-13 13:45pm

A string: A group of letters usually in a variable. I get it only one thing of text is basically what you are saying. I may have phrased that wrong. But only $passwords is a string. One string. A string the has this:
'username' => 'password'
,'username1' => 'password1'
Yes I get it. THAT variable is just a string. But the string is turned into an array:
$passwords_array = array($passwords);
So there we go its an array
Therefor $passwords_array is not useless, correct?

Sergey Alexandrovich Kryukov 6-Aug-13 14:20pm

You can parse the string into array of strings or, better, read a string at a time. First of all, get rid of this format.
I cannot understand what else is unclear.
—SA

G4mm4R4y 6-Aug-13 14:22pm

This is what im trying to say: Isnt it already being parsed into an array of strings by using the array() function
$passwords_array = array($passwords);

Sergey Alexandrovich Kryukov 6-Aug-13 14:35pm

It's going nowhere. You really need to start listening.

Just the opposite: it's not parsed. Isn't it obvious.

Forget parsing. Do this:
1) simplify input format; forget PHP-like format, you won't use it anyway.
2) read line by like, put each line in a separate array element.
At the end, you will get an array with N elements, where N is the line count.

How else should I talk to you so you would understand it?

—SA

G4mm4R4y 6-Aug-13 14:38pm

By input format you mean instead of .php use .txt? As a separate array element isn't that what happens when you put a new line?
a => a
,b => b
A good why to explain would be with commands If you could

Sergey Alexandrovich Kryukov 6-Aug-13 14:41pm

By format I mean format, not file name (as you suggest).
"Isn't it happen..."? Are you serious?! No!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
—SA

G4mm4R4y 6-Aug-13 15:30pm

Okay just abandon that issue I have a new way, but it also returns negative but for some different reason. Can you help me? Code:
session_start()
if((isset($_SESSION['logged']))
and
($_SESSION['logged'] == 'yes')){
// DO NOTHING
}
else {
echo <<<eof
<script="">
alert("Sorry you must be logged in to view this.");
window.history.back();
</script>
EOF;
}

$_SESSION['logged'] is defined and is set to yes

Why isn't it working THIS time

Sergey Alexandrovich Kryukov 6-Aug-13 15:55pm

Why are you mixing the issue with the issue of the session? Those are unrelated things.
Remember to separate concerns.
—SA

G4mm4R4y 6-Aug-13 14:45pm

... I just get confused easily, im new at php, I basically don't know any commands(functions). This is why I am confused!!

Sergey Alexandrovich Kryukov 6-Aug-13 15:55pm

Just learn them. Big deal...
—SA

Sergey Alexandrovich Kryukov 6-Aug-13 16:04pm

Okay, I provided you some mode detail in my updated answer, after [EDIT]. Better now? :-)
—SA

G4mm4R4y 6-Aug-13 18:18pm

Sorry to waste your time but i just abandoned the array and used seperate txt files for passwords.

Sergey Alexandrovich Kryukov 6-Aug-13 19:20pm

Well, this was the right thing to do... No need to abandon the array, you just had to get it correctly. So, is your problem basically solved by now?
—SA

G4mm4R4y 7-Aug-13 13:58pm

Ya basically solved i tested my site, it has a sort of web currency and people share it, im surprised no issues with the php happened when i used it to store give and recieve coins...

Sergey Alexandrovich Kryukov 7-Aug-13 16:33pm

Okay, great.
—SA