Java Duplicate File Finder

Question

0.00/5 (No votes)

See more:

Hello everyone,

So I was presented a job by someone to make an application that would list duplicate files in the current working directory.

Eventually it will give you a choice on what you can do with the duplicate files, but, for now it is going to just list them.

I am using Java (by choice), and I wrote out about 50 lines of code for this. It took me about 20 minutes, and I ran a test inside of eclipse and I got the InputMismatchException. However I get it right when the application goes to run. So I went ahead and compiled the project to test it in Command Prompt, and right when I run it (using java -jar Duplicates.jar) it says:

No Main Manifest Attribute, in Duplicates.jar

Now I think that was something that went wrong when I compiled, I just want to figure out why or how I am getting an InputMismatchException. It says it is occurring at lines 17 and 46. Below is my code, I have comments on lines 17 and 46.

Java

import java.io.File;
import java.io.FileNotFoundException;
import java.util.Scanner;
public class DuplicateFileRemover {
	public static boolean CompareFiles(File x, File y) { 
		try {
			Scanner xs = new Scanner(x);
			Scanner ys = new Scanner(y);
			boolean result = true;
			while (result == true) {
				if (xs.nextByte() != ys.nextByte()) { // Line 17
					result = false;	
				}
				return result;	
			}
		} catch (FileNotFoundException e) {
			System.out.println(e.getMessage());	
		}
		return false;	
	}
	public static void main(String[] args) {
		File dir = new File(".");
		File[] fileList = dir.listFiles();
		for (int x = 0; x < fileList.length; x++) {
			for (int y = x+1; y < fileList.length; y++) {
				if (CompareFiles(fileList[x], fileList[y])) { // Line 46
					System.out.println(fileList[x]);
				}	
			}
		}
		
	}
	
}

Can anyone see a problem with my code? Since I am dealing with files I knew I probably needed to catch a possible FileNotFound exception.

Again, like I said before, there is no user input required, the application runs solely on getting files in the current working directory.

Please help.

Posted 5-Sep-13 5:12am

Gigabyte Giant

Add a Solution

Comments

Richard MacCutchan 5-Sep-13 12:25pm

Your compare routine only tests the first byte of any files, so all your results are likely to be incorrect. You also do not need to convert this to a jar file, just run the class as created by the compiler.

Gigabyte Giant 5-Sep-13 12:30pm

Do you know why at lines 17 and 46 I am getting a InputMismatchException?

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard MacCutchan · Accepted Answer · 2013-09-05T07:36:00

Your problem is due to the Scanner class trying to interpret the tokens from the input file and convert them to bytes. You need a basic stream reader that will allow you to read individual bytes from the file.

Try this: