only last dynamically created picturebox is accessible

Question

0.00/5 (No votes)

See more:

, +

I am creating a WinForm application, in which I have a TabControl1 and at run time created TabPage and PictureBox.

On a Button Click, I make new tab page and PictureBox and add them to the TabControl1.

Now, I can change image of only last created PictureBox.
and when I try to change the image of any PictureBox, except the last one, I am not able to do that

This is the code example.

button1 creates new TabPage and PictureBox.

C#

private void button1_Click(object sender, EventArgs e)
{
    TabPage tpgallery = new TabPage();           
    tpgallery.Name = "tpgallery";
    tpgallery.Text = "  Gallery  ";            
    
    tabControl1.TabPages.Add(tpgallery);           
    
    picturebox1 = new PictureBox();           
    
    picturebox1.Name = "picturebox1name";           
    picturebox1.Image = WindowsFormsApplication7.Properties.Resources.logo1;
    
    tpgallery.Controls.Add(picturebox1);          
}

button2 changes image of PictureBox.

C#

private void button2_Click(object sender, EventArgs e)
{
    picturebox1.Image = WindowsFormsApplication7.Properties.Resources.logo2;
}

[Edit member="Tadit"]
Corrected formatting and grammatical issues.
[/Edit]

Posted 18-Sep-13 0:59am

Code Mirror

Updated 18-Sep-13 2:27am

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ)

v2

Add a Solution

Comments

[no name] 18-Sep-13 7:09am

Probably because you only have one picturebox, picturebox1.

Code Mirror 18-Sep-13 7:19am

so what should i do? how to create many pictureboxes at runtime

[no name] 18-Sep-13 8:41am

"what should i do?", how would you expect me to know that? What I would probably do is use an array or list to hold references to the my picture boxes, depending on what I was actually trying to accomplish. Of course, I would probably not do this at all and I would have create a composite control to do this to begin with.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Code Mirror · Accepted Answer · 2013-09-18T01:35:00

pictureBox1 holds the reference to the last created one, that's the problem.

C#

private void button2_Click(object sender, EventArgs e)
{
    PictureBox pb = tabControl1.SelectedTab.Controls.OfType<picturebox>().FirstOrDefault(p => p.Name == "picturebox1name");

    if (pb != null)
        pb.Image = WindowsFormsApplication7.Properties.Resources.logo2; 
}

Found Here - only last dynamically created picturebox is accessible[^]

[Edit member="Tadit"]
Link text added to reflect the article title.
Corrected formatting and grammatical issues.
[/Edit]