Visual Basic 6 Insert sql

Question

1.00/5 (1 vote)

See more:

Hi

I have this code:

VB

If Len(txtSalary.Text) = 0 Or Len(txtmCover.Text) = 0 Or Len(txtMember.Text) = 0 Or Len(txtmRate.Text) = 0 Then

       MsgBox "Enter Values"

    Else
        tsql = "INSERT INTO Hpacc4(SalaryBill,Rate,Membership,Cover) " & _
               "VALUES('" & txtSalary.Text & "','" & txtmCover & "', '" & txtMember.Text & "', '" & txtmRate.Text & "')" & _
               "WHERE Scheme = '99993' AND RunMonth = '200604' AND AccCode = '110'"

       cnHPtest.Execute (tsql)

      
    End If

When I run it I get an error at my WHERE caluse, please help. I can't see where I went wrong there.

Posted 18-Nov-13 2:17am

Sta_Horse

Add a Solution

Comments

Richard MacCutchan 18-Nov-13 8:25am

Please do not expect people to guess what the error is.

scottgp 18-Nov-13 8:27am

What do you expect the WHERE clause to do in this insert statement?

phil.o 18-Nov-13 9:03am

As there still has been stated:
- what is the purpose of a WHERE clause in an INSERT statement? what are you trying to do exactly?
- without the exact error message we are just bound to guess your problem
- your code is opened to SQL injection attacks ; please use parameterized queries instead of concatenating string like you do to construct your SQL query
- what is the DB type of the following columns: SalaryBill, Rate, Membership, Cover?

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

ZurdoDev · Answer 1 · 2013-11-18T04:11:00

Solution 1

You can't use a WHERE clause in an Insert statement like this. You need to rethink what you are trying to accomplish and re-write. Perhaps you need to remove the WHERE altogether or perhaps you mean to insert those values into the table as well.

Posted 18-Nov-13 4:11am

ZurdoDev

cocis48 · Answer 2 · 2013-11-21T08:17:00

1-Your insert statement is not in the right order (Salary, Rate, Membership, Cover)
as your text boxes.
2-There is no 'Where' when doing an Insert.
3-you probably want to do an Update instead :

Update Hpacc4
Set SalaryBill = txtSalary.Text,
Rate = txtmCover.Text,
Membership=txtMember.Text,
Cover = txtmCover.text
WHERE Scheme = '99993' AND RunMonth = '200604' AND AccCode = '110'

(make sure you use the appropriate quotes in code, the above statement