error: case label does not reduce to an integer constant

Question

2.50/5 (2 votes)

See more:

C#

void flight_operator::get_define_flight_num(char namecode){
    cout<<"Enter flight code:  ";
    cin>>namecode;
    switch(namecode){
        case "MH": case "mh":
            cout<<"Make Airlines\n"<<endl;
            break;
        case "FY": case "fy":
            cout<<"Fire Airlines\n"<<endl;
        default:
            cout<<"Invalid code!"<<endl;
            break;
    }

}

C++

Posted 9-Apr-14 18:45pm

JaironLanda

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sergey Alexandrovich Kryukov · Answer 1 · 2014-04-09T19:02:00

What is not clear? A case label should be an integer constant. It could be one of integer types, enumeration type, something like this, but not a string, not an array, or any other more complex object or a pointer to object. You cannot use your "MH", "FY" and the like.

You could find some explanation in thousands of places: http://bit.ly/1lLKRN4[^].

The whole idea of using immediate constants, especially string, it very bad. This kind of code is not supportable. This is actually a big programming anti-pattern:
http://en.wikipedia.org/wiki/Magic_string_(programming)#Magic_strings_in_code[^],
http://en.wikipedia.org/wiki/Magic_number_(programming)#Unnamed_numerical_constants[^] (yes, magic numbers, too);
see also: http://en.wikipedia.org/wiki/Anti-pattern#Programming[^].

—SA