Which of the following is better?

Question

1.00/5 (1 vote)

See more:

Given that
TCHAR szString[] = _T("Sample");
CString stString;

which of the following is better
1. stString += szString; // Edited to fix type (orignal: sString)
2. stString += (LPCTSTR)szString;

Summary of question:
When concatenating a Cstring with a null terminated string is it advisable to cast to (LPCTSTR) to elimate warning?

Posted 23-Apr-14 5:53am

Gbenbam

Updated 23-Apr-14 8:13am

v6

Add a Solution

Comments

Gbenbam 23-Apr-14 14:39pm

Ok.I figured it out on my own.It doesn't matter whether we are concatenating withva LPCTSTR or LPTSTR.In both case the += operator recieves the right operand as a LPCTSTR into its parameter.So there is absolutely no difference between concatenating with a LPCTSTR and a LPTSTR.

Solution discovered.Case closed.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sergey Alexandrovich Kryukov · Accepted Answer · 2014-04-23T06:21:00

Solution 1

The question makes no sense at all. If two lines do completely different things, how can you ask which one is better?
Besides, if you already use CString, why using LPTSTR at all (well, maybe only for compatibility with some existing code). Also, did you consider using standards strings std::string?

—SA

Posted 23-Apr-14 6:21am

Sergey Alexandrovich Kryukov

Comments

Gbenbam 23-Apr-14 14:26pm

I guese the problem is that I don't really fully understand how the plus operator works with CString.
You are right the question made no sense but I have made appropriate cmidifucation.(Changed LPTSTR to LPCTSTR).
The examples in msdn uses LPCTSTR, but I have a DLL that returns LPTSTR.

See the following MSDN page

http://msdn.microsoft.com/en-us/library/aa300548(v=vs.60).aspx

Sergey Alexandrovich Kryukov 23-Apr-14 15:32pm

The difference is "const". First, you need to understand that CString is class, and other types are just pointers.
The operator you mentioned is not "plus", this is "+=", a very different thing, it returns the reference to the same string after concatenation of the right part. Why not reading original MSDN documentation? Please see:
http://msdn.microsoft.com/en-us/library/aa300548%28v=vs.60%29.aspx

Are you going to accept the answer formally (green "Accept" button)?

—SA