Database not changed when iam success edit [PHP MySQL]

Question

0.00/5 (No votes)

See more:

Hello codeproject member, iam beginning starting dynamic web programming using PHP.
in this case i am learning CRUD using PHP MySQL but iam get some problem on editing database. Need some help and suggestion. thank you

this is my php code named as adminedit.php
when i saw in the database, data not changed..

PHP

<?php include "base.php"; 
	 
?>
<!DOCTYPE HTML>
<html>
<head>
<title>Form Edit Data</title>
</head>

<body>
<table border=1>
  <tr>
    <td align=center>Form Edit Data</td>
  </tr>

<tr><td>

<table>
<form method="post" action="admineditprocess.php">
  	  <?php
	  $id = ereg_replace('[^0-9]', '', $_GET['id']);
      $result = mysql_query("SELECT * FROM users where UserID=$id");
	  while($row = mysql_fetch_array($result))
	  {
	  $nama =  $row['Username'];
	  $pass =  $row['Password'];
	  $email = $row['EmailAddress'];
	  $privilege = $row['privilege'];
	  }
      ?>

<input type="hidden" name="id" value="<? echo $id;?>">

<tr>        
<td>Username</td>
<td>
<input type="text" name="username" size="80" value="<?php echo $nama;?>">
</td>
</tr>

<tr>
<td>Password</td>
<td>
<input type="text" name="password" size="80" value="<?php echo $pass;?>">
</td>
</tr>

<tr>
<td>Email Address</td>
<td>
<input type="text" name="email" size="80" value="<?php echo $email;?>">
</td>
</tr>

<tr>
<td>Privilege</td>
<td>
<input type="text" name="privilege" size="80" value="<?php echo $privilege?>">
</td>
</tr>

<tr>
<td align="left">
<input type="submit" name="submit value" value="Edit">
</td>
</tr>

</form>
</table>
</td></tr>
</table>

</body>
</html>

this is admineditprocess.php

PHP

<?php
include "base.php";
$id = $_POST["id"];
$name = $_POST["username"];
$password = $_POST["password"];
$emailaddress = $_POST["email"];
$privilege = $_POST["privilege"];
$order = "UPDATE users 
          SET Username='$name', 
              Password='$password',
              EmailAddress='$emailaddress',
			  privilege='$privilege'
          WHERE 
	      UserID='$id'";
mysql_query($order);
header("location:adminpanel.php");
?>

Posted 28-Apr-14 4:29am

Gun Gun Febrianza

Updated 28-Apr-14 4:36am

v2

Add a Solution

2 solutions

Solution 2

First, you need to know why it is failing. Gun Gun and Peter both provided code to capture the status in $result. Then, you need to see the value of that result. From there, you can work on a fix. Until then, there is not much that we can do to help.

Posted 28-Apr-14 6:21am

James Jensen

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Peter Leow · Accepted Answer · 2014-04-28T05:10:00

Solution 1

Did you forget to enclose the $id with single quotes:

$result = mysql_query("SELECT * FROM users where UserID='$id'");

However, mysql_query has been deprecated, should use mysqli, and use prepared-statements-in-php-and-mysqli/[^] to prevent sql injection.
++++++++++++++[round 2]++++++++++++++++++++++++
Do you understand your code? Did you get it from somewhere?
The exit($id); will stop the script and print out the value of $id, it is a way to check if the $id contains any value, apparently it did not, that was the reason why the update sql did not update because the WHERE condition was not met. Where is the source of this $id? it was from adminedit.php, that was the reason I suggest the original solution in solution 1.

Posted 28-Apr-14 5:10am

Peter Leow

Updated 30-Apr-14 0:52am

v6

Comments

Gun Gun Febrianza 28-Apr-14 11:32am

i track the problem code is here dear,

$sql = "UPDATE users SET Username='$name', Password='$password', EmailAddress='$emailaddress', privilege='$privilege' WHERE UserID='$id'";

$result=mysql_query($sql);

Peter Leow 28-Apr-14 11:58am

Try exit($id); before the update query and see its value.<br>

Gun Gun Febrianza 30-Apr-14 5:40am

exit($id); <- iam add this still i get nothing changed in my database..
$sql = "UPDATE users SET Username='$name', Password='$password', EmailAddress='$emailaddress', privilege='$privilege' WHERE UserID='$id'";
$result=mysql_query($sql);

Peter Leow 30-Apr-14 6:52am

see my reply in solution 1.