Edit success but data in table of my database not changed

Question

0.00/5 (No votes)

See more:

Hello dear, i know my code is deprecated but iam still newbie who want to know learning php using old method before using PDO or mySQLi. i had an issue in my script code but i cant track where the problem in my script codes. basically i create some admin panel who display all about my users table. This is the code of adminpanel.php :

PHP

<?php include "base.php"; ?>
	<?php
	  //if no session go to mainpage
	  if(!$_SESSION['Username']){
	    header('location:index.php');
	  }  
	  //if ssesion is admin access accepted
	  if($_SESSION['privilege'] == 'admin' ){
	 // header('location:adminpanel.php');
	  }
	  //if not access is deny
	  else {
      header('Location: login.php');
      }
	?>
	
<!doctype html>
<html>
<head>
<title>Admin Panel</title>
</head>

<body>

Hai <?=$_SESSION['Username']?>,<br>
Welcome on admin panel..<br><br>
<?php
$result = mysql_query("SELECT * FROM users");
echo "<table border='1'>
<tr>
<th>User ID</th>
<th>Username</th>
<th>Password</th>
<th>Email Address</th>
<th>Privelege</th>
<th>Setting</th>
</tr>";

while($row = mysql_fetch_array($result))
  {
  echo "<tr>";
  echo "<td>" . $row['UserID'] . "</td>";
  echo "<td>" . $row['Username'] . "</td>";
  echo "<td>" . $row['Password'] . "</td>";
  echo "<td>" . $row['EmailAddress'] . "</td>";
  echo "<td>" . $row['privilege'] . "</td>";
  echo "<td><a href=\"adminedit.php?id=$row[UserID]\">Edit</a></td>";
  echo "</tr>";
  }
echo "</table><br>";
	
if (!isset($_SESSION['count'])) {
	   $_SESSION['count'] = 0;
	} else {
	   $_SESSION['count']++;
	}
	echo "you have been login to this page " .
	$_SESSION['count']." times";
	echo "<br>";
	echo "Kita kenali Anda sebagai: <br><br>"  .session_id();
	?>
		<br><br><A href='logout.php'>logout</A><br><br>
</body>
</html>

now if i want to edit some user account it will redirected to new page called adminedit.php this is the code :

PHP

<?php include "base.php"; 
	  $id = $_GET["id"];
?>

<!DOCTYPE HTML>
<html>
<head>
<title>Form Edit Data</title>
</head>

<body>
<table border=1>
  <tr>
    <td align=center>Form Edit Data</td>
  </tr>
  	  <?php
      $result = mysql_query("SELECT * FROM users where UserID='$id'");
	  while($row = mysql_fetch_array($result))
	  {
	  $nama =  $row['Username'];
	  $pass =  $row['Password'];
	  $email = $row['EmailAddress'];
	  $privilege = $row['privilege'];
	  }
      ?>
<tr><td>

<?php
if(isset($_POST['submit']))
{
$id = $_POST["id"];
$name = $_POST["username"];
$password = $_POST["password"];
$emailaddress = $_POST["email"];
$privilege = $_POST["privilege"];
$sql = "UPDATE users SET Username='$name', Password='$password', EmailAddress='$emailaddress', privilege='$privilege' WHERE UserID='$id'";
$result=mysql_query($sql);
if($result){
echo "Successful";
echo "<BR>";
header('location:adminpanel.php');
echo "<a href='adminpanel.php'>View result</a>"; 
}

else {
echo "ERROR";
}

}
?>

<table>
<form method="post" action="<?php echo $_SERVER['PHP_SELF']; ?>">
<input type="hidden" name="id" value="<? echo $id;?>">

<tr>        
<td>Username</td>
<td>
<input type="text" name="username" size="80" value="<?php echo $nama;?>">
</td>
</tr>

<tr>
<td>Password</td>
<td>
<input type="text" name="password" size="80" value="<?php echo $pass;?>">
</td>
</tr>

<tr>
<td>Email Address</td>
<td>
<input type="text" name="email" size="80" value="<?php echo $email;?>">
</td>
</tr>

<tr>
<td>Privilege</td>
<td>
<input type="text" name="privilege" size="80" value="<?php echo $privilege?>">
</td>
</tr>

<tr>
<td align="left">
<input type="submit" name="submit" value="Edit">
</td>
</tr>

</form>
</table>
</td></tr>
</table>

</body>
</html>

but when iam click the button to edit some account in the table user nothing changed? would be happy if someone can help me thank you.

Posted 30-Apr-14 1:26am

Gun Gun Febrianza

Add a Solution

Comments

Sunasara Imdadhusen 27-May-14 7:18am

Are you getting any error?

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)