having a problem with retrieving the connection string

Question

1.00/5 (1 vote)

See more:

C#

using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
using System.Configuration;

namespace hospitalanagementsystem
{
    internal class utility
    {
        //get the connection string from app config file
        internal static string Connection()
        {
            //assuming failure in retrieval
            string returnValue = null;
            //look for the name in the connectionstring section
            ConnectionStringSettings setting = ConfigurationManager.ConnectionStrings["hospitalanagementsystem.Properties.Settings.constr"];

            //if found, return the connectionstring 
            if(setting!=null)
            {
                returnValue = setting.ConnectionString;
                return returnValue;
            }
            
        }
        
    }
}

in the above code i m having an error in the function name Coneection
the error says "not all code paths return a null value" please help me what should i do
thank you

Posted 30-May-14 22:30pm

siddesh_bobade

Add a Solution

2 solutions

Solution 1

You need a return statement at the end of the method for the case where setting is null.

Posted 30-May-14 22:32pm

Richard MacCutchan

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

DamithSL · Accepted Answer · 2014-05-30T23:07:00

C#

//get the connection string from app config file
internal static string Connection()
{
    //assuming failure in retrieval
    string returnValue = null;
    //look for the name in the connectionstring section
    ConnectionStringSettings setting = ConfigurationManager.ConnectionStrings["hospitalanagementsystem.Properties.Settings.constr"];

    //if found, return the connectionstring 
    if(setting!=null)
    {
        returnValue = setting.ConnectionString;
    }
   return returnValue; // moved this line to end, even in settings null you have return value now
}