Help with C++ Error!!

Question

1.00/5 (2 votes)

See more:

I keep getting this error:
error C2143: syntax error : missing ';' before '}'

C++

#include <iostream>
#include <fstream>
#include <iomanip>

using namespace std;

int main(int argc, const char * argv[])
{
ifstream input;
input.open("text.txt");

int employeeid, numberofemployees;
float hourlyrate, grosspay, hoursworked , taxamount, netpay;
float taxrate=0;
char taxstatus[2];

numberofemployees=0;

while (input>>employeeid>>hoursworked>>hourlyrate>>taxstatus){

grosspay = hoursworked*hourlyrate;

if (grosspay > 1000) taxrate= 0.30;
else if (grosspay > 800 ) taxrate=  0.20;
else if (grosspay > 500) taxrate = 0.10;
else taxrate=0.0;
ifstream input;
if ((((strcmp(taxstatus, "H")==0))||((strcmp(taxstatus, "h")==0))) && (grosspay>500)){
taxrate=taxrate-.05;
}
ifstream input;
if ((((strcmp(taxstatus, "S")==0))||((strcmp(taxstatus, "s")==0))){
taxrate=taxrate-.05;
}
ifstream input;
if ((((strcmp(taxstatus, "M")==0))||((strcmp(taxstatus, "m")==0))){
taxrate=taxrate-.05;

}
taxamount=grosspay*taxrate;
netpay=grosspay-taxamount;
cout<<"THE EMPLOYEE ID IS:"<< employeeid<<endl;
cout<<"THE HOURS WORKED ARE:" <<hoursworked<<endl;
cout<<"THE HOURLY RATE IS:"<< hourlyrate<<endl;
cout<<"THE GROSS PAY IS:" <<grosspay<<endl;
cout<<"THE TAXAMOUNT IS:"<< taxamount<<endl;
cout<<"THE NET PAY IS:"<< netpay<<endl;

}
input.close();
system("pause");
return 0;
}

Posted 18-Jun-14 14:13pm

Member 10893567

Updated 18-Jun-14 14:46pm

PIEBALDconsult

v4

Add a Solution

Comments

PIEBALDconsult 18-Jun-14 20:48pm

Doesn't it say which line?

Member 10893567 18-Jun-14 20:55pm

Yes it says line 53, which is the last line with }

PIEBALDconsult 18-Jun-14 22:59pm

I think you need a better compiler.

Stefan_Lang 19-Jun-14 3:07am

Actually all he needs is a better editor - mine (using VS with VisualAssist) immediately pointed out the surplus opening brackets in the last two if statements. Alternately it might be a missing closing bracket as suggested in Solution 2, I didn't bother to check which it is ;-)

PIEBALDconsult 19-Jun-14 9:07am

The editor doesn't produce error messages.

Stefan_Lang 19-Jun-14 10:21am

I didn't say it does - it does point out the misplaced brackets with red wriggly underlining though.

PIEBALDconsult 19-Jun-14 10:32am

Doesn't that rely on information from the compiler?

Stefan_Lang 19-Jun-14 10:48am

Nope. VisualAssist is a plugin thar effectively replaces Intellisense. It does it's own syntax parsing while you're typing to be able to recognize symbols and suggest autocompletion. Checking bracket pairs is one of the more trivial features it has, but more generally, it will underline any symbol it finds that it cannot interpret as valid C++ syntax. The only area where it falls down is when you encapsulate parts of your code in #ifdef, or when you overdoing meta-template programming. but it does get a whole lot farther, is way more reliable, and worlds faster than any version of Intellisense I've ever seen.

PIEBALDconsult 19-Jun-14 11:03am

What does it make of the taxrate=taxrate-.05; above?

Stefan_Lang 20-Jun-14 2:11am

Nothing. It's legal in both C and C++ (I actually checked)

PIEBALDconsult 20-Jun-14 8:51am

As did I last night. Horrible construct.

Code-o-mat 19-Jun-14 10:37am

Vi!!!!!

Stefan_Lang 19-Jun-14 10:49am

Been there, done that. I prefer VisualAssist.

Code-o-mat 19-Jun-14 11:00am

ACtually i could never stand Vi...

[no name] 18-Jun-14 21:21pm

Well first you need to learn how to use a spacebar. Crowding all your statements together makes things harder to see.
Count the open and close parenthesis on the taxstatus, "S" and taxstatus, "M" lines.
Stop redefining the same variable over and over (input).

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

_Asif_ · Answer 1 · 2014-06-18T19:13:00

Solution 2

Add one bracket in both these lines

C++

if ((((strcmp(taxstatus, "S")==0))||((strcmp(taxstatus, "s")==0)))){


if ((((strcmp(taxstatus, "M")==0))||((strcmp(taxstatus, "m")==0)))){

Posted 18-Jun-14 19:13pm

_Asif_

Comments

Stefan_Lang 19-Jun-14 3:08am

Yup, that's what my editor said, too. +5

PIEBALDconsult 19-Jun-14 11:16am

Certainly not a bracket.

KarstenK · Answer 2 · 2014-06-18T21:30:00

it is a bracket too much opened, but write cleaner code:

C++

if ((((strcmp(taxstatus, "H")==0))||((strcmp(taxstatus, "h")==0))) && (grosspay>500)){

//is is enough bur use space
if ( ( (strcmp(taxstatus, "H")==0) || ((strcmp(taxstatus, "h")==0) && (grosspay>500) ) {

instead of

strcmp(taxstatus, "S")==0)

you better write

switch( taxstatus[0] )
{
case 'H:'
case 'h':

because it is a single character!!!

input.open("text.txt"); //file should have a full path

PIEBALDconsult · Answer 3 · 2014-06-18T14:55:00

Solution 1

Isn't .05 an invalid numeric literal? Just guessing here.

Huh. Seems I'm wrong. I've never seen anyone actually begin a floating point (or related) literal with the decimal point and would never do so myself, but it appears to be OK. Weird.

Posted 18-Jun-14 14:55pm